github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 20:38:54 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #2404] [MERGED] [Goals] Schedule top off amount #53591

New Issue
Closed
opened 2026-04-30 22:22:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 22:22:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2404
Author: @shall0pass
Created: 2/29/2024
Status: ✅ Merged
Merged: 3/4/2024
Merged by: @shall0pass

Base: master ← Head: scheduleInvestigation

📝 Commits (6)

  • bd220ed add log messages to schedule templates
  • 6b2704a log the included schedules
  • e85578b more log output
  • 893571e use a negate filter for sinking funds
  • ba36aaa carve out a top out exception if no sinking funds
  • 36c7044 note

📊 Changes

2 files changed (+25 additions, -27 deletions)

View changed files

📝 packages/loot-core/src/server/budget/goals/goalsSchedule.ts (+19 -27)
➕ upcoming-release-notes/2404.md (+6 -0)

📄 Description

A simple schedule, one that is recurring monthly and is budgeted fully every month, would not consider an existing balance. This PR adds 2 things.

  1. If a simple schedule, not combined with schedule it is greater than 1 month (sinking fund), has a category balance and that balance is less than needed to complete the schedule... the budgeted amount will only add the difference needed to complete the schedule.
    Example: 75 is needed for this month, 50 is in the category from last month. The budgeted amount will be 25. (Previously, it would be 75.)

  2. The filter for finding schedules is simplified and less error prone. The only filter specified is one for monthly recurring or 'full' schedules. This PR implements a negate filter for all other schedules so it's more guaranteed not to inadvertently drop one from the list.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2404 **Author:** [@shall0pass](https://github.com/shall0pass) **Created:** 2/29/2024 **Status:** ✅ Merged **Merged:** 3/4/2024 **Merged by:** [@shall0pass](https://github.com/shall0pass) **Base:** `master` ← **Head:** `scheduleInvestigation` --- ### 📝 Commits (6) - [`bd220ed`](https://github.com/actualbudget/actual/commit/bd220edce2735efe63386617705b2bbc2e6453a4) add log messages to schedule templates - [`6b2704a`](https://github.com/actualbudget/actual/commit/6b2704adb3ec8f6c92ba59bd32fb57c2e1dcbc5b) log the included schedules - [`e85578b`](https://github.com/actualbudget/actual/commit/e85578b209fe198422a70085972dd3469303460d) more log output - [`893571e`](https://github.com/actualbudget/actual/commit/893571ec6cfddcf681ccb1d77a45bab8643f6b0b) use a negate filter for sinking funds - [`ba36aaa`](https://github.com/actualbudget/actual/commit/ba36aaa354ac4144e97582a14b05a64321d2adfd) carve out a top out exception if no sinking funds - [`36c7044`](https://github.com/actualbudget/actual/commit/36c70440d888af637a6eca08d4cdae4708a930a0) note ### 📊 Changes **2 files changed** (+25 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/goals/goalsSchedule.ts` (+19 -27) ➕ `upcoming-release-notes/2404.md` (+6 -0) </details> ### 📄 Description A simple schedule, one that is recurring monthly and is budgeted fully every month, would not consider an existing balance. This PR adds 2 things. 1. If a simple schedule, not combined with schedule it is greater than 1 month (sinking fund), has a category balance and that balance is less than needed to complete the schedule... the budgeted amount will only add the difference needed to complete the schedule. Example: 75 is needed for this month, 50 is in the category from last month. The budgeted amount will be 25. (Previously, it would be 75.) 2. The filter for finding schedules is simplified and less error prone. The only filter specified is one for monthly recurring or 'full' schedules. This PR implements a negate filter for all other schedules so it's more guaranteed not to inadvertently drop one from the list. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 22:22:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#53591
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?