[PR #2357] [MERGED] ♻️ (eslint) enable some rules to enforce better code quality #53571

Closed
opened 2026-04-30 22:21:23 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2357
Author: @MatissJanis
Created: 2/11/2024
Status: Merged
Merged: 2/16/2024
Merged by: @MatissJanis

Base: masterHead: matiss/eslint


📝 Commits (5)

  • 60c32a3 ♻️ (eslint) enable some rules to enforce better code quality
  • b66f7fe Patch ts
  • 105d058 Merge branch 'master' into matiss/eslint
  • b1e2293 Fix linter
  • 939227b Merge branch 'master' into matiss/eslint

📊 Changes

19 files changed (+117 additions, -9 deletions)

View changed files

📝 .eslintrc.js (+66 -9)
📝 packages/desktop-client/src/components/budget/BudgetCategories.jsx (+2 -0)
📝 packages/desktop-client/src/components/budget/BudgetPageHeader.tsx (+2 -0)
📝 packages/desktop-client/src/components/budget/DynamicBudgetTable.tsx (+4 -0)
📝 packages/desktop-client/src/components/budget/index.tsx (+2 -0)
📝 packages/desktop-client/src/components/common/Button.tsx (+4 -0)
📝 packages/desktop-client/src/components/common/Card.tsx (+2 -0)
📝 packages/desktop-client/src/components/common/ExternalLink.tsx (+2 -0)
📝 packages/desktop-client/src/components/common/Stack.tsx (+2 -0)
📝 packages/desktop-client/src/components/payees/ManagePayees.jsx (+2 -0)
📝 packages/desktop-client/src/components/payees/PayeeTable.tsx (+2 -0)
📝 packages/desktop-client/src/components/payees/PayeeTableRow.tsx (+2 -0)
📝 packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableRow.tsx (+2 -0)
📝 packages/desktop-client/src/components/rules/RuleRow.tsx (+2 -0)
📝 packages/desktop-client/src/components/select/DateSelect.tsx (+2 -0)
📝 packages/desktop-client/src/components/table.tsx (+5 -0)
📝 packages/desktop-client/src/components/transactions/MobileTransaction.jsx (+4 -0)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.jsx (+4 -0)
upcoming-release-notes/2357.md (+6 -0)

📄 Description


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2357 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 2/11/2024 **Status:** ✅ Merged **Merged:** 2/16/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/eslint` --- ### 📝 Commits (5) - [`60c32a3`](https://github.com/actualbudget/actual/commit/60c32a36b5c18f8810310eaf6f0622fb344938c4) :recycle: (eslint) enable some rules to enforce better code quality - [`b66f7fe`](https://github.com/actualbudget/actual/commit/b66f7fef40de6dbf8a0acc12b28f893e2a8d7c8d) Patch ts - [`105d058`](https://github.com/actualbudget/actual/commit/105d058650e7997eb90ed62574226336021c1354) Merge branch 'master' into matiss/eslint - [`b1e2293`](https://github.com/actualbudget/actual/commit/b1e2293985017eda2ae16d621374ef79a1bb6a13) Fix linter - [`939227b`](https://github.com/actualbudget/actual/commit/939227bc280bc1d61522d5a66e21a2c9a5ba4f47) Merge branch 'master' into matiss/eslint ### 📊 Changes **19 files changed** (+117 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+66 -9) 📝 `packages/desktop-client/src/components/budget/BudgetCategories.jsx` (+2 -0) 📝 `packages/desktop-client/src/components/budget/BudgetPageHeader.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/budget/DynamicBudgetTable.tsx` (+4 -0) 📝 `packages/desktop-client/src/components/budget/index.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/common/Button.tsx` (+4 -0) 📝 `packages/desktop-client/src/components/common/Card.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/common/ExternalLink.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/common/Stack.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/payees/ManagePayees.jsx` (+2 -0) 📝 `packages/desktop-client/src/components/payees/PayeeTable.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/payees/PayeeTableRow.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableRow.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/rules/RuleRow.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/select/DateSelect.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/table.tsx` (+5 -0) 📝 `packages/desktop-client/src/components/transactions/MobileTransaction.jsx` (+4 -0) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.jsx` (+4 -0) ➕ `upcoming-release-notes/2357.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 22:21:23 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#53571