[PR #2001] [CLOSED] [WIP] Goals: Schedules annual shortfall method #53368

Closed
opened 2026-04-30 21:59:34 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2001
Author: @shall0pass
Created: 12/1/2023
Status: Closed

Base: masterHead: schedule_annualShortfallMethod


📝 Commits (9)

  • a3ce889 another schedule logic method
  • e6e0def simplification
  • 7bfec3b Merge branch 'master' into schedule_evequefou2
  • 3512745 Merge branch 'master' into schedule_evequefou2
  • 7d247c6 cleanup functions after merging master
  • e6290a6 Merge branch 'actualbudget:master' into schedule_evequefou2
  • cf70e1b more
  • 1948648 remove unneeded fields in object
  • b684539 Merge branch 'actualbudget:master' into schedule_evequefou2

📊 Changes

3 files changed (+222 additions, -81 deletions)

View changed files

📝 packages/loot-core/src/server/budget/goals/goalsSchedule.ts (+209 -76)
📝 packages/loot-core/src/server/budget/goaltemplates.ts (+5 -5)
📝 packages/loot-core/src/shared/months.ts (+8 -0)

📄 Description

Only posting this for testing purposes at the moment. There is some cleanup needed before it would be ready.

Known issue: The first month (with no balance), the routine calculates double the amount needed.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2001 **Author:** [@shall0pass](https://github.com/shall0pass) **Created:** 12/1/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `schedule_annualShortfallMethod` --- ### 📝 Commits (9) - [`a3ce889`](https://github.com/actualbudget/actual/commit/a3ce8897a4b915cbaf69ec9de34bfdbec815f8bf) another schedule logic method - [`e6e0def`](https://github.com/actualbudget/actual/commit/e6e0def7075ab35bdbcb37c8279f26dfbb4af20e) simplification - [`7bfec3b`](https://github.com/actualbudget/actual/commit/7bfec3be40406894c59004ac74a8e38f104b14ab) Merge branch 'master' into schedule_evequefou2 - [`3512745`](https://github.com/actualbudget/actual/commit/3512745baa6346aff9639551e2613aff7fb1181a) Merge branch 'master' into schedule_evequefou2 - [`7d247c6`](https://github.com/actualbudget/actual/commit/7d247c6e9a1a19d0c27e2e11b96dbfe5cbf75da8) cleanup functions after merging master - [`e6290a6`](https://github.com/actualbudget/actual/commit/e6290a6a47300c6693b706d9634483c6b1ab4048) Merge branch 'actualbudget:master' into schedule_evequefou2 - [`cf70e1b`](https://github.com/actualbudget/actual/commit/cf70e1b35d6ee848fd682db67d1c3ba477b16968) more - [`1948648`](https://github.com/actualbudget/actual/commit/19486483d48957fab822b026dc33fd57873c3c6c) remove unneeded fields in object - [`b684539`](https://github.com/actualbudget/actual/commit/b6845393560f5744b72506852d9d46f2347e4414) Merge branch 'actualbudget:master' into schedule_evequefou2 ### 📊 Changes **3 files changed** (+222 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/goals/goalsSchedule.ts` (+209 -76) 📝 `packages/loot-core/src/server/budget/goaltemplates.ts` (+5 -5) 📝 `packages/loot-core/src/shared/months.ts` (+8 -0) </details> ### 📄 Description Only posting this for testing purposes at the moment. There is some cleanup needed before it would be ready. Known issue: The first month (with no balance), the routine calculates double the amount needed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 21:59:34 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#53368