github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #1885] [MERGED] Fix crash when undoing a rule application #53309

New Issue
Closed
opened 2026-04-30 21:52:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 21:52:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1885
Author: @jfdoming
Created: 11/9/2023
Status: ✅ Merged
Merged: 11/21/2023
Merged by: @joel-jeremy

Base: master ← Head: jfdoming/rules-modal-undo-crash-fix

📝 Commits (9)

  • 634fd21 Undo shouldn't open modal if it wasn't open before
  • ca3a778 Add release notes
  • ca672a0 Merge branch 'master' into jfdoming/rules-modal-undo-crash-fix
  • dca07ff Merge branch 'master' into jfdoming/rules-modal-undo-crash-fix
  • ca8aa2d Merge branch 'master' into jfdoming/rules-modal-undo-crash-fix
  • 426e0b0 Merge branch 'master' into jfdoming/rules-modal-undo-crash-fix
  • ddcc1c6 Merge branch 'master' into jfdoming/rules-modal-undo-crash-fix
  • 7b7ae76 Merge branch 'master' into jfdoming/rules-modal-undo-crash-fix
  • 05760d2 Merge branch 'master' into jfdoming/rules-modal-undo-crash-fix

📊 Changes

3 files changed (+10 additions, -2 deletions)

View changed files

📝 packages/desktop-client/src/components/ManageRules.tsx (+3 -1)
📝 packages/desktop-client/src/components/Modals.tsx (+1 -1)
➕ upcoming-release-notes/1885.md (+6 -0)

📄 Description

Fix crash when hitting undo after applying a rule to some transactions (closes #1831).

Question: This fix exposes some weird (pre-existing) behaviour, where hitting undo for a rule-apply causes the application to send you to the rules page with no modal open, which is confusing as you do not see the transactions you are undoing the change for. We could:

  1. Send the user to the rules page AND open the "Edit rule" modal again, showing the previously-applied transactions.
  2. Send the user to the transactions page with the previously-edited transactions selected.
    IMHO 1 makes more sense and would be easier to implement, but I'm curious which you think is better! A similar issue also exists on the Payees page.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1885 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 11/9/2023 **Status:** ✅ Merged **Merged:** 11/21/2023 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `jfdoming/rules-modal-undo-crash-fix` --- ### 📝 Commits (9) - [`634fd21`](https://github.com/actualbudget/actual/commit/634fd216139ca27680257e3b786ca618e5b9f4d8) Undo shouldn't open modal if it wasn't open before - [`ca3a778`](https://github.com/actualbudget/actual/commit/ca3a778ed54e694523f446041aaf4e1c23659aa2) Add release notes - [`ca672a0`](https://github.com/actualbudget/actual/commit/ca672a0685f26a735be0ac6291245a4ffbeaaa1c) Merge branch 'master' into jfdoming/rules-modal-undo-crash-fix - [`dca07ff`](https://github.com/actualbudget/actual/commit/dca07ff343281f4b36c229041c7e72db447635af) Merge branch 'master' into jfdoming/rules-modal-undo-crash-fix - [`ca8aa2d`](https://github.com/actualbudget/actual/commit/ca8aa2d2dea12a53cfcac2c00ab13c498e6e7f8d) Merge branch 'master' into jfdoming/rules-modal-undo-crash-fix - [`426e0b0`](https://github.com/actualbudget/actual/commit/426e0b07ac89229bc2cb9f65e1e3f072f19c2dcc) Merge branch 'master' into jfdoming/rules-modal-undo-crash-fix - [`ddcc1c6`](https://github.com/actualbudget/actual/commit/ddcc1c69342aadaec4ad3729d0240bad809046d5) Merge branch 'master' into jfdoming/rules-modal-undo-crash-fix - [`7b7ae76`](https://github.com/actualbudget/actual/commit/7b7ae76a04ebdcaa55f8dba5549bd72595b206fe) Merge branch 'master' into jfdoming/rules-modal-undo-crash-fix - [`05760d2`](https://github.com/actualbudget/actual/commit/05760d2eec70a0a37a3fdfd5a9151b32ec1b252c) Merge branch 'master' into jfdoming/rules-modal-undo-crash-fix ### 📊 Changes **3 files changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ManageRules.tsx` (+3 -1) 📝 `packages/desktop-client/src/components/Modals.tsx` (+1 -1) ➕ `upcoming-release-notes/1885.md` (+6 -0) </details> ### 📄 Description Fix crash when hitting undo after applying a rule to some transactions (closes #1831). Question: This fix exposes some weird (pre-existing) behaviour, where hitting undo for a rule-apply causes the application to send you to the rules page with no modal open, which is confusing as you do not see the transactions you are undoing the change for. We could: 1. Send the user to the rules page AND open the "Edit rule" modal again, showing the previously-applied transactions. 2. Send the user to the transactions page with the previously-edited transactions selected. IMHO 1 makes more sense and would be easier to implement, but I'm curious which you think is better! A similar issue also exists on the Payees page. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 21:52:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#53309
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?