github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #936] [CLOSED] Fix for #846 - Extra Empty line breaks field selection #52722

New Issue
Closed
opened 2026-04-30 21:06:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 21:06:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/936
Author: @aaroneiche
Created: 4/22/2023
Status: ❌ Closed

Base: master ← Head: InvalidCSVImport

📝 Commits (10+)

  • 32e7ed3 Adds CSV import option to skip empty lines.
  • 6560d3a Adds release notes for 846 bugfix.
  • b0c5a93 Use Peggy instead of deprecated Peg.js (#934)
  • e8a62f8 Migrate core to TS p3 (#896)
  • 7c80a20 ♻️ (autocomplete) cleaning up state updates (#931)
  • 36b2d7d 🎨 (autocomplete) set min-width for the tooltip (#933)
  • c7f6ca4 Fix j/k shortcuts to move between transactions on account pages (#939)
  • 76c69a6 ⬆️ (autocomplete) upgrade Downshift dependency (#945)
  • 6325a36 Don’t reset checked transactions when creating a schedule (#946)
  • 89c065e 🐛 (autocomplete) fix multi-select (#947)

📊 Changes

171 files changed (+1760 additions, -923 deletions)

View changed files

📝 packages/desktop-client/e2e/page-models/rules-page.js (+1 -1)
📝 packages/desktop-client/e2e/page-models/schedules-page.js (+4 -2)
📝 packages/desktop-client/package.json (+2 -2)
📝 packages/desktop-client/playwright.config.js (+1 -0)
📝 packages/desktop-client/src/components/autocomplete/Autocomplete.js (+284 -391)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js (+30 -39)
➖ packages/desktop-client/src/components/autocomplete/autocomplete-styles.js (+0 -87)
📝 packages/desktop-client/src/components/forms.js (+4 -2)
📝 packages/desktop-client/src/components/schedules/EditSchedule.js (+8 -4)
📝 packages/desktop-client/src/components/table.js (+2 -2)
📝 packages/desktop-client/src/components/util/GenericInput.js (+15 -17)
📝 packages/loot-core/.babelrc (+1 -2)
📝 packages/loot-core/jest.config.js (+1 -1)
📝 packages/loot-core/jest.web.config.js (+1 -1)
📝 packages/loot-core/package.json (+4 -3)
➕ packages/loot-core/peg-loader.js (+9 -0)
➕ packages/loot-core/peg-transform.mjs (+24 -0)
📝 packages/loot-core/src/client/actions/account.ts (+0 -9)
📝 packages/loot-core/src/client/actions/app.ts (+0 -0)
📝 packages/loot-core/src/client/actions/backups.ts (+0 -0)

...and 80 more files

📄 Description

Fixes #846. Sets CSV import option to skip empty lines. This should reduce errors during import as well as purely empty lines are not meaningful data to Actual.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/936 **Author:** [@aaroneiche](https://github.com/aaroneiche) **Created:** 4/22/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `InvalidCSVImport` --- ### 📝 Commits (10+) - [`32e7ed3`](https://github.com/actualbudget/actual/commit/32e7ed3d2ecd0d5409b5fcc6e3a8d748d937a448) Adds CSV import option to skip empty lines. - [`6560d3a`](https://github.com/actualbudget/actual/commit/6560d3a8890e3a80ac6f47e326b662d93fdf48c5) Adds release notes for 846 bugfix. - [`b0c5a93`](https://github.com/actualbudget/actual/commit/b0c5a9389c6ff600f112fc964823e35475ff97a7) Use Peggy instead of deprecated Peg.js (#934) - [`e8a62f8`](https://github.com/actualbudget/actual/commit/e8a62f89a1797d78a0878e860a9730464c19c3b4) Migrate core to TS p3 (#896) - [`7c80a20`](https://github.com/actualbudget/actual/commit/7c80a200d759286fe86b1d0a5c0cde4372758edf) :recycle: (autocomplete) cleaning up state updates (#931) - [`36b2d7d`](https://github.com/actualbudget/actual/commit/36b2d7d09031450a1dafe100bd4bf81007b89390) :art: (autocomplete) set min-width for the tooltip (#933) - [`c7f6ca4`](https://github.com/actualbudget/actual/commit/c7f6ca4302b2aece2577c994435e3146cc3cecd3) Fix j/k shortcuts to move between transactions on account pages (#939) - [`76c69a6`](https://github.com/actualbudget/actual/commit/76c69a6e700429acb509cd6c442cd17962b3d7c9) :arrow_up: (autocomplete) upgrade Downshift dependency (#945) - [`6325a36`](https://github.com/actualbudget/actual/commit/6325a3684736d56fd91e575bf91edf1893d66e66) Don’t reset checked transactions when creating a schedule (#946) - [`89c065e`](https://github.com/actualbudget/actual/commit/89c065e401d52522c7a62ae8ae2c94a167c81c31) :bug: (autocomplete) fix multi-select (#947) ### 📊 Changes **171 files changed** (+1760 additions, -923 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/page-models/rules-page.js` (+1 -1) 📝 `packages/desktop-client/e2e/page-models/schedules-page.js` (+4 -2) 📝 `packages/desktop-client/package.json` (+2 -2) 📝 `packages/desktop-client/playwright.config.js` (+1 -0) 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.js` (+284 -391) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js` (+30 -39) ➖ `packages/desktop-client/src/components/autocomplete/autocomplete-styles.js` (+0 -87) 📝 `packages/desktop-client/src/components/forms.js` (+4 -2) 📝 `packages/desktop-client/src/components/schedules/EditSchedule.js` (+8 -4) 📝 `packages/desktop-client/src/components/table.js` (+2 -2) 📝 `packages/desktop-client/src/components/util/GenericInput.js` (+15 -17) 📝 `packages/loot-core/.babelrc` (+1 -2) 📝 `packages/loot-core/jest.config.js` (+1 -1) 📝 `packages/loot-core/jest.web.config.js` (+1 -1) 📝 `packages/loot-core/package.json` (+4 -3) ➕ `packages/loot-core/peg-loader.js` (+9 -0) ➕ `packages/loot-core/peg-transform.mjs` (+24 -0) 📝 `packages/loot-core/src/client/actions/account.ts` (+0 -9) 📝 `packages/loot-core/src/client/actions/app.ts` (+0 -0) 📝 `packages/loot-core/src/client/actions/backups.ts` (+0 -0) _...and 80 more files_ </details> ### 📄 Description Fixes #846. Sets CSV import option to skip empty lines. This should reduce errors during import as well as purely empty lines are not meaningful data to Actual. <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 21:06:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#52722
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?