github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #861] [MERGED] Enable linting for all packages #52676

New Issue
Closed
opened 2026-04-30 21:04:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 21:04:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/861
Author: @j-f1
Created: 4/6/2023
Status: ✅ Merged
Merged: 4/6/2023
Merged by: @j-f1

Base: master ← Head: jed/lint-everything

📝 Commits (10+)

  • db5bd36 Remove explicit ESLint devDependency from packages
  • da4572b Upgrade ESLint to 8.37.0
  • c98e65e Add lint scripts to all packages
  • bdb8e3d Add/update .eslintignores
  • b2ea7b2 + build:browser top level script
  • 5b56ef8 Fix auto-fixable issues
  • 0bd305f no-unused-vars
  • 735fc2b rulesdir/typography: ignore innerHTML values
  • 7f95c2c rulesdir/typography: ignore executeJavaScript
  • 45d1e52 rulesdir/typography

📊 Changes

49 files changed (+326 additions, -409 deletions)

View changed files

📝 package.json (+2 -1)
➕ packages/api/.eslintignore (+1 -0)
📝 packages/api/app/query.js (+6 -24)
📝 packages/api/methods.js (+0 -4)
📝 packages/api/migrations/1632571489012_remove_cache.js (+11 -11)
📝 packages/api/package.json (+1 -0)
📝 packages/desktop-client/.eslintignore (+3 -1)
📝 packages/desktop-client/e2e/budget.test.js (+1 -1)
📝 packages/desktop-client/e2e/onboarding.test.js (+2 -1)
📝 packages/desktop-client/e2e/transactions.test.js (+9 -9)
📝 packages/desktop-client/package.json (+1 -2)
📝 packages/desktop-client/public/data/migrations/1632571489012_remove_cache.js (+11 -11)
📝 packages/desktop-client/src/browser-server.js (+2 -2)
📝 packages/desktop-client/src/style.js (+0 -1)
➕ packages/desktop-electron/.eslintignore (+2 -0)
📝 packages/desktop-electron/about.js (+3 -3)
📝 packages/desktop-electron/about/index.js (+2 -2)
📝 packages/desktop-electron/afterSignHook.js (+4 -3)
📝 packages/desktop-electron/findOpenSocket.js (+0 -3)
📝 packages/desktop-electron/index.js (+5 -7)

...and 29 more files

📄 Description

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/861 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 4/6/2023 **Status:** ✅ Merged **Merged:** 4/6/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/lint-everything` --- ### 📝 Commits (10+) - [`db5bd36`](https://github.com/actualbudget/actual/commit/db5bd36a720f5bb25274fc2a49090e4346a7bc4c) Remove explicit ESLint devDependency from packages - [`da4572b`](https://github.com/actualbudget/actual/commit/da4572bea4bc300f632106bbf2142e8fa260b8d8) Upgrade ESLint to 8.37.0 - [`c98e65e`](https://github.com/actualbudget/actual/commit/c98e65eeb863c541559c4966f076696acba51613) Add lint scripts to all packages - [`bdb8e3d`](https://github.com/actualbudget/actual/commit/bdb8e3ddb29d5fde070c2a0962e71c1fe8cd166f) Add/update .eslintignores - [`b2ea7b2`](https://github.com/actualbudget/actual/commit/b2ea7b2c2914225b0d18f8ea3e1f06a060174f82) + build:browser top level script - [`5b56ef8`](https://github.com/actualbudget/actual/commit/5b56ef82f39fe468c965eeec4bf286f119441e64) Fix auto-fixable issues - [`0bd305f`](https://github.com/actualbudget/actual/commit/0bd305fdbfd53502e0fe1f36ce98a163f7432a4b) no-unused-vars - [`735fc2b`](https://github.com/actualbudget/actual/commit/735fc2b80fb5b7cc4ad1d48bbb4e6b0f9b144767) rulesdir/typography: ignore `innerHTML` values - [`7f95c2c`](https://github.com/actualbudget/actual/commit/7f95c2c0bafaf5225cd54a3c9f99f8a17cc380d9) rulesdir/typography: ignore executeJavaScript - [`45d1e52`](https://github.com/actualbudget/actual/commit/45d1e525a0d746d3eeef68eb2893c924f2e1a7ba) rulesdir/typography ### 📊 Changes **49 files changed** (+326 additions, -409 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+2 -1) ➕ `packages/api/.eslintignore` (+1 -0) 📝 `packages/api/app/query.js` (+6 -24) 📝 `packages/api/methods.js` (+0 -4) 📝 `packages/api/migrations/1632571489012_remove_cache.js` (+11 -11) 📝 `packages/api/package.json` (+1 -0) 📝 `packages/desktop-client/.eslintignore` (+3 -1) 📝 `packages/desktop-client/e2e/budget.test.js` (+1 -1) 📝 `packages/desktop-client/e2e/onboarding.test.js` (+2 -1) 📝 `packages/desktop-client/e2e/transactions.test.js` (+9 -9) 📝 `packages/desktop-client/package.json` (+1 -2) 📝 `packages/desktop-client/public/data/migrations/1632571489012_remove_cache.js` (+11 -11) 📝 `packages/desktop-client/src/browser-server.js` (+2 -2) 📝 `packages/desktop-client/src/style.js` (+0 -1) ➕ `packages/desktop-electron/.eslintignore` (+2 -0) 📝 `packages/desktop-electron/about.js` (+3 -3) 📝 `packages/desktop-electron/about/index.js` (+2 -2) 📝 `packages/desktop-electron/afterSignHook.js` (+4 -3) 📝 `packages/desktop-electron/findOpenSocket.js` (+0 -3) 📝 `packages/desktop-electron/index.js` (+5 -7) _...and 29 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 21:04:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#52676
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?