[PR #4206] [MERGED] Custom upcoming length #5257

Closed
opened 2026-02-28 21:09:13 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4206
Author: @SamBobBarnes
Created: 1/20/2025
Status: Merged
Merged: 1/23/2025
Merged by: @matt-fidd

Base: masterHead: Custom-upcoming-length


📝 Commits (10+)

  • 5686009 save button
  • 97e6c5d release notes
  • d21444a custom component shows
  • a21c4d4 custom input and saving working
  • c542092 updated getUpcomingDays to handle custom values
  • bcc43f9 close modal after save
  • 6cfd7a9 test around getUpcomingDays
  • 5b7a0b7 Merge branch 'master' into Custom-upcoming-length
  • 4422427 updated to use more accurate timespan calculation
  • b22d5c8 Merge remote-tracking branch 'origin/Custom-upcoming-length' into Custom-upcoming-length

📊 Changes

5 files changed (+170 additions, -6 deletions)

View changed files

packages/desktop-client/src/components/schedules/CustomUpcomingLength.tsx (+58 -0)
📝 packages/desktop-client/src/components/schedules/UpcomingLength.tsx (+66 -4)
📝 packages/loot-core/src/shared/schedules.test.ts (+21 -1)
📝 packages/loot-core/src/shared/schedules.ts (+19 -1)
upcoming-release-notes/4206.md (+6 -0)

📄 Description

Add custom option to upcoming length selector.
Not sure I'm happy with the layout of this feature. I welcome any input.
Also the save functionality is a bit abrupt, not sure if a quick save animation is warranted, tho I haven't seen anything like that elsewhere in the application.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4206 **Author:** [@SamBobBarnes](https://github.com/SamBobBarnes) **Created:** 1/20/2025 **Status:** ✅ Merged **Merged:** 1/23/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `Custom-upcoming-length` --- ### 📝 Commits (10+) - [`5686009`](https://github.com/actualbudget/actual/commit/5686009ceecaec60e65bee4c764d618c7599b5ac) save button - [`97e6c5d`](https://github.com/actualbudget/actual/commit/97e6c5dc3e7d3ad95642019a526c1a7ffa22a9de) release notes - [`d21444a`](https://github.com/actualbudget/actual/commit/d21444a1bf13963ecb6efb2878dbb581e02e3e3c) custom component shows - [`a21c4d4`](https://github.com/actualbudget/actual/commit/a21c4d45d2b5bcc3bcb7f3eb1f1cb0575eaa5979) custom input and saving working - [`c542092`](https://github.com/actualbudget/actual/commit/c542092212fc63db28cecc363dca25ef5ecf6cfa) updated getUpcomingDays to handle custom values - [`bcc43f9`](https://github.com/actualbudget/actual/commit/bcc43f9a2369137bb17b79b68b7a1aad45916d22) close modal after save - [`6cfd7a9`](https://github.com/actualbudget/actual/commit/6cfd7a9968a63961d5287c38a514257bdbd5c9b2) test around getUpcomingDays - [`5b7a0b7`](https://github.com/actualbudget/actual/commit/5b7a0b7c94d5c210b1c6abf8dbd2441e4f2c6582) Merge branch 'master' into Custom-upcoming-length - [`4422427`](https://github.com/actualbudget/actual/commit/442242742166269c652a85a9901090ad491444ca) updated to use more accurate timespan calculation - [`b22d5c8`](https://github.com/actualbudget/actual/commit/b22d5c81e59615444d8b8caf863979145577324f) Merge remote-tracking branch 'origin/Custom-upcoming-length' into Custom-upcoming-length ### 📊 Changes **5 files changed** (+170 additions, -6 deletions) <details> <summary>View changed files</summary> ➕ `packages/desktop-client/src/components/schedules/CustomUpcomingLength.tsx` (+58 -0) 📝 `packages/desktop-client/src/components/schedules/UpcomingLength.tsx` (+66 -4) 📝 `packages/loot-core/src/shared/schedules.test.ts` (+21 -1) 📝 `packages/loot-core/src/shared/schedules.ts` (+19 -1) ➕ `upcoming-release-notes/4206.md` (+6 -0) </details> ### 📄 Description Add custom option to upcoming length selector. Not sure I'm happy with the layout of this feature. I welcome any input. Also the save functionality is a bit abrupt, not sure if a quick save animation is warranted, tho I haven't seen anything like that elsewhere in the application. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:09:13 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5257