github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #416] [MERGED] test: bare-bones e2e testing with playwright #52421

New Issue
Closed
opened 2026-04-30 20:49:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 20:49:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/416
Author: @MatissJanis
Created: 12/30/2022
Status: ✅ Merged
Merged: 1/12/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/e2e-tests

📝 Commits (10+)

  • fc4075d test: bare-bones e2e testing with playwright
  • c7f7616 CI job fixes
  • 3126eae Better github action definition
  • 0aa188d Some more changes to CICD
  • 09cb951 Merge branch 'actualbudget:master' into matiss/e2e-tests
  • f1568ae CICD performance improvements - yarn caching
  • 86e7918 transaction table e2e tests + fixes
  • 24af7f0 Change report path
  • 6ac55d2 Lint fixes
  • 2607192 ci: capture screenshots

📊 Changes

14 files changed (+323 additions, -2 deletions)

View changed files

📝 .github/actions/setup/action.yml (+1 -1)
➕ .github/workflows/e2e-test.yml (+41 -0)
📝 package.json (+1 -0)
📝 packages/desktop-client/.gitignore (+1 -0)
📝 packages/desktop-client/README.md (+21 -1)
➕ packages/desktop-client/e2e/page-models/account-page.js (+114 -0)
➕ packages/desktop-client/e2e/page-models/configuration-page.js (+10 -0)
➕ packages/desktop-client/e2e/page-models/navigation.js (+15 -0)
➕ packages/desktop-client/e2e/transactions.test.js (+84 -0)
📝 packages/desktop-client/package.json (+2 -0)
➕ packages/desktop-client/playwright.config.js (+9 -0)
📝 packages/loot-design/src/components/common.js (+1 -0)
📝 packages/loot-design/src/components/sidebar.js (+1 -0)
📝 yarn.lock (+22 -0)

📄 Description

E2E testing solution using playwright

This PR features mostly the addition of the e2e testing framework and one example test (more to come after merging this PR).

Additionally, I added a "create test file" button to the configuration page (very first page new customers see). This button will only be visible in DEV and PREVIEW environments. By having it there we reduce the amount of clicks required to set-up a test budget file. Thus it saves time for the e2e test runner.

Problems:

  • open PRs that are getting updated with more changes: the e2e CI job starts immediately; it does not wait for Netlify deployment to finish. This problem does not exist for new PRs - fixed via a workaround

Missing:

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/416 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 12/30/2022 **Status:** ✅ Merged **Merged:** 1/12/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/e2e-tests` --- ### 📝 Commits (10+) - [`fc4075d`](https://github.com/actualbudget/actual/commit/fc4075d38ba16205cadcf0c3dab3349d7da0c5d6) test: bare-bones e2e testing with playwright - [`c7f7616`](https://github.com/actualbudget/actual/commit/c7f76162e1047f06ad3b6a25b04dc1823cf37cf1) CI job fixes - [`3126eae`](https://github.com/actualbudget/actual/commit/3126eae08e994d4171527b742f147f8b15cfbb6b) Better github action definition - [`0aa188d`](https://github.com/actualbudget/actual/commit/0aa188d4802966e878f0a8cbc0cda5a264f8f86a) Some more changes to CICD - [`09cb951`](https://github.com/actualbudget/actual/commit/09cb9517ee207fe49c5aa7fed5b7f63fdda18516) Merge branch 'actualbudget:master' into matiss/e2e-tests - [`f1568ae`](https://github.com/actualbudget/actual/commit/f1568ae71c5804bea00946b6db2b7260a3cf6f80) CICD performance improvements - yarn caching - [`86e7918`](https://github.com/actualbudget/actual/commit/86e7918d7aad68709c59bd3b60d2f2927e0d004c) transaction table e2e tests + fixes - [`24af7f0`](https://github.com/actualbudget/actual/commit/24af7f0bcacd5192245d4adc0405581a1967e080) Change report path - [`6ac55d2`](https://github.com/actualbudget/actual/commit/6ac55d2e7bc23e2904413be92e806af310aeaf5e) Lint fixes - [`2607192`](https://github.com/actualbudget/actual/commit/260719290c2ae48823bddf12399082733ae6f468) ci: capture screenshots ### 📊 Changes **14 files changed** (+323 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/setup/action.yml` (+1 -1) ➕ `.github/workflows/e2e-test.yml` (+41 -0) 📝 `package.json` (+1 -0) 📝 `packages/desktop-client/.gitignore` (+1 -0) 📝 `packages/desktop-client/README.md` (+21 -1) ➕ `packages/desktop-client/e2e/page-models/account-page.js` (+114 -0) ➕ `packages/desktop-client/e2e/page-models/configuration-page.js` (+10 -0) ➕ `packages/desktop-client/e2e/page-models/navigation.js` (+15 -0) ➕ `packages/desktop-client/e2e/transactions.test.js` (+84 -0) 📝 `packages/desktop-client/package.json` (+2 -0) ➕ `packages/desktop-client/playwright.config.js` (+9 -0) 📝 `packages/loot-design/src/components/common.js` (+1 -0) 📝 `packages/loot-design/src/components/sidebar.js` (+1 -0) 📝 `yarn.lock` (+22 -0) </details> ### 📄 Description E2E testing solution using [playwright](https://playwright.dev/) This PR features mostly the addition of the e2e testing framework and one example test (more to come after merging this PR). Additionally, I added a "create test file" button to the configuration page (very first page new customers see). This button will only be visible in DEV and PREVIEW environments. By having it there we reduce the amount of clicks required to set-up a test budget file. Thus it saves time for the e2e test runner. Problems: - [x] open PRs that are getting updated with more changes: the e2e CI job starts immediately; it does not wait for Netlify deployment to finish. This problem does not exist for new PRs - fixed via a [workaround](https://github.com/JakePartusch/wait-for-netlify-action/issues/6#issuecomment-667644956) Missing: - [x] Documentation - [x] https://github.com/actualbudget/actual/pull/417 needs to be merged before this PR --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 20:49:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#52421
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?