github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #4180] [MERGED] add option to complete non-recurring schedules from transaction menu #5240

New Issue
Closed
opened 2026-02-28 21:08:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:08:50 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4180
Author: @matt-fidd
Created: 1/17/2025
Status: ✅ Merged
Merged: 1/23/2025
Merged by: @matt-fidd

Base: master ← Head: complete-schedule

📝 Commits (4)

  • 9b3cbea add option to complete non-recurring schedule and hide options that can not be used
  • 75173e8 add functionality to other menus too
  • 7c0cb01 note
  • df7e668 hide rules linked to completed schedules from rules page

📊 Changes

9 files changed (+156 additions, -28 deletions)

View changed files

📝 packages/desktop-client/src/components/ManageRules.tsx (+12 -8)
📝 packages/desktop-client/src/components/Modals.tsx (+1 -0)
📝 packages/desktop-client/src/components/accounts/Account.tsx (+12 -7)
📝 packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx (+7 -0)
📝 packages/desktop-client/src/components/modals/ScheduledTransactionMenuModal.tsx (+31 -9)
📝 packages/desktop-client/src/components/transactions/SelectedTransactionsButton.tsx (+49 -2)
📝 packages/desktop-client/src/components/transactions/TransactionMenu.tsx (+37 -2)
📝 packages/loot-core/src/client/state-types/modals.d.ts (+1 -0)
➕ upcoming-release-notes/4180.md (+6 -0)

📄 Description

Fixes https://github.com/actualbudget/actual/issues/923, fixes #3383

There was a discussion in the issue as to whether to delete the schedule instead of complete it, what do you think?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4180 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 1/17/2025 **Status:** ✅ Merged **Merged:** 1/23/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `complete-schedule` --- ### 📝 Commits (4) - [`9b3cbea`](https://github.com/actualbudget/actual/commit/9b3cbead35361d414a1757e8443799a166e76fbc) add option to complete non-recurring schedule and hide options that can not be used - [`75173e8`](https://github.com/actualbudget/actual/commit/75173e8207f2e9e56143061ca9a841a123be67ae) add functionality to other menus too - [`7c0cb01`](https://github.com/actualbudget/actual/commit/7c0cb01c5d745654b55bc1373f9fd59982040322) note - [`df7e668`](https://github.com/actualbudget/actual/commit/df7e668b29fa590b60803df4e610fef03fcc7f44) hide rules linked to completed schedules from rules page ### 📊 Changes **9 files changed** (+156 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ManageRules.tsx` (+12 -8) 📝 `packages/desktop-client/src/components/Modals.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/accounts/Account.tsx` (+12 -7) 📝 `packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx` (+7 -0) 📝 `packages/desktop-client/src/components/modals/ScheduledTransactionMenuModal.tsx` (+31 -9) 📝 `packages/desktop-client/src/components/transactions/SelectedTransactionsButton.tsx` (+49 -2) 📝 `packages/desktop-client/src/components/transactions/TransactionMenu.tsx` (+37 -2) 📝 `packages/loot-core/src/client/state-types/modals.d.ts` (+1 -0) ➕ `upcoming-release-notes/4180.md` (+6 -0) </details> ### 📄 Description Fixes https://github.com/actualbudget/actual/issues/923, fixes #3383 There was a discussion in the issue as to whether to delete the schedule instead of complete it, what do you think? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:08:50 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5240
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?