github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #7659] Add consistent error handling to all four provider reset handlers in CreateAccountModal #52269

New Issue
Open
opened 2026-04-30 20:32:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 20:32:25 -05:00
Owner
Copy Link

Originally created by @coderabbitai[bot] on GitHub (Apr 29, 2026).
Original GitHub issue: https://github.com/actualbudget/actual/issues/7659

Summary

The four bank-sync provider reset handlers in packages/desktop-client/src/components/modals/CreateAccountModal.tsx — onGoCardlessReset, onSimpleFinReset, onPluggyAiReset, and onEnableBankingReset — all chain secret-set IPC calls without try/catch and are invoked via void, meaning any rejection is silently dropped with no user feedback and an ambiguous UI state.

Steps to Reproduce / Context

Flagged during review of PR #7345 (Enable Banking integration). The Enable Banking handler (onEnableBankingReset) uses await Promise.all([...]) so it can reject, while the GoCardless/SimpleFIN/PluggyAI handlers chain void send(...).then(...) — all four share the same missing-error-handling issue.

Proposed Fix

Wrap each reset handler in a try/catch, only update setup state on success, and surface an error notification (e.g. via addNotification) on failure so the user knows the reset did not complete.

References

Originally created by @coderabbitai[bot] on GitHub (Apr 29, 2026). Original GitHub issue: https://github.com/actualbudget/actual/issues/7659 ## Summary The four bank-sync provider reset handlers in `packages/desktop-client/src/components/modals/CreateAccountModal.tsx` — `onGoCardlessReset`, `onSimpleFinReset`, `onPluggyAiReset`, and `onEnableBankingReset` — all chain `secret-set` IPC calls without `try/catch` and are invoked via `void`, meaning any rejection is silently dropped with no user feedback and an ambiguous UI state. ## Steps to Reproduce / Context Flagged during review of PR #7345 (Enable Banking integration). The Enable Banking handler (`onEnableBankingReset`) uses `await Promise.all([...])` so it can reject, while the GoCardless/SimpleFIN/PluggyAI handlers chain `void send(...).then(...)` — all four share the same missing-error-handling issue. ## Proposed Fix Wrap each reset handler in a `try/catch`, only update setup state on success, and surface an error notification (e.g. via `addNotification`) on failure so the user knows the reset did not complete. ## References - PR: https://github.com/actualbudget/actual/pull/7345 - Review comment: https://github.com/actualbudget/actual/pull/7345#discussion_r3159466250 - Requested by: @AurelDemiri
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#52269
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?