mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-15 22:54:03 -05:00
[GH-ISSUE #7552] Update coding guidelines: separate import type statements are acceptable
#52231
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#52231
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @coderabbitai[bot] on GitHub (Apr 19, 2026).
Original GitHub issue: https://github.com/actualbudget/actual/issues/7552
Originally assigned to: @MatissJanis, @Copilot on GitHub.
Background
During review of PR #7503, a CodeRabbit comment flagged that
import type { Browser, Locator } from '@playwright/test'should be consolidated into a single import using inlinetypequalifiers (i.e.import { test as base, type Browser, type Locator } from '@playwright/test').However, this guideline was identified as incorrect by @MatissJanis — separate
import typestatements are valid and acceptable in this codebase.Action Required
Update the coding guidelines (e.g.
AGENTS.mdor equivalent) to clarify that separateimport type { ... }statements from the same module are acceptable and should not be flagged as violations.References
/cc @MatissJanis
@MatissJanis commented on GitHub (Apr 19, 2026):
Instead of UPDATING the guidelines - we can REMOVE them because this is handled automatically by oxfmt/oxlint.