[PR #4156] [CLOSED] [WIP] Feature/sankey chart #5221

Closed
opened 2026-02-28 21:08:26 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4156
Author: @spezzino
Created: 1/15/2025
Status: Closed

Base: masterHead: feature/sankey-chart


📝 Commits (8)

📊 Changes

13 files changed (+824 additions, -44 deletions)

View changed files

📝 packages/desktop-client/package.json (+1 -1)
📝 packages/desktop-client/src/components/reports/Overview.tsx (+19 -0)
📝 packages/desktop-client/src/components/reports/ReportRouter.tsx (+3 -0)
packages/desktop-client/src/components/reports/graphs/SankeyGraph.tsx (+154 -0)
packages/desktop-client/src/components/reports/reports/Sankey.tsx (+251 -0)
packages/desktop-client/src/components/reports/reports/SankeyCard.tsx (+110 -0)
packages/desktop-client/src/components/reports/spreadsheets/sankey-spreadsheet.ts (+202 -0)
📝 packages/desktop-client/src/components/settings/Experimental.tsx (+6 -0)
📝 packages/desktop-client/src/hooks/useFeatureFlag.ts (+1 -0)
📝 packages/loot-core/src/types/models/dashboard.d.ts (+12 -1)
📝 packages/loot-core/src/types/prefs.d.ts (+2 -1)
upcoming-release-notes/4156.md (+6 -0)
📝 yarn.lock (+57 -41)

📄 Description

Attempt to revive the Sankey Chart (#1919), removed due to it being abandoned.

Enhancements over the previous implementation:

  • Updated the files to align them with current code style
  • Added theme colours
  • Added privacy blockers
  • Added common widget filters, live/static mode, saving name, rename/remove actions

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4156 **Author:** [@spezzino](https://github.com/spezzino) **Created:** 1/15/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/sankey-chart` --- ### 📝 Commits (8) - [`b4d25fd`](https://github.com/actualbudget/actual/commit/b4d25fdcffcc1a485edec5714eeeef82c376c0eb) update recharts - [`9240be7`](https://github.com/actualbudget/actual/commit/9240be7649f2426bf2fdd0812610255fdcd8aac4) add sankey chart - [`65bca73`](https://github.com/actualbudget/actual/commit/65bca738042cbe1188a2b99608501a0a0e6b0208) add customization to sankey widget - [`fd4cf47`](https://github.com/actualbudget/actual/commit/fd4cf4726b087cd4cc1f9f378d36a94fdef9232f) save/use sankey widget configuration - [`c0537ee`](https://github.com/actualbudget/actual/commit/c0537ee66c1260aa2cd9eef961a57f320855c616) add sankey flag feedback link - [`7131460`](https://github.com/actualbudget/actual/commit/71314600d41e1017a032fbc27ed60b93855a6206) add release notes - [`2c834e6`](https://github.com/actualbudget/actual/commit/2c834e6529d76d7d0c8b6147ffe842ac5f27d84b) fix lint / type - [`cfba5b0`](https://github.com/actualbudget/actual/commit/cfba5b034ec63723a20ecbbcaab5e4fcf7e644cc) hide sankey card option behind feature flag ### 📊 Changes **13 files changed** (+824 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/package.json` (+1 -1) 📝 `packages/desktop-client/src/components/reports/Overview.tsx` (+19 -0) 📝 `packages/desktop-client/src/components/reports/ReportRouter.tsx` (+3 -0) ➕ `packages/desktop-client/src/components/reports/graphs/SankeyGraph.tsx` (+154 -0) ➕ `packages/desktop-client/src/components/reports/reports/Sankey.tsx` (+251 -0) ➕ `packages/desktop-client/src/components/reports/reports/SankeyCard.tsx` (+110 -0) ➕ `packages/desktop-client/src/components/reports/spreadsheets/sankey-spreadsheet.ts` (+202 -0) 📝 `packages/desktop-client/src/components/settings/Experimental.tsx` (+6 -0) 📝 `packages/desktop-client/src/hooks/useFeatureFlag.ts` (+1 -0) 📝 `packages/loot-core/src/types/models/dashboard.d.ts` (+12 -1) 📝 `packages/loot-core/src/types/prefs.d.ts` (+2 -1) ➕ `upcoming-release-notes/4156.md` (+6 -0) 📝 `yarn.lock` (+57 -41) </details> ### 📄 Description Attempt to revive the Sankey Chart (#1919), removed due to it being abandoned. Enhancements over the previous implementation: - Updated the files to align them with current code style - Added theme colours - Added privacy blockers - Added common widget filters, live/static mode, saving name, rename/remove actions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:08:26 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5221