mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-16 15:14:02 -05:00
[GH-ISSUE #7252] [Maintenance] Migrate "*.electron" and "*.api" file extensions to "resolve.conditions" #52144
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#52144
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MatissJanis on GitHub (Mar 21, 2026).
Original GitHub issue: https://github.com/actualbudget/actual/issues/7252
Originally assigned to: @MatissJanis on GitHub.
Notice: written by AI, but heavily moderated by me.
Summary
The codebase currently uses two different mechanisms for platform-specific module resolution:
.electron.tsor.api.tstoresolve.extensions, soindex.electron.tsis found beforeindex.tspackage.json"exports"field withresolve.conditions(partially adopted indesktop-client)We should consolidate on approach 2: define conditions in
loot-core/package.jsonexports and configureresolve.conditionsin the consuming Vite configs. This makes the resolution explicit and declarative rather than relying on file extension ordering.Current state
Files using platform extensions (all in
packages/loot-core/src/).electron.tsfiles (8):shared/platform.electron.tsserver/encryption/encryption-internals.electron.tsplatform/server/asyncStorage/index.electron.tsplatform/server/connection/index.electron.tsplatform/server/fetch/index.electron.tsplatform/server/fs/index.electron.tsplatform/server/fs/path-join.electron.tsplatform/server/sqlite/index.electron.ts.api.tsfiles (8): Mirror the above. Most are single-line re-exports of the.electronfile (e.g.export * from './index.electron').Vite configs using extension-based resolution
packages/loot-core/vite.desktop.config.ts.electron.js,.electron.ts,.electron.tsxtoresolve.extensionspackages/api/vite.config.ts.api.tstoresolve.extensionspackages/desktop-client/vite.config.tsresolve.conditions: ['electron', ...]for non-generic-browser builds, but also prepends.browser.*extensions for generic browser buildsDesired state
Add conditional exports to
loot-core/package.jsonfor each platform module, using"electron"and"api"conditions that point at the.electron.tsfiles (keeping filenames as-is). Where an.api.tsfile has a different implementation (not just a re-export), the"api"condition should point at that file.Remove redundant
.api.tsre-export files — where an.api.tsfile only doesexport * from './index.electron', delete it and have the"api"condition point directly at the.electron.tsfile.Update all three Vite configs to use
resolve.conditionsinstead of extension-priority:packages/loot-core/vite.desktop.config.ts— useconditions: ['electron', ...]instead of prepending.electron.*extensionspackages/api/vite.config.ts— useconditions: ['api', ...]instead of prepending.api.tsextensionspackages/desktop-client/vite.config.ts— already partially done; clean up any remaining extension-based resolution for electron/apiDo NOT touch
.browser.tsfiles or browser extension resolution — that is being handled separately.Out of scope
.browser.ts/.browser.tsxextension resolution (separate effort).electron.tsfiles@MatissJanis commented on GitHub (Mar 21, 2026):
Doing this work will help us reduce the complexity of our build process quite significantly. Additionally: it might reduce bundle size all across the board.
Unless anyone beats me to it (please do!) I plan on doing this when I'm finished with the other work that has been started. Creating an issue so I would not forget.