[PR #4148] [MERGED] Exclude untranslated languages from builds #5214

Closed
opened 2026-02-28 21:08:16 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4148
Author: @jfdoming
Created: 1/14/2025
Status: Merged
Merged: 1/14/2025
Merged by: @jfdoming

Base: masterHead: jfdoming/exclude-untranslated-languages


📝 Commits (3)

  • 8a3a574 Add script to remove untranslated language JSON files
  • a268aca Remove untranslated languages in CI
  • 482b324 Add release notes

📊 Changes

4 files changed (+59 additions, -0 deletions)

View changed files

📝 .github/actions/setup/action.yml (+4 -0)
📝 bin/package-browser (+1 -0)
packages/desktop-client/bin/remove-untranslated-languages (+48 -0)
upcoming-release-notes/4148.md (+6 -0)

📄 Description

As we start allowing folks to add new languages for translation, we probably don't want to show every language in the UI. Instead of hand-maintaining an allowlist of "good" languages, my idea was to use translation % as a proxy instead.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4148 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 1/14/2025 **Status:** ✅ Merged **Merged:** 1/14/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/exclude-untranslated-languages` --- ### 📝 Commits (3) - [`8a3a574`](https://github.com/actualbudget/actual/commit/8a3a5741a5a8e4d82f4452f01756d742debbf679) Add script to remove untranslated language JSON files - [`a268aca`](https://github.com/actualbudget/actual/commit/a268acaba0508a6c2fd7fc496be734ef4f97a4ad) Remove untranslated languages in CI - [`482b324`](https://github.com/actualbudget/actual/commit/482b3249bbe0762a3550602cf24eea801c0302c2) Add release notes ### 📊 Changes **4 files changed** (+59 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/setup/action.yml` (+4 -0) 📝 `bin/package-browser` (+1 -0) ➕ `packages/desktop-client/bin/remove-untranslated-languages` (+48 -0) ➕ `upcoming-release-notes/4148.md` (+6 -0) </details> ### 📄 Description As we start allowing folks to add new languages for translation, we probably don't want to show every language in the UI. Instead of hand-maintaining an allowlist of "good" languages, my idea was to use translation % as a proxy instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:08:16 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5214