github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #7017] Enforce architectural boundary: sync-server should not import from loot-core #52071

New Issue
Closed
opened 2026-04-30 20:14:38 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-04-30 20:14:38 -05:00
Owner
Copy Link

Originally created by @coderabbitai[bot] on GitHub (Feb 18, 2026).
Original GitHub issue: https://github.com/actualbudget/actual/issues/7017

Originally assigned to: @MatissJanis on GitHub.

Context

As identified in PR #6954 (https://github.com/actualbudget/actual/pull/6954), the sync-server package is currently able to import from loot-core, which violates the intended architectural boundary.

Problem

The sync-server is designed to be currency agnostic and independent from loot-core. However:

PR #6954 added loot-core as a workspace dependency in packages/sync-server/package.json

The build system does not currently prevent or warn about these cross-package imports

Proposed Solution

Remove the global "paths": https://github.com/actualbudget/actual/blob/master/tsconfig.json#L32:L39

Instead rely on yarn workspaces providing the resolution. Only use "paths" for inter-project aliases. But these are not cross-project aliases (i.e. sync-server should not have an alias for loot-core)

Related

Originally created by @coderabbitai[bot] on GitHub (Feb 18, 2026). Original GitHub issue: https://github.com/actualbudget/actual/issues/7017 Originally assigned to: @MatissJanis on GitHub. ## Context As identified in PR #6954 (https://github.com/actualbudget/actual/pull/6954), the sync-server package is currently able to import from loot-core, which violates the intended architectural boundary. ## Problem The sync-server is designed to be currency agnostic and independent from loot-core. However: PR #6954 added `loot-core` as a workspace dependency in `packages/sync-server/package.json` The build system does not currently prevent or warn about these cross-package imports ## Proposed Solution Remove the global "paths": https://github.com/actualbudget/actual/blob/master/tsconfig.json#L32:L39 Instead rely on yarn workspaces providing the resolution. Only use "paths" for inter-project aliases. But these are not cross-project aliases (i.e. `sync-server` should not have an alias for `loot-core`) ## Related - Reported by: @MatissJanis - Context PR: #6954 - Comment: https://github.com/actualbudget/actual/pull/6954
GiteaMirror added the tech debt label 2026-04-30 20:14:38 -05:00
GiteaMirror commented 2026-04-30 20:14:39 -05:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Feb 18, 2026):

Depends on: https://github.com/actualbudget/actual/issues/6309

<!-- gh-comment-id:3923228246 --> @MatissJanis commented on GitHub (Feb 18, 2026): Depends on: https://github.com/actualbudget/actual/issues/6309
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label tech debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#52071
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?