mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-09 11:42:54 -05:00
[PR #4119] [MERGED] [Redux Toolkit Migration] modalsSlice #5194
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#5194
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/actualbudget/actual/pull/4119
Author: @joel-jeremy
Created: 1/9/2025
Status: ✅ Merged
Merged: 3/4/2025
Merged by: @joel-jeremy
Base:
master← Head:redux-toolkit-modals-slice📝 Commits (10+)
fb8ad47Migrate to accountSlicece7509fFix lint and typecheck errorsad6b500Update types57c68c8Fix lintc5d7a72Fix typesc05773bCleanup84c7822Rename filef893837Rename state4e20e6dCleanup05423a1Fix typecheck error📊 Changes
107 files changed (+2438 additions, -1711 deletions)
View changed files
📝
packages/desktop-client/src/components/HelpMenu.tsx(+3 -3)📝
packages/desktop-client/src/components/ManageRules.tsx(+22 -12)📝
packages/desktop-client/src/components/Modals.tsx(+180 -203)📝
packages/desktop-client/src/components/accounts/Account.tsx(+52 -26)📝
packages/desktop-client/src/components/admin/UserAccess/UserAccess.tsx(+9 -3)📝
packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx(+21 -11)📝
packages/desktop-client/src/components/banksync/index.tsx(+16 -4)📝
packages/desktop-client/src/components/budget/goals/CategoryAutomationButton.tsx(+2 -2)📝
packages/desktop-client/src/components/budget/index.tsx(+24 -11)📝
packages/desktop-client/src/components/manager/BudgetList.tsx(+17 -5)📝
packages/desktop-client/src/components/manager/WelcomeScreen.tsx(+4 -2)📝
packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx(+61 -34)📝
packages/desktop-client/src/components/mobile/accounts/Accounts.tsx(+2 -2)📝
packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx(+115 -85)📝
packages/desktop-client/src/components/mobile/budget/index.tsx(+147 -81)📝
packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx(+85 -46)📝
packages/desktop-client/src/components/modals/AccountAutocompleteModal.tsx(+12 -7)📝
packages/desktop-client/src/components/modals/AccountMenuModal.tsx(+5 -8)📝
packages/desktop-client/src/components/modals/BudgetPageMenuModal.tsx(+6 -1)📝
packages/desktop-client/src/components/modals/CategoryAutocompleteModal.tsx(+13 -8)...and 80 more files
📄 Description
actions/account.ts/reducers/account.ts->accounts/accountsSlice.ts[PR #1900] [MERGED] Larger mobile autocomplete fonts and paddings (#4012)actions/queries.ts/reducers/queries.ts->queries/queriesSlice.ts[PR #1910] [CLOSED] Revert "Mobile pages standardized (Colors/UI)" (#4016)actions/app.ts/reducers/app.ts->app/appSlice.ts[PR #1914] [CLOSED] Do not include hidden Categories when adding transactions (#4018)actions/budgets.ts/reducers/budgets.ts->budgets/budgetsSlice.ts[PR #2096] [MERGED] :bug: fix category spending report (#4114)actions/modals.ts/reducers/modals.ts->modals/modalsSlice.tsactions/notifications.ts/reducers/notifications.ts->notifications/notificationsSlice.tsactions/prefs.ts/reducers/prefs.ts->prefs/prefsSlice.tsactions/user.ts/reducers/user.ts->users/usersSlice.tsReviewers - summary of changes (There are a lot more files because we have a lot of modals):
Modaltype tomodalsSliceand updated to be a union type. This results in better autocomplete when dispatchingpushModalmodalsSlice'sModaltype (# 4) so that we don't have to define modal props/options in 2 places🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.