github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #4077] [MERGED] Fix schedule split template amounts #5177

New Issue
Closed
opened 2026-02-28 21:07:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:07:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4077
Author: @jfdoming
Created: 1/2/2025
Status: ✅ Merged
Merged: 1/2/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/fix-schedule-split-template-amounts

📝 Commits (5)

  • 2dcf2ea Fix incorrect argument to goals schedule function
  • 7e58775 Add argument types to prevent similar issues
  • c4d5822 Add release notes
  • 07e4fab Fix test types
  • 5184296 Merge branch 'master' into jfdoming/fix-schedule-split-template-amounts

📊 Changes

5 files changed (+66 additions, -35 deletions)

View changed files

📝 packages/loot-core/src/server/budget/categoryTemplate.ts (+15 -14)
📝 packages/loot-core/src/server/budget/goalsSchedule.test.ts (+16 -4)
📝 packages/loot-core/src/server/budget/goalsSchedule.ts (+22 -12)
📝 packages/loot-core/src/server/budget/goaltemplates.ts (+7 -5)
➕ upcoming-release-notes/4077.md (+6 -0)

📄 Description

https://github.com/actualbudget/actual/pull/2652 was accidentally reverted due to an incorrect argument type. This PR fixes the issue and adds Typescript types to attempt to prevent regressions in the future.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4077 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 1/2/2025 **Status:** ✅ Merged **Merged:** 1/2/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/fix-schedule-split-template-amounts` --- ### 📝 Commits (5) - [`2dcf2ea`](https://github.com/actualbudget/actual/commit/2dcf2ea14e0288fb93fd3d278f89f8a0e9819663) Fix incorrect argument to goals schedule function - [`7e58775`](https://github.com/actualbudget/actual/commit/7e5877531dd4b8bf0132b53f98daccb7b789cbac) Add argument types to prevent similar issues - [`c4d5822`](https://github.com/actualbudget/actual/commit/c4d58222b84f8e8bdfe482ed14f7e3ba9b5bbdaa) Add release notes - [`07e4fab`](https://github.com/actualbudget/actual/commit/07e4fab7d257ddde2aa4356991a280fa169b14db) Fix test types - [`5184296`](https://github.com/actualbudget/actual/commit/518429635e7a932cea1306fe0aaed2eb21a0c02a) Merge branch 'master' into jfdoming/fix-schedule-split-template-amounts ### 📊 Changes **5 files changed** (+66 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/categoryTemplate.ts` (+15 -14) 📝 `packages/loot-core/src/server/budget/goalsSchedule.test.ts` (+16 -4) 📝 `packages/loot-core/src/server/budget/goalsSchedule.ts` (+22 -12) 📝 `packages/loot-core/src/server/budget/goaltemplates.ts` (+7 -5) ➕ `upcoming-release-notes/4077.md` (+6 -0) </details> ### 📄 Description https://github.com/actualbudget/actual/pull/2652 was accidentally reverted due to an incorrect argument type. This PR fixes the issue and adds Typescript types to attempt to prevent regressions in the future. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:07:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5177
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?