github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-15 22:54:03 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #4041] [MERGED] 🌍 improve translation strings - part 1 #5161

New Issue
Closed
opened 2026-02-28 21:07:04 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:07:04 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4041
Author: @matt-fidd
Created: 12/26/2024
Status: ✅ Merged
Merged: 1/7/2025
Merged by: @matt-fidd

Base: master ← Head: translation-consistency

📝 Commits (10+)

📊 Changes

59 files changed (+644 additions, -446 deletions)

View changed files

📝 packages/desktop-client/e2e/page-models/navigation.js (+1 -1)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.mobile.test.js-snapshots/Mobile-Settings-checks-that-settings-page-can-be-opened-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.mobile.test.js-snapshots/Mobile-Settings-checks-that-settings-page-can-be-opened-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.mobile.test.js-snapshots/Mobile-Settings-checks-that-settings-page-can-be-opened-6-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/App.tsx (+1 -1)
📝 packages/desktop-client/src/components/LoggedInUser.tsx (+13 -4)
📝 packages/desktop-client/src/components/Modals.tsx (+1 -1)
📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.tsx (+1 -1)
📝 packages/desktop-client/src/components/admin/UserAccess/UserAccess.tsx (+9 -9)
📝 packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx (+11 -11)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (+2 -2)

...and 39 more files

📄 Description

This is the first of a series of changes to improve the translatable strings generated with react-i18n. At the moment, some sentences are broken up and lose context once exported.

This PR is already quite big, and I'm barely past B in the locale file so there might be quite a few parts to this to make the reviews more manageable.

I've also fixed any typos I've seen and migrated every file I've been in so far to use <Trans> inside React components where possible for consistency. There are also some places where the text used for the same action is inconsistent across the app - I've changed these where possible too.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4041 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 12/26/2024 **Status:** ✅ Merged **Merged:** 1/7/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `translation-consistency` --- ### 📝 Commits (10+) - [`dc3ca9f`](https://github.com/actualbudget/actual/commit/dc3ca9fa11d97e441b90353a6bb3a5a6c41538b2) fix setup vs set up - [`5e1fd08`](https://github.com/actualbudget/actual/commit/5e1fd080f2f6fbd69d44fedcb65621b01a0088fb) template help modal - [`eedbac7`](https://github.com/actualbudget/actual/commit/eedbac72b8b4a5fa80963a3f6d50e588de97c138) improve translation strings - [`628c123`](https://github.com/actualbudget/actual/commit/628c1233bcf034340f01f20a6866bb3029e3e413) note - [`29279ca`](https://github.com/actualbudget/actual/commit/29279ca349297ba4d20a8aac4f765d3b60c4a979) fix test - [`6b3c240`](https://github.com/actualbudget/actual/commit/6b3c240e7eb606ae3a3ae95dd1740e7c8abe2252) Update VRT - [`1314710`](https://github.com/actualbudget/actual/commit/1314710a3a410fa1fe31d9f465c10e1d866b12ae) Update packages/desktop-client/src/components/reports/DateRange.tsx - [`80fea54`](https://github.com/actualbudget/actual/commit/80fea54cc28e1d42669f5559319e0d1e4b07a6d5) feedback - [`1404994`](https://github.com/actualbudget/actual/commit/140499443113e746757864106d38bfe8c6ebb6d5) budget toggle - [`05bb2ed`](https://github.com/actualbudget/actual/commit/05bb2ed4e0536932f36bbe8e6e334ed30432045b) lint ### 📊 Changes **59 files changed** (+644 additions, -446 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/page-models/navigation.js` (+1 -1) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/reports.test.js-snapshots/Reports-loads-net-worth-graph-and-checks-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.mobile.test.js-snapshots/Mobile-Settings-checks-that-settings-page-can-be-opened-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.mobile.test.js-snapshots/Mobile-Settings-checks-that-settings-page-can-be-opened-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.mobile.test.js-snapshots/Mobile-Settings-checks-that-settings-page-can-be-opened-6-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/App.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/LoggedInUser.tsx` (+13 -4) 📝 `packages/desktop-client/src/components/Modals.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/admin/UserAccess/UserAccess.tsx` (+9 -9) 📝 `packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx` (+11 -11) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx` (+2 -2) _...and 39 more files_ </details> ### 📄 Description This is the first of a series of changes to improve the translatable strings generated with `react-i18n`. At the moment, some sentences are broken up and lose context once exported. This PR is already quite big, and I'm barely past B in the locale file so there might be quite a few parts to this to make the reviews more manageable. I've also fixed any typos I've seen and migrated every file I've been in so far to use `<Trans>` inside React components where possible for consistency. There are also some places where the text used for the same action is inconsistent across the app - I've changed these where possible too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:07:05 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5161
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?