github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 20:40:08 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3874] [CLOSED] ♻️ (typescript) convert Balance.jsx to .tsx #5103

New Issue
Closed
opened 2026-02-28 21:06:01 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:06:01 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3874
Author: @cindywu
Created: 11/22/2024
Status: ❌ Closed

Base: master ← Head: cindywu/refactor-balance-tsx

📝 Commits (10+)

  • 92ff91d refactor: convert Balance.jsx to .tsx
  • 2675e91 add release notes
  • 48d632c updates DetailedBalanceProps type
  • ebeb5da make prettier happy
  • 8229290 WIP set types to any
  • b26d36c explicitly type anys
  • 5d13180 make DetailedBalanceProps balance prop non-nullable
  • a6938e6 declare types outside of component
  • 73316b4 extract out props type
  • 13700ea extract out SelectedBalanceProps

📊 Changes

3 files changed (+82 additions, -26 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Balance.tsx (+74 -25)
📝 packages/desktop-client/src/components/spreadsheet/index.ts (+2 -1)
➕ upcoming-release-notes/3874.md (+6 -0)

📄 Description

#1483

  • converts Balance.jsx to .tsx

This is my first PR, so feel free to give any and all feedback! Figured it is best to just "do something" than to talk about doing stuff.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3874 **Author:** [@cindywu](https://github.com/cindywu) **Created:** 11/22/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cindywu/refactor-balance-tsx` --- ### 📝 Commits (10+) - [`92ff91d`](https://github.com/actualbudget/actual/commit/92ff91d7e41e27288893b326d69c77b75ab99b85) refactor: convert Balance.jsx to .tsx - [`2675e91`](https://github.com/actualbudget/actual/commit/2675e91ce75ac3ff45fa0c28ee988be483dfd3a0) add release notes - [`48d632c`](https://github.com/actualbudget/actual/commit/48d632cd056eca3730aa9b5e9374e31616cab183) updates DetailedBalanceProps type - [`ebeb5da`](https://github.com/actualbudget/actual/commit/ebeb5da720b095edc173b9b9ccda3e152055f301) make prettier happy - [`8229290`](https://github.com/actualbudget/actual/commit/822929085a0bce71e832d93fbb6c4796fbac4178) WIP set types to any - [`b26d36c`](https://github.com/actualbudget/actual/commit/b26d36cc6a051c5b8fc74c4c67954a73485020b2) explicitly type anys - [`5d13180`](https://github.com/actualbudget/actual/commit/5d13180d39c92fb244facfbdd9c3c6ac0ab8b19a) make DetailedBalanceProps balance prop non-nullable - [`a6938e6`](https://github.com/actualbudget/actual/commit/a6938e676cadacd05651b3db67181cf31d85eae5) declare types outside of component - [`73316b4`](https://github.com/actualbudget/actual/commit/73316b40dcb668672efe7033076d9443ae7d09f9) extract out props type - [`13700ea`](https://github.com/actualbudget/actual/commit/13700ea7b5eb20e7a10bd133d02189b84ae3a5f0) extract out SelectedBalanceProps ### 📊 Changes **3 files changed** (+82 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Balance.tsx` (+74 -25) 📝 `packages/desktop-client/src/components/spreadsheet/index.ts` (+2 -1) ➕ `upcoming-release-notes/3874.md` (+6 -0) </details> ### 📄 Description #1483 - [x] converts Balance.jsx to .tsx This is my first PR, so feel free to give any and all feedback! Figured it is best to just "do something" than to talk about doing stuff. <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:06:01 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5103
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?