github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[GH-ISSUE #4008] [Bug]: Simplefin sync causes incorrect new transaction highlighting on some accounts #50816

New Issue
Closed
opened 2026-04-30 16:25:23 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-30 16:25:23 -05:00
Owner
Copy Link

Originally created by @youngcw on GitHub (Dec 18, 2024).
Original GitHub issue: https://github.com/actualbudget/actual/issues/4008

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

I think this started with the simplefin batch sync update but Im not 100% sure.

When syncing accounts if there are new transactions the account name gets bolded on the sidebar. Whats happening is that Im getting all accounts bolded that had synced transactions. The only accounts not getting bolded from the sync are accounts with all transactions reconciled, and no transactions that had not previously been synced.

Example A: This account has all reconciled transactions. The sync happens, there is nothing in the sync that is not already in the account. The account is not bolded. (Expected)

Example B: This account has some unreconciled transactions. The sync happens, new transactions are received and individually bolded because they are new. The account is bolded. (Expected)

Example C: This account has some unreconciled transactions. The sync happens, there is nothing in the sync that is not in the account. This account is bolded. (Not Expected)

How can we reproduce the issue?

I believe you could use the test credentials to do this.

  1. Setup simplefin
  2. Sync the test accounts. The accounts and lots of transactions should get bolded because of all the new stuff.
  3. Clear out all the bolded things by refreshing or something
  4. Sync again and the accounts should get bolded even though no transactions are new.

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

Originally created by @youngcw on GitHub (Dec 18, 2024). Original GitHub issue: https://github.com/actualbudget/actual/issues/4008 ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? I think this started with the simplefin batch sync update but Im not 100% sure. When syncing accounts if there are new transactions the account name gets bolded on the sidebar. Whats happening is that Im getting all accounts bolded that had synced transactions. The only accounts not getting bolded from the sync are accounts with all transactions reconciled, and no transactions that had not previously been synced. Example A: This account has all reconciled transactions. The sync happens, there is nothing in the sync that is not already in the account. The account is not bolded. (Expected) Example B: This account has some unreconciled transactions. The sync happens, new transactions are received and individually bolded because they are new. The account is bolded. (Expected) Example C: This account has some unreconciled transactions. The sync happens, there is nothing in the sync that is not in the account. This account is bolded. (Not Expected) ### How can we reproduce the issue? I believe you could use the test credentials to do this. 1. Setup simplefin 2. Sync the test accounts. The accounts and lots of transactions should get bolded because of all the new stuff. 3. Clear out all the bolded things by refreshing or something 4. Sync again and the accounts should get bolded even though no transactions are new. ### Where are you hosting Actual? None ### What browsers are you seeing the problem on? _No response_ ### Operating System None
GiteaMirror added the bank syncbug labels 2026-04-30 16:25:23 -05:00
GiteaMirror commented 2026-04-30 16:25:25 -05:00
Author
Owner
Copy Link

@matt-fidd commented on GitHub (Dec 18, 2024):

It seems likely it's related to the batch change, I did alter the logic for the transaction bolding slightly.
I can't reproduce it with the test credentials though.

https://github.com/user-attachments/assets/73646785-b563-4cec-a949-9ff62d9910d5

<!-- gh-comment-id:2552293982 --> @matt-fidd commented on GitHub (Dec 18, 2024): It seems likely it's related to the batch change, I did alter the logic for the transaction bolding slightly. I can't reproduce it with the test credentials though. https://github.com/user-attachments/assets/73646785-b563-4cec-a949-9ff62d9910d5
GiteaMirror commented 2026-04-30 16:25:26 -05:00
Author
Owner
Copy Link

@matt-fidd commented on GitHub (Dec 18, 2024):

Ah, I can reproduce on my GoCardless accounts though, it looks like the presence of matchedTransactions triggers the boldening, not just newTransactions.

11bde73fa5/packages/loot-core/src/client/actions/account.ts (L226-L231)

<!-- gh-comment-id:2552296575 --> @matt-fidd commented on GitHub (Dec 18, 2024): Ah, I can reproduce on my GoCardless accounts though, it looks like the presence of `matchedTransactions` triggers the boldening, not just `newTransactions`. https://github.com/actualbudget/actual/blob/11bde73fa547151356b7abcb010ac72795b2889c/packages/loot-core/src/client/actions/account.ts#L226-L231
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bank sync bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#50816
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?