github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3744] [MERGED] ♻️ custom reports - moving to url identifiers #5033

New Issue
Closed
opened 2026-02-28 21:04:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:04:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3744
Author: @MatissJanis
Created: 10/27/2024
Status: ✅ Merged
Merged: 11/4/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/custom-reports-id

📝 Commits (5)

  • 6dce7ff ♻️ custom reports - moving to url identifiers
  • 1ec400d Feedback: revert sessionStorage
  • 23d7158 Update report url id
  • c782791 Bug patches for sessionStorage now that url is used
  • 65fec3e Feedback: patch reloading

📊 Changes

9 files changed (+108 additions, -59 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/ReportCard.tsx (+1 -7)
📝 packages/desktop-client/src/components/reports/ReportRouter.tsx (+1 -0)
📝 packages/desktop-client/src/components/reports/ReportSidebar.tsx (+1 -7)
📝 packages/desktop-client/src/components/reports/ReportTopbar.tsx (+2 -8)
📝 packages/desktop-client/src/components/reports/SaveReport.tsx (+24 -7)
📝 packages/desktop-client/src/components/reports/reports/CustomReport.tsx (+63 -28)
📝 packages/desktop-client/src/components/reports/reports/CustomReportListCards.tsx (+1 -2)
📝 packages/loot-core/src/client/data-hooks/reports.ts (+9 -0)
➕ upcoming-release-notes/3744.md (+6 -0)

📄 Description

Moving custom report "inner" pages from using session storage + local state to using unique URL identifiers. This allows us to significantly simplify the logic as well as allows users to bookmark direct links to specific reports.

From a users perspective - this should have basically no change (apart from the URLs slightly changing for each custom report).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3744 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 10/27/2024 **Status:** ✅ Merged **Merged:** 11/4/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/custom-reports-id` --- ### 📝 Commits (5) - [`6dce7ff`](https://github.com/actualbudget/actual/commit/6dce7ff63683fb233f992bd78aee8fe39edc6086) :recycle: custom reports - moving to url identifiers - [`1ec400d`](https://github.com/actualbudget/actual/commit/1ec400d2b74451f5982fa4bd322ccb7b4132604f) Feedback: revert sessionStorage - [`23d7158`](https://github.com/actualbudget/actual/commit/23d7158f1bd3d98cbddf9cb4b5885ffceae1ae84) Update report url id - [`c782791`](https://github.com/actualbudget/actual/commit/c782791aef1e8b248e7f55cb899d9a02e90abbd4) Bug patches for sessionStorage now that url is used - [`65fec3e`](https://github.com/actualbudget/actual/commit/65fec3e2c85c3d3805b51bb639cb1c66ababf58d) Feedback: patch reloading ### 📊 Changes **9 files changed** (+108 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/ReportCard.tsx` (+1 -7) 📝 `packages/desktop-client/src/components/reports/ReportRouter.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/reports/ReportSidebar.tsx` (+1 -7) 📝 `packages/desktop-client/src/components/reports/ReportTopbar.tsx` (+2 -8) 📝 `packages/desktop-client/src/components/reports/SaveReport.tsx` (+24 -7) 📝 `packages/desktop-client/src/components/reports/reports/CustomReport.tsx` (+63 -28) 📝 `packages/desktop-client/src/components/reports/reports/CustomReportListCards.tsx` (+1 -2) 📝 `packages/loot-core/src/client/data-hooks/reports.ts` (+9 -0) ➕ `upcoming-release-notes/3744.md` (+6 -0) </details> ### 📄 Description Moving custom report "inner" pages from using session storage + local state to using unique URL identifiers. This allows us to significantly simplify the logic as well as allows users to bookmark direct links to specific reports. From a users perspective - this should have basically no change (apart from the URLs slightly changing for each custom report). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:04:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#5033
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?