github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #1653] [Bug]: fallbackMissingPayeeToMemo is NULL when importing QFX #49741

New Issue
Closed
opened 2026-04-30 11:26:17 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-30 11:26:17 -05:00
Owner
Copy Link

Originally created by @doggan on GitHub (Sep 4, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/1653

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

Hello. I am a new user to Actual and I'm trying to set up my first budget locally.

I created a new account, and then attempted to import a local QFX file (originally exported from Chase bank).

The import hangs and shows the error below:
image

Briefly looking at the code, it seems the fallbackMissingPayeeToMemo handler is only provided for ofx files (ref):

    parse(
      options.filename,
      fileType === 'csv'
        ? { delimiter: csvDelimiter, hasHeaderRow }
        : fileType === 'ofx'
        ? { fallbackMissingPayeeToMemo }
        : null,
    );

... but the parseOFX method where the error is happening is used for both OFX and QFX files (ref):

      case '.ofx':
      case '.qfx':
        return parseOFX(filepath, options);

...

  // Banks don't always implement the OFX standard properly
  // If no payee is available try and fallback to memo
  let useMemoFallback = options.fallbackMissingPayeeToMemo;

I don't have a local dev environment set up right now to test, but should the fallbackMissingPayeeToMemo handler also be supplied to options for qfx file types in addition to ofx?

Thanks.

What error did you receive?

[Exception] TypeError: Cannot read properties of null (reading 'fallbackMissingPayeeToMemo')
    at parse-file.ts:135:33
parse-file.ts:135 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'fallbackMissingPayeeToMemo')
    at parse-file.ts:135:33

Where are you hosting Actual?

Locally via Yarn

What browsers are you seeing the problem on?

Chrome

Operating System

Mac OSX

Originally created by @doggan on GitHub (Sep 4, 2023). Original GitHub issue: https://github.com/actualbudget/actual/issues/1653 ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? Hello. I am a new user to Actual and I'm trying to set up my first budget locally. I created a new account, and then attempted to import a local QFX file (originally exported from Chase bank). The import hangs and shows the error below: <img width="616" alt="image" src="https://github.com/actualbudget/actual/assets/517857/b7015fcc-befc-4848-b993-3380a744db17"> Briefly looking at the code, it seems the `fallbackMissingPayeeToMemo` handler is only provided for ofx files ([ref](https://github.com/actualbudget/actual/blob/3e32db74cc9c114284929eae2fb22257ef3e3245/packages/desktop-client/src/components/modals/ImportTransactions.js#L659-L665)): ``` parse( options.filename, fileType === 'csv' ? { delimiter: csvDelimiter, hasHeaderRow } : fileType === 'ofx' ? { fallbackMissingPayeeToMemo } : null, ); ``` ... but the parseOFX method where the error is happening is used for both OFX and QFX files ([ref](https://github.com/actualbudget/actual/blob/3e32db74cc9c114284929eae2fb22257ef3e3245/packages/loot-core/src/server/accounts/parse-file.ts#L132-L134)): ``` case '.ofx': case '.qfx': return parseOFX(filepath, options); ... // Banks don't always implement the OFX standard properly // If no payee is available try and fallback to memo let useMemoFallback = options.fallbackMissingPayeeToMemo; ``` I don't have a local dev environment set up right now to test, but should the `fallbackMissingPayeeToMemo` handler also be supplied to options for qfx file types in addition to ofx? Thanks. ### What error did you receive? ``` [Exception] TypeError: Cannot read properties of null (reading 'fallbackMissingPayeeToMemo') at parse-file.ts:135:33 parse-file.ts:135 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'fallbackMissingPayeeToMemo') at parse-file.ts:135:33 ``` ### Where are you hosting Actual? Locally via Yarn ### What browsers are you seeing the problem on? Chrome ### Operating System Mac OSX
GiteaMirror added the transaction importbug labels 2026-04-30 11:26:17 -05:00
GiteaMirror commented 2026-04-30 11:26:22 -05:00
Author
Owner
Copy Link

@joel-jeremy commented on GitHub (Sep 5, 2023):

I have created a PR for this: https://github.com/actualbudget/actual/pull/1649

@MatissJanis Do you think we should do a v23.9.1 release?

<!-- gh-comment-id:1705836087 --> @joel-jeremy commented on GitHub (Sep 5, 2023): I have created a PR for this: https://github.com/actualbudget/actual/pull/1649 @MatissJanis Do you think we should do a v23.9.1 release?
GiteaMirror commented 2026-04-30 11:26:22 -05:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Sep 5, 2023):

I have created a PR for this: #1649

@MatissJanis Do you think we should do a v23.9.1 release?

IMO think that's too risky. We've merged a lot of things since releasing v23.9.0.

Folks experiencing this issue can move to edge tag (which contains the fix). And once we push out v23.10.0 next month - they can switch over to the versioned release.

<!-- gh-comment-id:1706097931 --> @MatissJanis commented on GitHub (Sep 5, 2023): > I have created a PR for this: #1649 > > @MatissJanis Do you think we should do a v23.9.1 release? IMO think that's too risky. We've merged a lot of things since releasing v23.9.0. Folks experiencing this issue can move to `edge` tag (which contains the fix). And once we push out v23.10.0 next month - they can switch over to the versioned release.
GiteaMirror commented 2026-04-30 11:26:22 -05:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Sep 7, 2023):

This has been fixed in #1649

<!-- gh-comment-id:1710664740 --> @MatissJanis commented on GitHub (Sep 7, 2023): This has been fixed in #1649
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug transaction import
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#49741
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?