github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #226] [Bug]: Pressing return/enter when the checkbox is focused does nothing #49250

New Issue
Closed
opened 2026-04-30 10:28:19 -05:00 by GiteaMirror · 7 comments
GiteaMirror commented 2026-04-30 10:28:19 -05:00
Owner
Copy Link

Originally created by @j-f1 on GitHub (Aug 31, 2022).
Original GitHub issue: https://github.com/actualbudget/actual/issues/226

Verified issue does not already exist?

I have searched and found no existing issue

What happened?

Pressing return/enter when focused on the payment/deposit columns of a new transaction will cause the transaction to be added/saved. However, this will not happen for the “cleared” checkbox.

What error did you receive?

No response

Where are you hosting Actual?

Locally via Yarn

What browsers are you seeing the problem on?

Chrome, Safari

Operating System

Other

Originally created by @j-f1 on GitHub (Aug 31, 2022). Original GitHub issue: https://github.com/actualbudget/actual/issues/226 ### Verified issue does not already exist? I have searched and found no existing issue ### What happened? Pressing return/enter when focused on the payment/deposit columns of a new transaction will cause the transaction to be added/saved. However, this will not happen for the “cleared” checkbox. ### What error did you receive? _No response_ ### Where are you hosting Actual? Locally via Yarn ### What browsers are you seeing the problem on? Chrome, Safari ### Operating System Other
GiteaMirror added the good first issuebug labels 2026-04-30 10:28:21 -05:00
GiteaMirror commented 2026-04-30 10:28:25 -05:00
Author
Owner
Copy Link

@rich-howell commented on GitHub (Aug 31, 2022):

This has already been resolved and merged as part of https://github.com/actualbudget/actual/issues/29 so I will go ahead and close this out.

<!-- gh-comment-id:1233230713 --> @rich-howell commented on GitHub (Aug 31, 2022): This has already been resolved and merged as part of https://github.com/actualbudget/actual/issues/29 so I will go ahead and close this out.
GiteaMirror commented 2026-04-30 10:28:26 -05:00
Author
Owner
Copy Link

@TomAFrench commented on GitHub (Aug 31, 2022):

This is different from #29 as it's referring to entering transactions in the transaction table rather than performing the bootstrap step.

<!-- gh-comment-id:1233256551 --> @TomAFrench commented on GitHub (Aug 31, 2022): This is different from #29 as it's referring to entering transactions in the transaction table rather than performing the bootstrap step.
GiteaMirror commented 2026-04-30 10:28:27 -05:00
Author
Owner
Copy Link

@rich-howell commented on GitHub (Aug 31, 2022):

Apologies.

<!-- gh-comment-id:1233257266 --> @rich-howell commented on GitHub (Aug 31, 2022): Apologies.
GiteaMirror commented 2026-04-30 10:28:28 -05:00
Author
Owner
Copy Link

@ezfe commented on GitHub (Sep 1, 2022):

I've just taken a look at this myself and it's coded to only allow pressing enter on the Credit/Debit fields:

https://github.com/actualbudget/actual/blob/master/packages/desktop-client/src/components/accounts/TransactionsTable.js#L1635-L1642

That being said, adding cleared is easy and makes sense. I can open a PR with a patch if that sounds good...

<!-- gh-comment-id:1233630378 --> @ezfe commented on GitHub (Sep 1, 2022): I've just taken a look at this myself and it's coded to only allow pressing enter on the Credit/Debit fields: https://github.com/actualbudget/actual/blob/master/packages/desktop-client/src/components/accounts/TransactionsTable.js#L1635-L1642 That being said, adding `cleared` is easy and makes sense. I can open a PR with a patch if that sounds good...
GiteaMirror commented 2026-04-30 10:28:29 -05:00
Author
Owner
Copy Link

@jlongster commented on GitHub (Sep 1, 2022):

Good find @ezfe! Yes that makes sense to me!

<!-- gh-comment-id:1233700491 --> @jlongster commented on GitHub (Sep 1, 2022): Good find @ezfe! Yes that makes sense to me!
GiteaMirror commented 2026-04-30 10:28:29 -05:00
Author
Owner
Copy Link

@ezfe commented on GitHub (Sep 1, 2022):

Alright I'll push up the code change and make a PR momentarily

<!-- gh-comment-id:1233701007 --> @ezfe commented on GitHub (Sep 1, 2022): Alright I'll push up the code change and make a PR momentarily
GiteaMirror commented 2026-04-30 10:28:31 -05:00
Author
Owner
Copy Link

@TomAFrench commented on GitHub (Sep 1, 2022):

Closed as this is fixed by #234

<!-- gh-comment-id:1234262173 --> @TomAFrench commented on GitHub (Sep 1, 2022): Closed as this is fixed by #234
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug good first issue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#49250
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?