github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3554] [MERGED] Update sidebar scrolling #4924

New Issue
Closed
opened 2026-02-28 21:03:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:03:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3554
Author: @tlesicka
Created: 10/4/2024
Status: ✅ Merged
Merged: 10/9/2024
Merged by: @MatissJanis

Base: master ← Head: update-sidebar-scrolling

📝 Commits (10+)

  • 87da867 Updated Sidebar
  • 2480331 Update VRT snapshots
  • 9cde369 Create 3554.md
  • 62f0908 Change recommended by coderabbitai
  • 87aee2c Update VRT snapshots
  • 083b8fa Merge remote-tracking branch 'upstream/master' into update-sidebar-scrolling
  • 17e741b Merge branch 'actualbudget:master' into update-sidebar-scrolling
  • 1a0f31c Fixed issue sidenav icon is no longer in the correct location
  • 1f03866 removed @ts-strict-ignore from 3 files
  • 59f57fe Fixed small window scrolling issue

📊 Changes

110 files changed (+194 additions, -155 deletions)

View changed files

📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-6-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-creates-a-new-account-and-views-the-initial-balance-transaction-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-creates-a-new-account-and-views-the-initial-balance-transaction-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-creates-a-new-account-and-views-the-initial-balance-transaction-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.test.js-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.test.js-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.test.js-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.test.js-snapshots/Budget-transfer-funds-to-another-category-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.test.js-snapshots/Budget-transfer-funds-to-another-category-2-chromium-linux.png (+0 -0)

...and 80 more files

📄 Description

Splitting #3457 into several PR's as requested by @MatissJanis.
Refactored sidebar to allow scrolling in only the accounts section.
Moved Item buttons to PrimaryButtons.
Put Tools inside PrimaryButtons and removed Tools.
Moved Add Account button to SecondaryButtons. Moved account sorting from sidebar to Accounts.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3554 **Author:** [@tlesicka](https://github.com/tlesicka) **Created:** 10/4/2024 **Status:** ✅ Merged **Merged:** 10/9/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `update-sidebar-scrolling` --- ### 📝 Commits (10+) - [`87da867`](https://github.com/actualbudget/actual/commit/87da867fb31eb822fe2c1c8d2b669f534d0fd38d) Updated Sidebar - [`2480331`](https://github.com/actualbudget/actual/commit/24803317ee78322c1a0ea7f24d6e6391d2314932) Update VRT snapshots - [`9cde369`](https://github.com/actualbudget/actual/commit/9cde3690a9d75bbe12b3691be90e15ad751e0e68) Create 3554.md - [`62f0908`](https://github.com/actualbudget/actual/commit/62f09089c775ceba8de05c8cd79517a9b45aa5e5) Change recommended by coderabbitai - [`87aee2c`](https://github.com/actualbudget/actual/commit/87aee2c55d8c496afef08d2c6a60486d9ba3477a) Update VRT snapshots - [`083b8fa`](https://github.com/actualbudget/actual/commit/083b8fa9e50d4d4ce9fa4793a1b43d945c956776) Merge remote-tracking branch 'upstream/master' into update-sidebar-scrolling - [`17e741b`](https://github.com/actualbudget/actual/commit/17e741b0c1da8eabb577fd131f037fa9b21d9f41) Merge branch 'actualbudget:master' into update-sidebar-scrolling - [`1a0f31c`](https://github.com/actualbudget/actual/commit/1a0f31c8b6fdecd0e15b5aa98c6a9ecf23b39f67) Fixed issue sidenav icon is no longer in the correct location - [`1f03866`](https://github.com/actualbudget/actual/commit/1f038666e0f91a85d2fcbf9bf1e288d247ae45f0) removed @ts-strict-ignore from 3 files - [`59f57fe`](https://github.com/actualbudget/actual/commit/59f57fedc979dfc6b9b45b814cc8b645ee7299d3) Fixed small window scrolling issue ### 📊 Changes **110 files changed** (+194 additions, -155 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-import-csv-file-twice-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-Import-Transactions-imports-transactions-from-a-CSV-file-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-closes-an-account-6-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-creates-a-new-account-and-views-the-initial-balance-transaction-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-creates-a-new-account-and-views-the-initial-balance-transaction-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/accounts.test.js-snapshots/Accounts-creates-a-new-account-and-views-the-initial-balance-transaction-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.test.js-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.test.js-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.test.js-snapshots/Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.test.js-snapshots/Budget-transfer-funds-to-another-category-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.test.js-snapshots/Budget-transfer-funds-to-another-category-2-chromium-linux.png` (+0 -0) _...and 80 more files_ </details> ### 📄 Description Splitting #3457 into several PR's as requested by @MatissJanis. Refactored sidebar to allow scrolling in only the accounts section. Moved Item buttons to PrimaryButtons. Put Tools inside PrimaryButtons and removed Tools. Moved Add Account button to SecondaryButtons. Moved account sorting from sidebar to Accounts. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:03:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4924
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?