github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7566] [MERGED] [AI] Add nightly CI scan for custom theme catalog #49077

New Issue
Closed
opened 2026-04-26 10:55:44 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 10:55:44 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7566
Author: @MatissJanis
Created: 4/20/2026
Status: ✅ Merged
Merged: 4/21/2026
Merged by: @MatissJanis

Base: master ← Head: claude/nightly-themes-ci-scan-vnes1

📝 Commits (3)

  • ec4caca [AI] Add nightly CI scan for custom theme catalog
  • 2a8a9cd [AI] Simplify theme catalog scan
  • 6186423 [AI] Fix lint on theme catalog scan imports

📊 Changes

5 files changed (+255 additions, -1 deletions)

View changed files

➕ .github/workflows/nightly-theme-catalog-scan.yml (+29 -0)
➕ packages/desktop-client/bin/validate-theme-catalog.mts (+210 -0)
📝 packages/desktop-client/package.json (+1 -0)
📝 packages/desktop-client/src/style/customThemes.ts (+9 -1)
➕ upcoming-release-notes/7566.md (+6 -0)

📄 Description

Description

Added nightly scan to detect broken custom themes. So we can remove them from the catalog if-need-be.

Related issue(s)

https://github.com/actualbudget/actual/issues/6607

Testing

Run the new cli locally

Validating 21 theme(s) from the catalog…
(node:57833) [MODULE_TYPELESS_PACKAGE_JSON] Warning: Module type of file:///Users/matiss/actual/actual/.claude/worktrees/resilient-beaming-globe/packages/desktop-client/src/style/customThemes.ts is not specified and it doesn't parse as CommonJS.
Reparsing as ES module because module syntax was detected. This incurs a performance overhead.
To eliminate this warning, add "type": "module" to /Users/matiss/actual/actual/.claude/worktrees/resilient-beaming-globe/packages/desktop-client/package.json.
(Use `node --trace-warnings ...` to show where the warning was created)
  ok    actualbudget/demo-theme                                 Demo Theme
  ok    Juulz/shades-of-coffee                                  Shades of Coffee
  ok    Juulz/miami-beach                                       Miami Beach
  ok    Juulz/simple-dark                                       Simple Dark
  ok    MatissJanis/actualbudget-matrix-theme                   Matrix
  ok    MikesGlitch/actual-black-gold-theme                     Black Gold
  ok    Juulz/okabe-ito                                         Color-blind (Dark)
  ok    Juulz/1970-theme                                        Theme from 1970
  ok    Juulz/shades-of-gray                                    Shades of Gray (light)
  ok    noahjalex/catppuccin-latte-actual                       Catppuccin Latte
  ok    noahjalex/catppuccin-frappe-actual                      Catppuccin Frappé
  ok    noahjalex/catppuccin-macchiato-actual                   Catppuccin Macchiato
  ok    noahjalex/catppuccin-mocha-actual                       Catppuccin Mocha
  ok    distantvapor/you-need-a-dark-mode                       You Need A Dark Mode
  ok    samekh248/actual-butterfly-theme                        Butterfly
  ok    Juulz/high-contrast-light                               High-contrast (Light)
  ok    vcruzdesigns/Notion-Dark-Mode                           Notion Dark Mode
  ok    Juulz/YNA-Theme-Light                                   YNA Theme Light
  ok    Juulz/YNA-Theme-Dark                                    YNA Theme Dark
  ok    aadhithbala/actual-nord-theme                           Nord
  ok    aadhithbala/Ilavenil                                    Ilavenil

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 34 13.86 MB → 13.86 MB (+402 B) +0.00%
loot-core 1 5.26 MB 0%
api 1 3.89 MB 0%
cli 1 7.91 MB 0%
crdt 1 41.83 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
34 13.86 MB → 13.86 MB (+402 B) +0.00%
Changeset
File Δ Size
src/style/customThemes.ts 📈 +309 B (+1.72%) 17.55 kB → 17.85 kB
package.json 📈 +93 B (+1.14%) 7.99 kB → 8.08 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/extends.js 518.36 kB → 518.66 kB (+309 B) +0.06%
static/js/index.js 1.87 MB → 1.87 MB (+93 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/PayeeRuleCountLabel.js 52.52 kB 0%
static/js/ReportRouter.js 1.2 MB 0%
static/js/ScheduleEditForm.js 136.13 kB 0%
static/js/TransactionEdit.js 186.46 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 4.94 MB 0%
static/js/ca.js 191.68 kB 0%
static/js/chart-theme.js 796.5 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 104.4 kB 0%
static/js/de.js 174.08 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 176.64 kB 0%
static/js/es.js 181.5 kB 0%
static/js/fr.js 182.7 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 168.53 kB 0%
static/js/narrow.js 364.25 kB 0%
static/js/nb-NO.js 151.58 kB 0%
static/js/nl.js 108.66 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 193.45 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 178.91 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/uk.js 212.28 kB 0%
static/js/useFormatList.js 8.63 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 119.52 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.26 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.wT3tRINf.js 5.26 MB 0%

api

Total

Files count Total bundle size % Changed
1 3.89 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.89 MB 0%

cli

Total

Files count Total bundle size % Changed
1 7.91 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.91 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 41.83 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 41.83 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7566 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 4/20/2026 **Status:** ✅ Merged **Merged:** 4/21/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `claude/nightly-themes-ci-scan-vnes1` --- ### 📝 Commits (3) - [`ec4caca`](https://github.com/actualbudget/actual/commit/ec4caca18a83085deb92df8448cb383010aa0ebf) [AI] Add nightly CI scan for custom theme catalog - [`2a8a9cd`](https://github.com/actualbudget/actual/commit/2a8a9cda5ee16728ca2c1b26215700c8729af16d) [AI] Simplify theme catalog scan - [`6186423`](https://github.com/actualbudget/actual/commit/61864232d381f9e0f5a4c3ba691c100e37b563b7) [AI] Fix lint on theme catalog scan imports ### 📊 Changes **5 files changed** (+255 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/nightly-theme-catalog-scan.yml` (+29 -0) ➕ `packages/desktop-client/bin/validate-theme-catalog.mts` (+210 -0) 📝 `packages/desktop-client/package.json` (+1 -0) 📝 `packages/desktop-client/src/style/customThemes.ts` (+9 -1) ➕ `upcoming-release-notes/7566.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description <!-- What does this PR do? Why is it needed? Please give context on the "why?": why do we need this change? What problem is it solving for you?--> Added nightly scan to detect broken custom themes. So we can remove them from the catalog if-need-be. ## Related issue(s) <!-- e.g. Fixes #123, Relates to #456 --> https://github.com/actualbudget/actual/issues/6607 ## Testing <!-- What did you test? How can we reproduce the issue you are fixing or how can we test the feature you built? --> Run the new cli locally ``` Validating 21 theme(s) from the catalog… (node:57833) [MODULE_TYPELESS_PACKAGE_JSON] Warning: Module type of file:///Users/matiss/actual/actual/.claude/worktrees/resilient-beaming-globe/packages/desktop-client/src/style/customThemes.ts is not specified and it doesn't parse as CommonJS. Reparsing as ES module because module syntax was detected. This incurs a performance overhead. To eliminate this warning, add "type": "module" to /Users/matiss/actual/actual/.claude/worktrees/resilient-beaming-globe/packages/desktop-client/package.json. (Use `node --trace-warnings ...` to show where the warning was created) ok actualbudget/demo-theme Demo Theme ok Juulz/shades-of-coffee Shades of Coffee ok Juulz/miami-beach Miami Beach ok Juulz/simple-dark Simple Dark ok MatissJanis/actualbudget-matrix-theme Matrix ok MikesGlitch/actual-black-gold-theme Black Gold ok Juulz/okabe-ito Color-blind (Dark) ok Juulz/1970-theme Theme from 1970 ok Juulz/shades-of-gray Shades of Gray (light) ok noahjalex/catppuccin-latte-actual Catppuccin Latte ok noahjalex/catppuccin-frappe-actual Catppuccin Frappé ok noahjalex/catppuccin-macchiato-actual Catppuccin Macchiato ok noahjalex/catppuccin-mocha-actual Catppuccin Mocha ok distantvapor/you-need-a-dark-mode You Need A Dark Mode ok samekh248/actual-butterfly-theme Butterfly ok Juulz/high-contrast-light High-contrast (Light) ok vcruzdesigns/Notion-Dark-Mode Notion Dark Mode ok Juulz/YNA-Theme-Light YNA Theme Light ok Juulz/YNA-Theme-Dark YNA Theme Dark ok aadhithbala/actual-nord-theme Nord ok aadhithbala/Ilavenil Ilavenil ``` ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [ ] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 34 | 13.86 MB → 13.86 MB (+402 B) | +0.00% loot-core | 1 | 5.26 MB | 0% api | 1 | 3.89 MB | 0% cli | 1 | 7.91 MB | 0% crdt | 1 | 41.83 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 34 | 13.86 MB → 13.86 MB (+402 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/style/customThemes.ts` | 📈 +309 B (+1.72%) | 17.55 kB → 17.85 kB `package.json` | 📈 +93 B (+1.14%) | 7.99 kB → 8.08 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/extends.js | 518.36 kB → 518.66 kB (+309 B) | +0.06% static/js/index.js | 1.87 MB → 1.87 MB (+93 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/PayeeRuleCountLabel.js | 52.52 kB | 0% static/js/ReportRouter.js | 1.2 MB | 0% static/js/ScheduleEditForm.js | 136.13 kB | 0% static/js/TransactionEdit.js | 186.46 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 4.94 MB | 0% static/js/ca.js | 191.68 kB | 0% static/js/chart-theme.js | 796.5 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 104.4 kB | 0% static/js/de.js | 174.08 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 176.64 kB | 0% static/js/es.js | 181.5 kB | 0% static/js/fr.js | 182.7 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 168.53 kB | 0% static/js/narrow.js | 364.25 kB | 0% static/js/nb-NO.js | 151.58 kB | 0% static/js/nl.js | 108.66 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 193.45 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 178.91 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/uk.js | 212.28 kB | 0% static/js/useFormatList.js | 8.63 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 119.52 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.26 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.wT3tRINf.js | 5.26 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 3.89 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.89 MB | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.91 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.91 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 41.83 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 41.83 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 10:55:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#49077
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?