[PR #3525] [MERGED] pass causes along in failed-to-load exceptions #4907

Closed
opened 2026-02-28 21:03:03 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3525
Author: @qedi-r
Created: 9/28/2024
Status: Merged
Merged: 9/28/2024
Merged by: @MatissJanis

Base: masterHead: u/qedi-r/error-handling


📝 Commits (3)

  • e29b750 add failed to load exceptions
  • 87377ef add release notes
  • 31838f7 Merge branch 'master' into u/qedi-r/error-handling

📊 Changes

3 files changed (+12 additions, -3 deletions)

View changed files

📝 packages/desktop-client/src/components/util/LoadComponent.tsx (+4 -2)
📝 packages/loot-core/src/shared/errors.ts (+2 -1)
upcoming-release-notes/3525.md (+6 -0)

📄 Description

When developing, especially deep in a component, the original error will get swallowed on the error screen. You can often get a generic error like this:

image

the root cause though, doesn't get passed on the exception chain, so the console will just report the generic error:

image

this captures the original exception to show as the cause:

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3525 **Author:** [@qedi-r](https://github.com/qedi-r) **Created:** 9/28/2024 **Status:** ✅ Merged **Merged:** 9/28/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `u/qedi-r/error-handling` --- ### 📝 Commits (3) - [`e29b750`](https://github.com/actualbudget/actual/commit/e29b750c85a125a0832d431c34efed9b91813101) add failed to load exceptions - [`87377ef`](https://github.com/actualbudget/actual/commit/87377ef05e3cbbd5cf1b7392a5ab4761e4b342f6) add release notes - [`31838f7`](https://github.com/actualbudget/actual/commit/31838f766c640415934be390b0531a1997fca29f) Merge branch 'master' into u/qedi-r/error-handling ### 📊 Changes **3 files changed** (+12 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/util/LoadComponent.tsx` (+4 -2) 📝 `packages/loot-core/src/shared/errors.ts` (+2 -1) ➕ `upcoming-release-notes/3525.md` (+6 -0) </details> ### 📄 Description When developing, especially deep in a component, the original error will get swallowed on the error screen. You can often get a generic error like this: ![image](https://github.com/user-attachments/assets/7cf6f42c-df48-4823-91b8-dfd811b0eb4e) the root cause though, doesn't get passed on the exception chain, so the console will just report the generic error: ![image](https://github.com/user-attachments/assets/92ca071a-b801-438e-ba5d-c7116a14643d) this captures the original exception to show as the cause: ![image](https://github.com/user-attachments/assets/ebec8753-ac6f-4c5f-8ea5-14da838fc59b) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:03:03 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4907