github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7549] [codex] Exclude income categories from tracking spending budgets #49067

New Issue
Open
opened 2026-04-26 10:55:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 10:55:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7549
Author: @pranayseela
Created: 4/19/2026
Status: 🔄 Open

Base: master ← Head: codex/fix-7419-tracking-budget-spending

📝 Commits (2)

  • 454bf62 Exclude income from tracking spending budget totals
  • 62a783b Add release note for tracking spending fix

📊 Changes

3 files changed (+97 additions, -16 deletions)

View changed files

➕ packages/desktop-client/src/components/reports/spreadsheets/spending-spreadsheet.test.ts (+65 -0)
📝 packages/desktop-client/src/components/reports/spreadsheets/spending-spreadsheet.ts (+26 -16)
➕ upcoming-release-notes/7549.md (+6 -0)

📄 Description

Summary

  • exclude income categories when summing tracking-budget values for the Spending Analysis report in Budgeted mode
  • add a regression test covering mixed expense and income budgets
  • add upcoming-release-notes/7549.md

Description

Issue #7419 happens because the Budgeted line sums all reflected budget rows, including income categories, while the transaction side of the report already excludes income. This change fetches categories, filters the budget total down to non-income categories only, and adds a regression test so tracking budgets with income entries do not inflate the spending total.

Related issue(s)

Fixes #7419

Testing

  • /Users/pranaymbp/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin/node .yarn/releases/yarn-4.13.0.cjs workspace @actual-app/web vitest run src/components/reports/spreadsheets/spending-spreadsheet.test.ts

Checklist

  • Release notes added (see upcoming-release-notes/7549.md)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 34 12.94 MB → 12.94 MB (+246 B) +0.00%
loot-core 1 4.85 MB 0%
api 1 3.89 MB 0%
cli 1 7.91 MB 0%
crdt 1 41.83 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
34 12.94 MB → 12.94 MB (+246 B) +0.00%
Changeset
File Δ Size
src/components/reports/spreadsheets/spending-spreadsheet.ts 📈 +246 B (+4.32%) 5.56 kB → 5.8 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.18 MB → 1.18 MB (+246 B) +0.02%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.85 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 814.39 kB 0%
static/js/PayeeRuleCountLabel.js 52.13 kB 0%
static/js/ScheduleEditForm.js 136.13 kB 0%
static/js/TransactionEdit.js 185.13 kB 0%
static/js/TransactionList.js 82.8 kB 0%
static/js/Value.js 4.34 MB 0%
static/js/ca.js 191.72 kB 0%
static/js/chart-theme.js 709.55 kB 0%
static/js/client.js 450.92 kB 0%
static/js/da.js 104.4 kB 0%
static/js/de.js 174.12 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 176.5 kB 0%
static/js/es.js 181.54 kB 0%
static/js/extends.js 487.8 kB 0%
static/js/fr.js 176.79 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.68 kB 0%
static/js/narrow.js 363.68 kB 0%
static/js/nb-NO.js 151.58 kB 0%
static/js/nl.js 108.66 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 193.49 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 178.91 kB 0%
static/js/theme.js 30.79 kB 0%
static/js/uk.js 212.28 kB 0%
static/js/useFormatList.js 7.62 kB 0%
static/js/wide.js 292 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 110.19 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.85 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.DvDd_fWg.js 4.85 MB 0%

api

Total

Files count Total bundle size % Changed
1 3.89 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.89 MB 0%

cli

Total

Files count Total bundle size % Changed
1 7.91 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.91 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 41.83 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 41.83 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7549 **Author:** [@pranayseela](https://github.com/pranayseela) **Created:** 4/19/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `codex/fix-7419-tracking-budget-spending` --- ### 📝 Commits (2) - [`454bf62`](https://github.com/actualbudget/actual/commit/454bf624362b40f0ba68edda6322bb0708389a6a) Exclude income from tracking spending budget totals - [`62a783b`](https://github.com/actualbudget/actual/commit/62a783b11674948d64687556fdcabcf3046a652f) Add release note for tracking spending fix ### 📊 Changes **3 files changed** (+97 additions, -16 deletions) <details> <summary>View changed files</summary> ➕ `packages/desktop-client/src/components/reports/spreadsheets/spending-spreadsheet.test.ts` (+65 -0) 📝 `packages/desktop-client/src/components/reports/spreadsheets/spending-spreadsheet.ts` (+26 -16) ➕ `upcoming-release-notes/7549.md` (+6 -0) </details> ### 📄 Description ### Summary - exclude income categories when summing tracking-budget values for the Spending Analysis report in Budgeted mode - add a regression test covering mixed expense and income budgets - add `upcoming-release-notes/7549.md` ## Description Issue #7419 happens because the Budgeted line sums all reflected budget rows, including income categories, while the transaction side of the report already excludes income. This change fetches categories, filters the budget total down to non-income categories only, and adds a regression test so tracking budgets with income entries do not inflate the spending total. ## Related issue(s) Fixes #7419 ## Testing - `/Users/pranaymbp/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin/node .yarn/releases/yarn-4.13.0.cjs workspace @actual-app/web vitest run src/components/reports/spreadsheets/spending-spreadsheet.test.ts` ## Checklist - [x] Release notes added (see `upcoming-release-notes/7549.md`) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 34 | 12.94 MB → 12.94 MB (+246 B) | +0.00% loot-core | 1 | 4.85 MB | 0% api | 1 | 3.89 MB | 0% cli | 1 | 7.91 MB | 0% crdt | 1 | 41.83 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 34 | 12.94 MB → 12.94 MB (+246 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/reports/spreadsheets/spending-spreadsheet.ts` | 📈 +246 B (+4.32%) | 5.56 kB → 5.8 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/ReportRouter.js | 1.18 MB → 1.18 MB (+246 B) | +0.02% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.85 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 814.39 kB | 0% static/js/PayeeRuleCountLabel.js | 52.13 kB | 0% static/js/ScheduleEditForm.js | 136.13 kB | 0% static/js/TransactionEdit.js | 185.13 kB | 0% static/js/TransactionList.js | 82.8 kB | 0% static/js/Value.js | 4.34 MB | 0% static/js/ca.js | 191.72 kB | 0% static/js/chart-theme.js | 709.55 kB | 0% static/js/client.js | 450.92 kB | 0% static/js/da.js | 104.4 kB | 0% static/js/de.js | 174.12 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 176.5 kB | 0% static/js/es.js | 181.54 kB | 0% static/js/extends.js | 487.8 kB | 0% static/js/fr.js | 176.79 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.68 kB | 0% static/js/narrow.js | 363.68 kB | 0% static/js/nb-NO.js | 151.58 kB | 0% static/js/nl.js | 108.66 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 193.49 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 178.91 kB | 0% static/js/theme.js | 30.79 kB | 0% static/js/uk.js | 212.28 kB | 0% static/js/useFormatList.js | 7.62 kB | 0% static/js/wide.js | 292 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 110.19 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.85 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.DvDd_fWg.js | 4.85 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 3.89 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.89 MB | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.91 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.91 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 41.83 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 41.83 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 10:55:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#49067
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?