github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #7516] [CLOSED] [WIP] Fix rule matching when id fields are undefined (payee/category "is nothing") #49042

New Issue
Closed
opened 2026-04-26 10:54:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 10:54:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7516
Author: @sk10727-a11y
Created: 4/15/2026
Status: ❌ Closed

Base: master ← Head: fix-rules-nothing-payee

📝 Commits (4)

  • 7a3bfbb Normalize undefined/empty id fields in Condition.eval for 'is nothing' rules
  • 10eb10e added release note
  • 3c1e70f Revert unintended changes to condition.ts
  • a0ef943 [autofix.ci] apply automated fixes

📊 Changes

2 files changed (+14 additions, -0 deletions)

View changed files

📝 packages/loot-core/src/server/transactions/transaction-rules.ts (+8 -0)
➕ upcoming-release-notes/7516.md (+6 -0)

📄 Description

Description

Fixes an issue where rules like "payee is nothing" or "category is nothing" fail to match when the field is undefined.

Previously, Condition.eval returned false when a field was undefined, even though for id fields (like payee and category), undefined should be treated the same as null (i.e. “no value”). This caused rules to not apply for new transactions where these fields were not yet set.

This change normalizes undefined to null for id fields during evaluation, ensuring consistent rule behavior.

Related issue(s)

Fixes #5724

Testing

Tested rule behavior for id fields (payee, category) using separate rules:

  • Rule 1: payee is nothing → set category
  • Rule 2: category is nothing → set notes

Tested in both:

  • All Accounts view
  • Specific account register

Verified:

  • Rules correctly apply when fields are initially unset
  • Behavior is consistent across both views
  • No regressions observed for other rule conditions

Notes:

  • Since these are default rules, manually created transactions are automatically populated with the rule-applied values during entry (before the transaction is saved).
  • For rules to apply during manual entry:
    • In a specific account register: payment/deposit must be non-zero
    • In All Accounts: an account must be selected

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 34 12.91 MB 0%
loot-core 1 4.85 MB → 4.85 MB (+90 B) +0.00%
api 1 3.88 MB → 3.88 MB (+88 B) +0.00%
cli 1 7.89 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
34 12.91 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.85 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 853.16 kB 0%
static/js/PayeeRuleCountLabel.js 52.12 kB 0%
static/js/ReportRouter.js 1.18 MB 0%
static/js/ScheduleEditForm.js 135.5 kB 0%
static/js/TransactionEdit.js 182.43 kB 0%
static/js/TransactionList.js 82.49 kB 0%
static/js/Value.js 4.33 MB 0%
static/js/ca.js 191.72 kB 0%
static/js/chart-theme.js 679.65 kB 0%
static/js/client.js 450.92 kB 0%
static/js/da.js 104.4 kB 0%
static/js/de.js 174.12 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 176.5 kB 0%
static/js/es.js 181.54 kB 0%
static/js/extends.js 485.17 kB 0%
static/js/fr.js 176.79 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.68 kB 0%
static/js/narrow.js 363.04 kB 0%
static/js/nb-NO.js 151.58 kB 0%
static/js/nl.js 108.66 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 177.18 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 178.91 kB 0%
static/js/theme.js 30.79 kB 0%
static/js/uk.js 212.28 kB 0%
static/js/useFormatList.js 9.86 kB 0%
static/js/wide.js 292 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 110.19 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.85 MB → 4.85 MB (+90 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts 📈 +90 B (+0.42%) 20.92 kB → 21.01 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.Dm2zp-s1.js 0 B → 4.85 MB (+4.85 MB) -

Removed

Asset File Size % Changed
kcab.worker.Cw2V9gWA.js 4.85 MB → 0 B (-4.85 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
1 3.88 MB → 3.88 MB (+88 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts 📈 +88 B (+0.42%) 20.52 kB → 20.6 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
index.js 3.88 MB → 3.88 MB (+88 B) +0.00%

Smaller
No assets were smaller

Unchanged
No assets were unchanged

cli

Total

Files count Total bundle size % Changed
1 7.89 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.89 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7516 **Author:** [@sk10727-a11y](https://github.com/sk10727-a11y) **Created:** 4/15/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-rules-nothing-payee` --- ### 📝 Commits (4) - [`7a3bfbb`](https://github.com/actualbudget/actual/commit/7a3bfbb93d44302bd36e9e4cf220b6ad35839c0e) Normalize undefined/empty id fields in Condition.eval for 'is nothing' rules - [`10eb10e`](https://github.com/actualbudget/actual/commit/10eb10e31ca78276449f2a2bb570450e9f4a6d4a) added release note - [`3c1e70f`](https://github.com/actualbudget/actual/commit/3c1e70f7298369b6e0a050c720d7ecdfadb0ce10) Revert unintended changes to condition.ts - [`a0ef943`](https://github.com/actualbudget/actual/commit/a0ef9432a756207bebefa70b989053069e2125ca) [autofix.ci] apply automated fixes ### 📊 Changes **2 files changed** (+14 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/transactions/transaction-rules.ts` (+8 -0) ➕ `upcoming-release-notes/7516.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description Fixes an issue where rules like **"payee is nothing"** or **"category is nothing"** fail to match when the field is `undefined`. Previously, `Condition.eval` returned `false` when a field was `undefined`, even though for id fields (like payee and category), `undefined` should be treated the same as `null` (i.e. “no value”). This caused rules to not apply for new transactions where these fields were not yet set. This change normalizes `undefined` to `null` for id fields during evaluation, ensuring consistent rule behavior. ## Related issue(s) Fixes #5724 ## Testing Tested rule behavior for id fields (`payee`, `category`) using separate rules: - Rule 1: `payee is nothing → set category` - Rule 2: `category is nothing → set notes` Tested in both: - All Accounts view - Specific account register Verified: - Rules correctly apply when fields are initially unset - Behavior is consistent across both views - No regressions observed for other rule conditions **Notes:** - Since these are default rules, manually created transactions are automatically populated with the rule-applied values during entry (before the transaction is saved). - For rules to apply during manual entry: - In a specific account register: payment/deposit must be non-zero - In All Accounts: an account must be selected ## Checklist - [X] Release notes added (see link above) - [X] No obvious regressions in affected areas - [X] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 34 | 12.91 MB | 0% loot-core | 1 | 4.85 MB → 4.85 MB (+90 B) | +0.00% api | 1 | 3.88 MB → 3.88 MB (+88 B) | +0.00% cli | 1 | 7.89 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 34 | 12.91 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.85 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 853.16 kB | 0% static/js/PayeeRuleCountLabel.js | 52.12 kB | 0% static/js/ReportRouter.js | 1.18 MB | 0% static/js/ScheduleEditForm.js | 135.5 kB | 0% static/js/TransactionEdit.js | 182.43 kB | 0% static/js/TransactionList.js | 82.49 kB | 0% static/js/Value.js | 4.33 MB | 0% static/js/ca.js | 191.72 kB | 0% static/js/chart-theme.js | 679.65 kB | 0% static/js/client.js | 450.92 kB | 0% static/js/da.js | 104.4 kB | 0% static/js/de.js | 174.12 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 176.5 kB | 0% static/js/es.js | 181.54 kB | 0% static/js/extends.js | 485.17 kB | 0% static/js/fr.js | 176.79 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.68 kB | 0% static/js/narrow.js | 363.04 kB | 0% static/js/nb-NO.js | 151.58 kB | 0% static/js/nl.js | 108.66 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 177.18 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 178.91 kB | 0% static/js/theme.js | 30.79 kB | 0% static/js/uk.js | 212.28 kB | 0% static/js/useFormatList.js | 9.86 kB | 0% static/js/wide.js | 292 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 110.19 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.85 MB → 4.85 MB (+90 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts` | 📈 +90 B (+0.42%) | 20.92 kB → 21.01 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.Dm2zp-s1.js | 0 B → 4.85 MB (+4.85 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.Cw2V9gWA.js | 4.85 MB → 0 B (-4.85 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 3.88 MB → 3.88 MB (+88 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts` | 📈 +88 B (+0.42%) | 20.52 kB → 20.6 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.88 MB → 3.88 MB (+88 B) | +0.00% **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.89 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.89 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 10:54:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#49042
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?