github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3513] [MERGED] 🧪 improve setting e2e test stability #4900

New Issue
Closed
opened 2026-02-28 21:02:57 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:02:57 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3513
Author: @MatissJanis
Created: 9/26/2024
Status: ✅ Merged
Merged: 9/27/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/e2e-stability-3

📝 Commits (2)

  • 1d23873 🧪 improve setting e2e test stability
  • e3e0983 Update mobile VRT?

📊 Changes

8 files changed (+9 additions, -3 deletions)

View changed files

📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-6-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/playwright.config.js (+2 -2)
📝 packages/desktop-client/src/style/theme.tsx (+1 -1)
➕ upcoming-release-notes/3513.md (+6 -0)

📄 Description

https://github.com/actualbudget/actual/issues/3482

The problem: here auto is the default fallback value whereas here it is light.

This creates a race condition.

Additionally, the e2e tests don't always wait for the theme switch to finish. Hence it's more stable to use auto (the end result is the same.. it's just better stability wise).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3513 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 9/26/2024 **Status:** ✅ Merged **Merged:** 9/27/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/e2e-stability-3` --- ### 📝 Commits (2) - [`1d23873`](https://github.com/actualbudget/actual/commit/1d23873ddd0cf9eb0f034eacb1a44447b50a57c6) :test_tube: improve setting e2e test stability - [`e3e0983`](https://github.com/actualbudget/actual/commit/e3e0983d62055c407858e9394cd9af8796e3986f) Update mobile VRT? ### 📊 Changes **8 files changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-6-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/playwright.config.js` (+2 -2) 📝 `packages/desktop-client/src/style/theme.tsx` (+1 -1) ➕ `upcoming-release-notes/3513.md` (+6 -0) </details> ### 📄 Description https://github.com/actualbudget/actual/issues/3482 The problem: [here](https://github.com/actualbudget/actual/blob/master/packages/loot-core/src/server/main.ts#L1292) `auto` is the default fallback value whereas [here](https://github.com/actualbudget/actual/blob/4373f4d8f91a7a9f97cfeb475e713b1bdd1da60f/packages/desktop-client/src/style/theme.tsx#L34) it is `light`. This creates a race condition. Additionally, the e2e tests don't always wait for the theme switch to finish. Hence it's more stable to use `auto` (the end result is the same.. it's just better stability wise). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:02:57 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4900
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?