github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3511] [MERGED] Fix yearly schedule templates #4898

New Issue
Closed
opened 2026-02-28 21:02:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:02:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3511
Author: @JukeboxRhino
Created: 9/26/2024
Status: ✅ Merged
Merged: 10/3/2024
Merged by: @youngcw

Base: master ← Head: fix/yearly-schedule-templates

📝 Commits (1)

  • 97932c3 fix yearly schedule templates

📊 Changes

3 files changed (+75 additions, -1 deletions)

View changed files

📝 packages/loot-core/src/server/budget/goals/goalsSchedule.test.ts (+64 -0)
📝 packages/loot-core/src/server/budget/goals/goalsSchedule.ts (+5 -1)
➕ upcoming-release-notes/3511.md (+6 -0)

📄 Description

Current behavior of template goals set to a schedule with frequency yearly are broken once the category is fully funded. This means budgeting into future months does not work as expected, in this case the full yearly amount is budgeted in the month following the transaction (instead of 1/12 the amount). The function that handles calculating the base savings amount has been updated to take yearly schedules into account.

Example of previous broken behavior:
image
image

The same budget file with the fix applied and templates re-ran:
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3511 **Author:** [@JukeboxRhino](https://github.com/JukeboxRhino) **Created:** 9/26/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `fix/yearly-schedule-templates` --- ### 📝 Commits (1) - [`97932c3`](https://github.com/actualbudget/actual/commit/97932c3f00af01c9ba068d734c082854f75d5147) fix yearly schedule templates ### 📊 Changes **3 files changed** (+75 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/goals/goalsSchedule.test.ts` (+64 -0) 📝 `packages/loot-core/src/server/budget/goals/goalsSchedule.ts` (+5 -1) ➕ `upcoming-release-notes/3511.md` (+6 -0) </details> ### 📄 Description Current behavior of template goals set to a schedule with frequency `yearly` are broken once the category is fully funded. This means budgeting into future months does not work as expected, in this case the full yearly amount is budgeted in the month following the transaction (instead of 1/12 the amount). The function that handles calculating the base savings amount has been updated to take yearly schedules into account. Example of **previous broken** behavior: ![image](https://github.com/user-attachments/assets/f786b907-7917-4273-8cc7-b5e747b979a1) ![image](https://github.com/user-attachments/assets/76ba9a06-bed3-463e-b687-88741240fa3d) The same budget file with the fix applied and templates re-ran: ![image](https://github.com/user-attachments/assets/630c6cc2-a2f9-4435-a195-063ac5d98b95) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:02:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4898
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?