github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #7152] [MERGED] Handle missing accounts in SimpleFin batch sync #48791

New Issue
Closed
opened 2026-04-26 10:41:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 10:41:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7152
Author: @MatissJanis
Created: 3/7/2026
Status: ✅ Merged
Merged: 3/11/2026
Merged by: @MatissJanis

Base: master ← Head: claude/fix-simplefin-batch-sync-O8LcD

📝 Commits (6)

  • 938a7c1 [AI] Fix SimpleFin batch sync crash when accounts are missing from response
  • 3c32429 Add release notes for PR #7152
  • 1f2f8c5 [AI] Fix SimpleFIN batch sync error_code TypeError
  • fbdf02d Merge branch 'master' into claude/fix-simplefin-batch-sync-O8LcD
  • 1694bf6 [AI] Fix SimpleFin batch sync to emit ACCOUNT_MISSING for empty payloads
  • cbb458a Merge branch 'master' into claude/fix-simplefin-batch-sync-O8LcD

📊 Changes

5 files changed (+227 additions, -16 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.tsx (+5 -0)
📝 packages/loot-core/src/server/accounts/app.ts (+11 -2)
📝 packages/loot-core/src/server/accounts/sync.test.ts (+132 -1)
📝 packages/loot-core/src/server/accounts/sync.ts (+73 -13)
➕ upcoming-release-notes/7152.md (+6 -0)

📄 Description

Description

Warning: not manually tested as I don't actually use SimpleFin myself.. but I have reviewed the logic and tests and IMO they make sense.

Patching a problem with error reporting in SimpleFIN.

Related issue(s)

https://github.com/actualbudget/actual/issues/6623
https://github.com/actualbudget/actual/issues/6651
https://github.com/actualbudget/actual/issues/7114
https://github.com/actualbudget/actual/issues/7133

Testing

N/A

Checklist

  • Release notes added
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

https://claude.ai/code/session_01XbHgxxrXYR3UTyW6VmYj47

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 14.91 MB → 14.91 MB (+149 B) +0.00%
loot-core 1 5.83 MB → 5.83 MB (+1.82 kB) +0.03%
api 1 4.44 MB → 4.44 MB (+1.59 kB) +0.03%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 14.91 MB → 14.91 MB (+149 B) +0.00%
Changeset
File Δ Size
src/components/accounts/AccountSyncCheck.tsx 📈 +149 B (+1.54%) 9.43 kB → 9.58 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 9.56 MB → 9.56 MB (+149 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/ca.js 187.93 kB 0%
static/js/da.js 106.2 kB 0%
static/js/de.js 179.89 kB 0%
static/js/en-GB.js 7.18 kB 0%
static/js/en.js 170.86 kB 0%
static/js/es.js 174.37 kB 0%
static/js/fr.js 179.41 kB 0%
static/js/it.js 170.98 kB 0%
static/js/nb-NO.js 156.8 kB 0%
static/js/nl.js 113.06 kB 0%
static/js/pl.js 89.65 kB 0%
static/js/pt-BR.js 182.89 kB 0%
static/js/th.js 181.58 kB 0%
static/js/uk.js 215.35 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/ReportRouter.js 1.16 MB 0%
static/js/narrow.js 638.11 kB 0%
static/js/TransactionList.js 106.48 kB 0%
static/js/wide.js 164.15 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 11.57 kB 0%
static/js/useTransactionBatchActions.js 13.23 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.83 MB → 5.83 MB (+1.82 kB) +0.03%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts 📈 +1.55 kB (+5.98%) 25.87 kB → 27.42 kB
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts 📈 +281 B (+1.01%) 27.22 kB → 27.5 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.B3dK-LG9.js 0 B → 5.83 MB (+5.83 MB) -

Removed

Asset File Size % Changed
kcab.worker.BJdSX9Vk.js 5.83 MB → 0 B (-5.83 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
1 4.44 MB → 4.44 MB (+1.59 kB) +0.03%
Changeset
File Δ Size
src/server/accounts/sync.ts 📈 +1.35 kB (+5.85%) 23.09 kB → 24.44 kB
src/server/accounts/app.ts 📈 +245 B (+1.03%) 23.26 kB → 23.5 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
bundle.api.js 4.44 MB → 4.44 MB (+1.59 kB) +0.03%

Smaller
No assets were smaller

Unchanged
No assets were unchanged

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7152 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/7/2026 **Status:** ✅ Merged **Merged:** 3/11/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `claude/fix-simplefin-batch-sync-O8LcD` --- ### 📝 Commits (6) - [`938a7c1`](https://github.com/actualbudget/actual/commit/938a7c11f9740024da3df5ed5f2adc85e4698ebd) [AI] Fix SimpleFin batch sync crash when accounts are missing from response - [`3c32429`](https://github.com/actualbudget/actual/commit/3c32429dfb0b8fb4af6e2987c976a413734e3e98) Add release notes for PR #7152 - [`1f2f8c5`](https://github.com/actualbudget/actual/commit/1f2f8c5f10313acd074f8840b8938653134693ca) [AI] Fix SimpleFIN batch sync error_code TypeError - [`fbdf02d`](https://github.com/actualbudget/actual/commit/fbdf02decad3eb13ad673b22536bca610316b7de) Merge branch 'master' into claude/fix-simplefin-batch-sync-O8LcD - [`1694bf6`](https://github.com/actualbudget/actual/commit/1694bf62074d47bd38ca3a4ca023fb4edf131a52) [AI] Fix SimpleFin batch sync to emit ACCOUNT_MISSING for empty payloads - [`cbb458a`](https://github.com/actualbudget/actual/commit/cbb458af8e2ff829deab3c2986d629c6dff52966) Merge branch 'master' into claude/fix-simplefin-batch-sync-O8LcD ### 📊 Changes **5 files changed** (+227 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.tsx` (+5 -0) 📝 `packages/loot-core/src/server/accounts/app.ts` (+11 -2) 📝 `packages/loot-core/src/server/accounts/sync.test.ts` (+132 -1) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+73 -13) ➕ `upcoming-release-notes/7152.md` (+6 -0) </details> ### 📄 Description ## Description Warning: not manually tested as I don't actually use SimpleFin myself.. but I have reviewed the logic and tests and IMO they make sense. Patching a problem with error reporting in SimpleFIN. ## Related issue(s) <!-- Link to related issues if applicable --> https://github.com/actualbudget/actual/issues/6623 https://github.com/actualbudget/actual/issues/6651 https://github.com/actualbudget/actual/issues/7114 https://github.com/actualbudget/actual/issues/7133 ## Testing N/A ## Checklist - [x] Release notes added - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed https://claude.ai/code/session_01XbHgxxrXYR3UTyW6VmYj47 <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 14.91 MB → 14.91 MB (+149 B) | +0.00% loot-core | 1 | 5.83 MB → 5.83 MB (+1.82 kB) | +0.03% api | 1 | 4.44 MB → 4.44 MB (+1.59 kB) | +0.03% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 14.91 MB → 14.91 MB (+149 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/accounts/AccountSyncCheck.tsx` | 📈 +149 B (+1.54%) | 9.43 kB → 9.58 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.56 MB → 9.56 MB (+149 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/ca.js | 187.93 kB | 0% static/js/da.js | 106.2 kB | 0% static/js/de.js | 179.89 kB | 0% static/js/en-GB.js | 7.18 kB | 0% static/js/en.js | 170.86 kB | 0% static/js/es.js | 174.37 kB | 0% static/js/fr.js | 179.41 kB | 0% static/js/it.js | 170.98 kB | 0% static/js/nb-NO.js | 156.8 kB | 0% static/js/nl.js | 113.06 kB | 0% static/js/pl.js | 89.65 kB | 0% static/js/pt-BR.js | 182.89 kB | 0% static/js/th.js | 181.58 kB | 0% static/js/uk.js | 215.35 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/ReportRouter.js | 1.16 MB | 0% static/js/narrow.js | 638.11 kB | 0% static/js/TransactionList.js | 106.48 kB | 0% static/js/wide.js | 164.15 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 11.57 kB | 0% static/js/useTransactionBatchActions.js | 13.23 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.83 MB → 5.83 MB (+1.82 kB) | +0.03% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts` | 📈 +1.55 kB (+5.98%) | 25.87 kB → 27.42 kB `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts` | 📈 +281 B (+1.01%) | 27.22 kB → 27.5 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.B3dK-LG9.js | 0 B → 5.83 MB (+5.83 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BJdSX9Vk.js | 5.83 MB → 0 B (-5.83 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.44 MB → 4.44 MB (+1.59 kB) | +0.03% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/server/accounts/sync.ts` | 📈 +1.35 kB (+5.85%) | 23.09 kB → 24.44 kB `src/server/accounts/app.ts` | 📈 +245 B (+1.03%) | 23.26 kB → 23.5 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.44 MB → 4.44 MB (+1.59 kB) | +0.03% **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 10:41:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#48791
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?