[PR #6941] [MERGED] Move redux state to react-query - tags states #48654

Closed
opened 2026-04-26 10:34:09 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6941
Author: @joel-jeremy
Created: 2/11/2026
Status: Merged
Merged: 2/13/2026
Merged by: @joel-jeremy

Base: masterHead: react-query-tags


📝 Commits (7)

📊 Changes

14 files changed (+226 additions, -213 deletions)

View changed files

📝 packages/desktop-client/src/components/tags/ManageTags.tsx (+18 -8)
📝 packages/desktop-client/src/components/tags/TagCreationRow.tsx (+4 -4)
📝 packages/desktop-client/src/components/tags/TagEditor.tsx (+3 -4)
📝 packages/desktop-client/src/components/tags/TagRow.tsx (+8 -5)
📝 packages/desktop-client/src/hooks/useTagCSS.ts (+1 -1)
📝 packages/desktop-client/src/hooks/useTags.ts (+3 -16)
📝 packages/desktop-client/src/index.tsx (+0 -2)
📝 packages/desktop-client/src/redux/store.ts (+0 -5)
packages/desktop-client/src/tags/index.ts (+2 -0)
packages/desktop-client/src/tags/mutations.ts (+158 -0)
packages/desktop-client/src/tags/queries.ts (+20 -0)
packages/desktop-client/src/tags/tagsSlice.ts (+0 -165)
📝 packages/loot-core/src/server/tags/app.ts (+3 -3)
upcoming-release-notes/6941.md (+6 -0)

📄 Description

Not dependent on other react query PRs


Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 14.65 MB → 14.65 MB (+2.66 kB) +0.02%
loot-core 1 5.86 MB → 5.86 MB (+8 B) +0.00%
api 1 4.4 MB → 4.4 MB (+8 B) +0.00%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 14.65 MB → 14.65 MB (+2.66 kB) +0.02%
Changeset
File Δ Size
src/tags/mutations.ts 🆕 +5.22 kB 0 B → 5.22 kB
src/tags/queries.ts 🆕 +356 B 0 B → 356 B
src/hooks/useTagCSS.ts 📈 +158 B (+10.78%) 1.43 kB → 1.59 kB
src/components/tags/ManageTags.tsx 📈 +350 B (+4.47%) 7.65 kB → 7.99 kB
src/components/tags/TagEditor.tsx 📈 +49 B (+3.34%) 1.43 kB → 1.48 kB
src/components/tags/TagRow.tsx 📈 +142 B (+1.59%) 8.75 kB → 8.89 kB
src/components/tags/TagCreationRow.tsx 📈 +51 B (+0.43%) 11.64 kB → 11.69 kB
src/budget/mutations.ts 📈 +42 B (+0.19%) 21.44 kB → 21.48 kB
node_modules/hast-util-to-jsx-runtime/lib/index.js 📈 +18 B (+0.09%) 18.92 kB → 18.93 kB
src/components/rules/RuleRow.tsx 📈 +2 B (+0.02%) 10.83 kB → 10.83 kB
node_modules/estree-util-is-identifier-name/lib/index.js 📉 -2 B (-0.26%) 758 B → 756 B
src/accounts/accountsSlice.ts 📉 -38 B (-0.33%) 11.17 kB → 11.13 kB
src/index.tsx 📉 -16 B (-0.91%) 1.72 kB → 1.71 kB
src/redux/store.ts 📉 -21 B (-1.87%) 1.09 kB → 1.07 kB
src/hooks/useTags.ts 📉 -527 B (-68.26%) 772 B → 245 B
src/tags/tagsSlice.ts 🔥 -3.11 kB (-100%) 3.11 kB → 0 B
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 9.48 MB → 9.49 MB (+2.66 kB) +0.03%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/da.js 106.62 kB 0%
static/js/de.js 180.44 kB 0%
static/js/en-GB.js 7.18 kB 0%
static/js/en.js 164.99 kB 0%
static/js/es.js 173.83 kB 0%
static/js/fr.js 179.97 kB 0%
static/js/it.js 171.44 kB 0%
static/js/nb-NO.js 157.23 kB 0%
static/js/nl.js 106.65 kB 0%
static/js/pl.js 88.64 kB 0%
static/js/pt-BR.js 154.57 kB 0%
static/js/sv.js 78.2 kB 0%
static/js/th.js 182.35 kB 0%
static/js/uk.js 215.11 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/ReportRouter.js 1.13 MB 0%
static/js/narrow.js 637.46 kB 0%
static/js/TransactionList.js 106.13 kB 0%
static/js/wide.js 164.05 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 10.05 kB 0%
static/js/useTransactionBatchActions.js 13.23 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.86 MB → 5.86 MB (+8 B) +0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/tags/app.ts 📈 +10 B (+0.50%) 1.94 kB → 1.95 kB
home/runner/work/actual/actual/packages/loot-core/src/server/db/index.ts 📉 -2 B (-0.01%) 18.05 kB → 18.05 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.hYlRL2CV.js 0 B → 5.86 MB (+5.86 MB) -

Removed

Asset File Size % Changed
kcab.worker.BVeE0kCd.js 5.86 MB → 0 B (-5.86 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged


api

Total

Files count Total bundle size % Changed
1 4.4 MB → 4.4 MB (+8 B) +0.00%
Changeset
File Δ Size
src/server/tags/app.ts 📈 +10 B (+0.59%) 1.67 kB → 1.68 kB
src/server/db/index.ts 📉 -2 B (-0.01%) 16.1 kB → 16.1 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
bundle.api.js 4.4 MB → 4.4 MB (+8 B) +0.00%

Smaller
No assets were smaller

Unchanged
No assets were unchanged


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6941 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 2/11/2026 **Status:** ✅ Merged **Merged:** 2/13/2026 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `react-query-tags` --- ### 📝 Commits (7) - [`72370e6`](https://github.com/actualbudget/actual/commit/72370e6c633d46468fb1ee3daf50c56a8253d0ce) Move redux state to react-query - tags states - [`3c32de9`](https://github.com/actualbudget/actual/commit/3c32de9428f995de078d7965fc6f9e90e7b31147) Add release notes for PR #6941 - [`0c9959d`](https://github.com/actualbudget/actual/commit/0c9959d82cfa7988926f81914203440b8d8fb175) Cleanup sendThrow - [`1a9e5d8`](https://github.com/actualbudget/actual/commit/1a9e5d8dbc4ff3f3a8180bfdf05c0c2463d8d525) Cleanup - [`10c6079`](https://github.com/actualbudget/actual/commit/10c6079c77e9aa820c4a7b838d3cf5a1473b5a49) Merge remote-tracking branch 'origin/master' into react-query-tags - [`86c842c`](https://github.com/actualbudget/actual/commit/86c842c9c5e1c25a381989ec951e676dd6200314) Update import - [`1a49792`](https://github.com/actualbudget/actual/commit/1a497920415a98ed506bb59adaba189ab59b2dbd) Fix import ### 📊 Changes **14 files changed** (+226 additions, -213 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/tags/ManageTags.tsx` (+18 -8) 📝 `packages/desktop-client/src/components/tags/TagCreationRow.tsx` (+4 -4) 📝 `packages/desktop-client/src/components/tags/TagEditor.tsx` (+3 -4) 📝 `packages/desktop-client/src/components/tags/TagRow.tsx` (+8 -5) 📝 `packages/desktop-client/src/hooks/useTagCSS.ts` (+1 -1) 📝 `packages/desktop-client/src/hooks/useTags.ts` (+3 -16) 📝 `packages/desktop-client/src/index.tsx` (+0 -2) 📝 `packages/desktop-client/src/redux/store.ts` (+0 -5) ➕ `packages/desktop-client/src/tags/index.ts` (+2 -0) ➕ `packages/desktop-client/src/tags/mutations.ts` (+158 -0) ➕ `packages/desktop-client/src/tags/queries.ts` (+20 -0) ➖ `packages/desktop-client/src/tags/tagsSlice.ts` (+0 -165) 📝 `packages/loot-core/src/server/tags/app.ts` (+3 -3) ➕ `upcoming-release-notes/6941.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> Not dependent on other react query PRs <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 14.65 MB → 14.65 MB (+2.66 kB) | +0.02% loot-core | 1 | 5.86 MB → 5.86 MB (+8 B) | +0.00% api | 1 | 4.4 MB → 4.4 MB (+8 B) | +0.00% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 14.65 MB → 14.65 MB (+2.66 kB) | +0.02% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/tags/mutations.ts` | 🆕 +5.22 kB | 0 B → 5.22 kB `src/tags/queries.ts` | 🆕 +356 B | 0 B → 356 B `src/hooks/useTagCSS.ts` | 📈 +158 B (+10.78%) | 1.43 kB → 1.59 kB `src/components/tags/ManageTags.tsx` | 📈 +350 B (+4.47%) | 7.65 kB → 7.99 kB `src/components/tags/TagEditor.tsx` | 📈 +49 B (+3.34%) | 1.43 kB → 1.48 kB `src/components/tags/TagRow.tsx` | 📈 +142 B (+1.59%) | 8.75 kB → 8.89 kB `src/components/tags/TagCreationRow.tsx` | 📈 +51 B (+0.43%) | 11.64 kB → 11.69 kB `src/budget/mutations.ts` | 📈 +42 B (+0.19%) | 21.44 kB → 21.48 kB `node_modules/hast-util-to-jsx-runtime/lib/index.js` | 📈 +18 B (+0.09%) | 18.92 kB → 18.93 kB `src/components/rules/RuleRow.tsx` | 📈 +2 B (+0.02%) | 10.83 kB → 10.83 kB `node_modules/estree-util-is-identifier-name/lib/index.js` | 📉 -2 B (-0.26%) | 758 B → 756 B `src/accounts/accountsSlice.ts` | 📉 -38 B (-0.33%) | 11.17 kB → 11.13 kB `src/index.tsx` | 📉 -16 B (-0.91%) | 1.72 kB → 1.71 kB `src/redux/store.ts` | 📉 -21 B (-1.87%) | 1.09 kB → 1.07 kB `src/hooks/useTags.ts` | 📉 -527 B (-68.26%) | 772 B → 245 B `src/tags/tagsSlice.ts` | 🔥 -3.11 kB (-100%) | 3.11 kB → 0 B </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.48 MB → 9.49 MB (+2.66 kB) | +0.03% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/da.js | 106.62 kB | 0% static/js/de.js | 180.44 kB | 0% static/js/en-GB.js | 7.18 kB | 0% static/js/en.js | 164.99 kB | 0% static/js/es.js | 173.83 kB | 0% static/js/fr.js | 179.97 kB | 0% static/js/it.js | 171.44 kB | 0% static/js/nb-NO.js | 157.23 kB | 0% static/js/nl.js | 106.65 kB | 0% static/js/pl.js | 88.64 kB | 0% static/js/pt-BR.js | 154.57 kB | 0% static/js/sv.js | 78.2 kB | 0% static/js/th.js | 182.35 kB | 0% static/js/uk.js | 215.11 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/ReportRouter.js | 1.13 MB | 0% static/js/narrow.js | 637.46 kB | 0% static/js/TransactionList.js | 106.13 kB | 0% static/js/wide.js | 164.05 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 10.05 kB | 0% static/js/useTransactionBatchActions.js | 13.23 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.86 MB → 5.86 MB (+8 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/tags/app.ts` | 📈 +10 B (+0.50%) | 1.94 kB → 1.95 kB `home/runner/work/actual/actual/packages/loot-core/src/server/db/index.ts` | 📉 -2 B (-0.01%) | 18.05 kB → 18.05 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.hYlRL2CV.js | 0 B → 5.86 MB (+5.86 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BVeE0kCd.js | 5.86 MB → 0 B (-5.86 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.4 MB → 4.4 MB (+8 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/server/tags/app.ts` | 📈 +10 B (+0.59%) | 1.67 kB → 1.68 kB `src/server/db/index.ts` | 📉 -2 B (-0.01%) | 16.1 kB → 16.1 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.4 MB → 4.4 MB (+8 B) | +0.00% **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 10:34:09 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#48654