[PR #6844] [MERGED] Include scheduled transactions in nYNAB imports #48590

Closed
opened 2026-04-26 10:30:28 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6844
Author: @StephenBrown2
Created: 2/2/2026
Status: Merged
Merged: 2/4/2026
Merged by: @youngcw

Base: masterHead: push-klzynrrpmzxp


📝 Commits (6)

  • 75ed4d8 Include scheduled transactions in nYNAB imports
  • 5d3b85d Remove logs and restore schedule name from transaction memo
  • 8125e76 Simplify rule actions
  • 8b3dc6d Create schedules with unique names
  • 4bfd126 Set the note rather than append
  • c268422 Update ynab5 demo budget and e2e test

📊 Changes

5 files changed (+967 additions, -56 deletions)

View changed files

📝 packages/desktop-client/e2e/data/ynab5-demo-budget.json (+273 -2)
📝 packages/desktop-client/e2e/onboarding.test.ts (+26 -0)
📝 packages/loot-core/src/server/importers/ynab5-types.ts (+233 -22)
📝 packages/loot-core/src/server/importers/ynab5.ts (+429 -32)
upcoming-release-notes/6844.md (+6 -0)

📄 Description

This adds full nYNAB scheduled transaction support during import so recurring and future items appear in Actual right away. It also ensures transfer schedules map cleanly to Actual payees.

Details:

  • Expand YNAB5 schema types to match the public API (accounts, categories, months, transactions, and scheduled transactions), including flags and goal metadata.
  • Import scheduled transactions into Actual schedules, mapping recurring frequencies (monthly edge cases, twice-monthly) and one-off dates.
  • Normalize transaction notes to include memo + flag (as a #tag), and let subtransactions inherit the parent payee when they lack one.
  • Build scheduled transaction notes from memo + flag and push them into schedule rules when present.
  • For schedules without splits, update the rule category; for split schedules, add per-split actions for amounts, notes, payees (transfer/payee/fallback), and categories.

Translating goals to #template syntax left as a to-do.

After importing the demo budget export attached here:

Screenshot_2026-02-02_15-22-29 Screenshot_2026-02-02_15-32-02 Screenshot_2026-02-02_15-32-21 Screenshot_2026-02-02_15-32-37

Please test with some real scheduled transactions and make sure the dates are all correct.


Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 28 14.47 MB 0%
loot-core 1 5.84 MB → 5.85 MB (+10.94 kB) +0.18%
api 1 4.38 MB → 4.39 MB (+9.74 kB) +0.22%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
28 14.47 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 9.22 MB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/da.js 106.62 kB 0%
static/js/de.js 178.5 kB 0%
static/js/en-GB.js 7.18 kB 0%
static/js/en.js 162.91 kB 0%
static/js/es.js 173.92 kB 0%
static/js/fr.js 179.72 kB 0%
static/js/it.js 171.54 kB 0%
static/js/nb-NO.js 157.23 kB 0%
static/js/nl.js 106.65 kB 0%
static/js/pl.js 88.64 kB 0%
static/js/pt-BR.js 146.62 kB 0%
static/js/ru.js 106.97 kB 0%
static/js/sv.js 78.2 kB 0%
static/js/th.js 182.35 kB 0%
static/js/uk.js 215.11 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/ReportRouter.js 1.11 MB 0%
static/js/narrow.js 641.19 kB 0%
static/js/TransactionList.js 105.97 kB 0%
static/js/wide.js 160.07 kB 0%
static/js/AppliedFilters.js 9.71 kB 0%
static/js/usePayeeRuleCounts.js 11.79 kB 0%
static/js/useTransactionBatchActions.js 13.23 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.84 MB → 5.85 MB (+10.94 kB) +0.18%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab5.ts 📈 +10.56 kB (+72.70%) 14.53 kB → 25.09 kB
home/runner/work/actual/actual/packages/api/methods.ts 📈 +285 B (+18.92%) 1.47 kB → 1.75 kB
home/runner/work/actual/actual/packages/loot-core/src/server/aql/index.ts 📈 +2 B (+0.43%) 468 B → 470 B
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/app.ts 📈 +4 B (+0.16%) 2.4 kB → 2.41 kB
home/runner/work/actual/actual/packages/loot-core/src/server/schedules/app.ts 📈 +20 B (+0.15%) 12.68 kB → 12.7 kB
home/runner/work/actual/actual/packages/loot-core/src/server/budget/goal-template.ts 📈 +8 B (+0.11%) 7 kB → 7 kB
home/runner/work/actual/actual/packages/loot-core/src/server/api.ts 📈 +18 B (+0.07%) 25.15 kB → 25.17 kB
home/runner/work/actual/actual/packages/loot-core/src/server/main.ts 📈 +4 B (+0.07%) 5.96 kB → 5.96 kB
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/export/export-to-csv.ts 📈 +2 B (+0.06%) 3.11 kB → 3.11 kB
home/runner/work/actual/actual/packages/loot-core/src/server/schedules/find-schedules.ts 📈 +6 B (+0.06%) 9.46 kB → 9.47 kB
home/runner/work/actual/actual/packages/loot-core/src/server/tools/app.ts 📈 +2 B (+0.06%) 3.36 kB → 3.36 kB
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/merge.ts 📈 +2 B (+0.06%) 3.44 kB → 3.44 kB
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts 📈 +12 B (+0.05%) 24.57 kB → 24.58 kB
home/runner/work/actual/actual/packages/loot-core/src/server/aql/schema/executors.ts 📈 +2 B (+0.03%) 7.35 kB → 7.36 kB
home/runner/work/actual/actual/packages/loot-core/src/server/budget/base.ts 📈 +2 B (+0.02%) 8.79 kB → 8.79 kB
home/runner/work/actual/actual/packages/loot-core/src/server/dashboard/app.ts 📈 +2 B (+0.02%) 9.6 kB → 9.6 kB
home/runner/work/actual/actual/packages/loot-core/src/server/budget/app.ts 📈 +2 B (+0.02%) 10.12 kB → 10.12 kB
home/runner/work/actual/actual/packages/loot-core/src/server/budget/category-template-context.ts 📈 +4 B (+0.02%) 22.91 kB → 22.91 kB
home/runner/work/actual/actual/packages/loot-core/src/mocks/budget.ts 📈 +4 B (+0.02%) 25.02 kB → 25.02 kB
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts 📈 +2 B (+0.01%) 25.17 kB → 25.17 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.C30497Fh.js 0 B → 5.85 MB (+5.85 MB) -

Removed

Asset File Size % Changed
kcab.worker.DE5uAdQe.js 5.84 MB → 0 B (-5.84 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged


api

Total

Files count Total bundle size % Changed
1 4.38 MB → 4.39 MB (+9.74 kB) +0.22%
Changeset
File Δ Size
src/server/importers/ynab5.ts 📈 +9.4 kB (+71.88%) 13.07 kB → 22.47 kB
home/runner/work/actual/actual/packages/api/methods.ts 📈 +249 B (+19.01%) 1.28 kB → 1.52 kB
src/server/aql/index.ts 📈 +2 B (+0.49%) 408 B → 410 B
src/server/transactions/app.ts 📈 +4 B (+0.18%) 2.12 kB → 2.12 kB
src/server/schedules/app.ts 📈 +20 B (+0.18%) 10.97 kB → 10.99 kB
src/server/budget/goal-template.ts 📈 +8 B (+0.13%) 6.16 kB → 6.17 kB
src/server/api.ts 📈 +18 B (+0.08%) 22 kB → 22.02 kB
src/server/main.ts 📈 +4 B (+0.08%) 5.16 kB → 5.16 kB
src/server/schedules/find-schedules.ts 📈 +6 B (+0.07%) 8.3 kB → 8.31 kB
src/server/transactions/export/export-to-csv.ts 📈 +2 B (+0.07%) 2.78 kB → 2.78 kB
src/server/transactions/merge.ts 📈 +2 B (+0.06%) 3.07 kB → 3.07 kB
src/server/tools/app.ts 📈 +2 B (+0.06%) 3.11 kB → 3.11 kB
src/server/accounts/sync.ts 📈 +12 B (+0.05%) 21.93 kB → 21.94 kB
src/server/aql/schema/executors.ts 📈 +2 B (+0.03%) 6.64 kB → 6.64 kB
src/server/budget/base.ts 📈 +2 B (+0.02%) 7.88 kB → 7.88 kB
src/server/dashboard/app.ts 📈 +2 B (+0.02%) 8.59 kB → 8.6 kB
src/server/budget/app.ts 📈 +2 B (+0.02%) 8.86 kB → 8.86 kB
src/server/budget/category-template-context.ts 📈 +4 B (+0.02%) 20.45 kB → 20.45 kB
src/mocks/budget.ts 📈 +4 B (+0.02%) 22.21 kB → 22.22 kB
src/server/transactions/transaction-rules.ts 📈 +2 B (+0.01%) 22.35 kB → 22.35 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
bundle.api.js 4.38 MB → 4.39 MB (+9.74 kB) +0.22%

Smaller
No assets were smaller

Unchanged
No assets were unchanged


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6844 **Author:** [@StephenBrown2](https://github.com/StephenBrown2) **Created:** 2/2/2026 **Status:** ✅ Merged **Merged:** 2/4/2026 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `push-klzynrrpmzxp` --- ### 📝 Commits (6) - [`75ed4d8`](https://github.com/actualbudget/actual/commit/75ed4d8bcf7e6a3ac027bf45ac9a9a98fd468f75) Include scheduled transactions in nYNAB imports - [`5d3b85d`](https://github.com/actualbudget/actual/commit/5d3b85d1cb72e78273aefd9da915e05b7437aa32) Remove logs and restore schedule name from transaction memo - [`8125e76`](https://github.com/actualbudget/actual/commit/8125e76f665d594254ae844cfe8faf251148893d) Simplify rule actions - [`8b3dc6d`](https://github.com/actualbudget/actual/commit/8b3dc6ddae9f41f9b16c164ff4919a6bbdc71408) Create schedules with unique names - [`4bfd126`](https://github.com/actualbudget/actual/commit/4bfd126b0071b3df4db1c83a410548cac65b26d0) Set the note rather than append - [`c268422`](https://github.com/actualbudget/actual/commit/c26842200952d58a541a514891e5644d5bf3ddba) Update ynab5 demo budget and e2e test ### 📊 Changes **5 files changed** (+967 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/data/ynab5-demo-budget.json` (+273 -2) 📝 `packages/desktop-client/e2e/onboarding.test.ts` (+26 -0) 📝 `packages/loot-core/src/server/importers/ynab5-types.ts` (+233 -22) 📝 `packages/loot-core/src/server/importers/ynab5.ts` (+429 -32) ➕ `upcoming-release-notes/6844.md` (+6 -0) </details> ### 📄 Description This adds full nYNAB scheduled transaction support during import so recurring and future items appear in Actual right away. It also ensures transfer schedules map cleanly to Actual payees. Details: - Expand YNAB5 schema types to match the public API (accounts, categories, months, transactions, and scheduled transactions), including flags and goal metadata. - Import scheduled transactions into Actual schedules, mapping recurring frequencies (monthly edge cases, twice-monthly) and one-off dates. - Normalize transaction notes to include memo + flag (as a #tag), and let subtransactions inherit the parent payee when they lack one. - Build scheduled transaction notes from memo + flag and push them into schedule rules when present. - For schedules without splits, update the rule category; for split schedules, add per-split actions for amounts, notes, payees (transfer/payee/fallback), and categories. Translating goals to #template syntax left as a to-do. - Fixes [#6832](https://github.com/actualbudget/actual/issues/6832) - Fixes [#5455](https://github.com/actualbudget/actual/issues/5455) After importing the demo budget export attached [here](https://github.com/actualbudget/actual/issues/5455#issuecomment-3146792405): <img width="1456" height="672" alt="Screenshot_2026-02-02_15-22-29" src="https://github.com/user-attachments/assets/b7166e97-8c95-4673-9c3c-84647a9cb7b8" /> <img width="730" height="579" alt="Screenshot_2026-02-02_15-32-02" src="https://github.com/user-attachments/assets/103416b5-37eb-42b8-a54d-9a15f30728a2" /> <img width="730" height="676" alt="Screenshot_2026-02-02_15-32-21" src="https://github.com/user-attachments/assets/03613f32-aeff-4151-a146-e208cfdb8b00" /> <img width="730" height="565" alt="Screenshot_2026-02-02_15-32-37" src="https://github.com/user-attachments/assets/ad166bd1-302e-4fb9-bb67-57e127de7662" /> Please test with some real scheduled transactions and make sure the dates are all correct. <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 28 | 14.47 MB | 0% loot-core | 1 | 5.84 MB → 5.85 MB (+10.94 kB) | +0.18% api | 1 | 4.38 MB → 4.39 MB (+9.74 kB) | +0.22% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 28 | 14.47 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.22 MB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/da.js | 106.62 kB | 0% static/js/de.js | 178.5 kB | 0% static/js/en-GB.js | 7.18 kB | 0% static/js/en.js | 162.91 kB | 0% static/js/es.js | 173.92 kB | 0% static/js/fr.js | 179.72 kB | 0% static/js/it.js | 171.54 kB | 0% static/js/nb-NO.js | 157.23 kB | 0% static/js/nl.js | 106.65 kB | 0% static/js/pl.js | 88.64 kB | 0% static/js/pt-BR.js | 146.62 kB | 0% static/js/ru.js | 106.97 kB | 0% static/js/sv.js | 78.2 kB | 0% static/js/th.js | 182.35 kB | 0% static/js/uk.js | 215.11 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/ReportRouter.js | 1.11 MB | 0% static/js/narrow.js | 641.19 kB | 0% static/js/TransactionList.js | 105.97 kB | 0% static/js/wide.js | 160.07 kB | 0% static/js/AppliedFilters.js | 9.71 kB | 0% static/js/usePayeeRuleCounts.js | 11.79 kB | 0% static/js/useTransactionBatchActions.js | 13.23 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.84 MB → 5.85 MB (+10.94 kB) | +0.18% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab5.ts` | 📈 +10.56 kB (+72.70%) | 14.53 kB → 25.09 kB `home/runner/work/actual/actual/packages/api/methods.ts` | 📈 +285 B (+18.92%) | 1.47 kB → 1.75 kB `home/runner/work/actual/actual/packages/loot-core/src/server/aql/index.ts` | 📈 +2 B (+0.43%) | 468 B → 470 B `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/app.ts` | 📈 +4 B (+0.16%) | 2.4 kB → 2.41 kB `home/runner/work/actual/actual/packages/loot-core/src/server/schedules/app.ts` | 📈 +20 B (+0.15%) | 12.68 kB → 12.7 kB `home/runner/work/actual/actual/packages/loot-core/src/server/budget/goal-template.ts` | 📈 +8 B (+0.11%) | 7 kB → 7 kB `home/runner/work/actual/actual/packages/loot-core/src/server/api.ts` | 📈 +18 B (+0.07%) | 25.15 kB → 25.17 kB `home/runner/work/actual/actual/packages/loot-core/src/server/main.ts` | 📈 +4 B (+0.07%) | 5.96 kB → 5.96 kB `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/export/export-to-csv.ts` | 📈 +2 B (+0.06%) | 3.11 kB → 3.11 kB `home/runner/work/actual/actual/packages/loot-core/src/server/schedules/find-schedules.ts` | 📈 +6 B (+0.06%) | 9.46 kB → 9.47 kB `home/runner/work/actual/actual/packages/loot-core/src/server/tools/app.ts` | 📈 +2 B (+0.06%) | 3.36 kB → 3.36 kB `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/merge.ts` | 📈 +2 B (+0.06%) | 3.44 kB → 3.44 kB `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts` | 📈 +12 B (+0.05%) | 24.57 kB → 24.58 kB `home/runner/work/actual/actual/packages/loot-core/src/server/aql/schema/executors.ts` | 📈 +2 B (+0.03%) | 7.35 kB → 7.36 kB `home/runner/work/actual/actual/packages/loot-core/src/server/budget/base.ts` | 📈 +2 B (+0.02%) | 8.79 kB → 8.79 kB `home/runner/work/actual/actual/packages/loot-core/src/server/dashboard/app.ts` | 📈 +2 B (+0.02%) | 9.6 kB → 9.6 kB `home/runner/work/actual/actual/packages/loot-core/src/server/budget/app.ts` | 📈 +2 B (+0.02%) | 10.12 kB → 10.12 kB `home/runner/work/actual/actual/packages/loot-core/src/server/budget/category-template-context.ts` | 📈 +4 B (+0.02%) | 22.91 kB → 22.91 kB `home/runner/work/actual/actual/packages/loot-core/src/mocks/budget.ts` | 📈 +4 B (+0.02%) | 25.02 kB → 25.02 kB `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts` | 📈 +2 B (+0.01%) | 25.17 kB → 25.17 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.C30497Fh.js | 0 B → 5.85 MB (+5.85 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.DE5uAdQe.js | 5.84 MB → 0 B (-5.84 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.38 MB → 4.39 MB (+9.74 kB) | +0.22% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/server/importers/ynab5.ts` | 📈 +9.4 kB (+71.88%) | 13.07 kB → 22.47 kB `home/runner/work/actual/actual/packages/api/methods.ts` | 📈 +249 B (+19.01%) | 1.28 kB → 1.52 kB `src/server/aql/index.ts` | 📈 +2 B (+0.49%) | 408 B → 410 B `src/server/transactions/app.ts` | 📈 +4 B (+0.18%) | 2.12 kB → 2.12 kB `src/server/schedules/app.ts` | 📈 +20 B (+0.18%) | 10.97 kB → 10.99 kB `src/server/budget/goal-template.ts` | 📈 +8 B (+0.13%) | 6.16 kB → 6.17 kB `src/server/api.ts` | 📈 +18 B (+0.08%) | 22 kB → 22.02 kB `src/server/main.ts` | 📈 +4 B (+0.08%) | 5.16 kB → 5.16 kB `src/server/schedules/find-schedules.ts` | 📈 +6 B (+0.07%) | 8.3 kB → 8.31 kB `src/server/transactions/export/export-to-csv.ts` | 📈 +2 B (+0.07%) | 2.78 kB → 2.78 kB `src/server/transactions/merge.ts` | 📈 +2 B (+0.06%) | 3.07 kB → 3.07 kB `src/server/tools/app.ts` | 📈 +2 B (+0.06%) | 3.11 kB → 3.11 kB `src/server/accounts/sync.ts` | 📈 +12 B (+0.05%) | 21.93 kB → 21.94 kB `src/server/aql/schema/executors.ts` | 📈 +2 B (+0.03%) | 6.64 kB → 6.64 kB `src/server/budget/base.ts` | 📈 +2 B (+0.02%) | 7.88 kB → 7.88 kB `src/server/dashboard/app.ts` | 📈 +2 B (+0.02%) | 8.59 kB → 8.6 kB `src/server/budget/app.ts` | 📈 +2 B (+0.02%) | 8.86 kB → 8.86 kB `src/server/budget/category-template-context.ts` | 📈 +4 B (+0.02%) | 20.45 kB → 20.45 kB `src/mocks/budget.ts` | 📈 +4 B (+0.02%) | 22.21 kB → 22.22 kB `src/server/transactions/transaction-rules.ts` | 📈 +2 B (+0.01%) | 22.35 kB → 22.35 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- bundle.api.js | 4.38 MB → 4.39 MB (+9.74 kB) | +0.22% **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 10:30:28 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#48590