github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6667] [MERGED] lint: re-enable some react rules #48478

New Issue
Closed
opened 2026-04-26 10:24:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 10:24:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6667
Author: @MatissJanis
Created: 1/15/2026
Status: ✅ Merged
Merged: 1/16/2026
Merged by: @MatissJanis

Base: master ← Head: cursor/oxlint-react-hooks-rule-6f9b

📝 Commits (10+)

  • 6c96fb1 Remove hooks disable in electron fixtures
  • 0fe5e9c Add release notes for PR #6667
  • b941a3c Re-enable exhaustive-deps for low-risk hooks
  • 75ad401 Reduce exhaustive-deps overrides
  • d8f5e7f Format useQuery hook
  • 24f32c6 Fix exhaustive-deps warnings in hooks
  • 7d8d117 Format useQuery dependencies
  • 8001e6a Document dynamic hook dependencies
  • a62eb14 Use react exhaustive-deps disables
  • e7b82ff Adjust exhaustive-deps disables

📊 Changes

25 files changed (+152 additions, -148 deletions)

View changed files

📝 .oxlintrc.json (+2 -48)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+10 -5)
📝 packages/desktop-client/src/components/GlobalKeys.ts (+1 -1)
📝 packages/desktop-client/src/components/LoggedInUser.tsx (+11 -5)
📝 packages/desktop-client/src/components/ManageRules.tsx (+17 -16)
📝 packages/desktop-client/src/components/Modals.tsx (+2 -1)
📝 packages/desktop-client/src/components/Notifications.tsx (+5 -3)
📝 packages/desktop-client/src/components/budget/BudgetSummaries.tsx (+17 -12)
📝 packages/desktop-client/src/components/budget/DynamicBudgetTable.tsx (+1 -1)
📝 packages/desktop-client/src/components/budget/index.tsx (+13 -5)
📝 packages/desktop-client/src/components/manager/subscribe/common.tsx (+8 -1)
📝 packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx (+1 -0)
📝 packages/desktop-client/src/components/payees/PayeeTable.tsx (+1 -0)
📝 packages/desktop-client/src/components/reports/SaveReportName.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTable.tsx (+33 -37)
📝 packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableTotals.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/reports/CustomReport.tsx (+1 -0)
📝 packages/desktop-client/src/components/reports/useReport.ts (+1 -1)
📝 packages/desktop-client/src/components/schedules/SchedulesTable.tsx (+1 -1)
📝 packages/desktop-client/src/components/select/DateSelect.tsx (+3 -2)

...and 5 more files

📄 Description

Re-enable some react rules

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6667 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 1/15/2026 **Status:** ✅ Merged **Merged:** 1/16/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `cursor/oxlint-react-hooks-rule-6f9b` --- ### 📝 Commits (10+) - [`6c96fb1`](https://github.com/actualbudget/actual/commit/6c96fb17599fec85f3e4873059e22053b7139638) Remove hooks disable in electron fixtures - [`0fe5e9c`](https://github.com/actualbudget/actual/commit/0fe5e9c99c0479546837b21dd0886c159f3535dd) Add release notes for PR #6667 - [`b941a3c`](https://github.com/actualbudget/actual/commit/b941a3c338827995d5c931d67e73e53d58b70d72) Re-enable exhaustive-deps for low-risk hooks - [`75ad401`](https://github.com/actualbudget/actual/commit/75ad401c604da770fd36b0fcd6a6ae37fea7b187) Reduce exhaustive-deps overrides - [`d8f5e7f`](https://github.com/actualbudget/actual/commit/d8f5e7f5df14feb9354975e683c7f40098fd0c99) Format useQuery hook - [`24f32c6`](https://github.com/actualbudget/actual/commit/24f32c6d52974086addeef06835e720fe789dd0f) Fix exhaustive-deps warnings in hooks - [`7d8d117`](https://github.com/actualbudget/actual/commit/7d8d117dec628c9e4fb4131bb18dd0b0d703f1cd) Format useQuery dependencies - [`8001e6a`](https://github.com/actualbudget/actual/commit/8001e6a00f2f13852378f558a17c1caea57144e2) Document dynamic hook dependencies - [`a62eb14`](https://github.com/actualbudget/actual/commit/a62eb14ed9841e1fd30e0476650b822dbd3b61b4) Use react exhaustive-deps disables - [`e7b82ff`](https://github.com/actualbudget/actual/commit/e7b82ffcdb541dba566ea8d2b1b984c12e4ab263) Adjust exhaustive-deps disables ### 📊 Changes **25 files changed** (+152 additions, -148 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+2 -48) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+10 -5) 📝 `packages/desktop-client/src/components/GlobalKeys.ts` (+1 -1) 📝 `packages/desktop-client/src/components/LoggedInUser.tsx` (+11 -5) 📝 `packages/desktop-client/src/components/ManageRules.tsx` (+17 -16) 📝 `packages/desktop-client/src/components/Modals.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/Notifications.tsx` (+5 -3) 📝 `packages/desktop-client/src/components/budget/BudgetSummaries.tsx` (+17 -12) 📝 `packages/desktop-client/src/components/budget/DynamicBudgetTable.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/budget/index.tsx` (+13 -5) 📝 `packages/desktop-client/src/components/manager/subscribe/common.tsx` (+8 -1) 📝 `packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/payees/PayeeTable.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/reports/SaveReportName.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTable.tsx` (+33 -37) 📝 `packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableTotals.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/reports/CustomReport.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/reports/useReport.ts` (+1 -1) 📝 `packages/desktop-client/src/components/schedules/SchedulesTable.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/select/DateSelect.tsx` (+3 -2) _...and 5 more files_ </details> ### 📄 Description Re-enable some react rules --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 10:24:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#48478
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?