mirror of
https://github.com/actualbudget/actual.git
synced 2026-05-06 15:12:35 -05:00
Closed
opened 2026-04-26 10:24:18 -05:00 by GiteaMirror
·
0 comments
No Branch/Tag Specified
master
claude/hide-default-categories-1cwBZ
matiss/crdt-source-loading
matiss/crdt-protobuf
release/26.5.0
claude/update-issue-template-ykMNn
claude/fix-issue-7667-DPXi3
cursor/formula-feedback-improvements-4223
cursor/resolve-pr-7449-ee11
claude/fix-typescript-build-error-JPtZ5
jfdoming/api-tokens-part-3
jfdoming/api-tokens-part-2
jfdoming/api-tokens-part-1
claude/speed-up-vrt-workflow-ZAyI5
claude/crdt-version-auto-publish-Ph1BH
copilot/add-repository-configs-to-packages
worktree-compressed-drifting-ritchie
worktree-mellow-strolling-dawn
matiss/browser-api
claude/api-consumer-verification-kfz1K
feature/enable-banking
cursor/transaction-table-rewrite-f077
pr-7454
claude/fix-issue-7410-LLLQ4
release/v100.0.0
revert-7350-trim-deps
revert-7220-sankey-report
revert-7242-fix/split-parent-update-corruption
revert-7281-generate-icons
claude/electron-to-tauri-migration-LjBN8
worktree-remotion
release/vv26.4.0-pre
claude/browser-compatible-api-QbhHh
claude/improve-cli-transactions-waTUY
claude/publish-react-native-ios-j8qoT
js-proxy
claude/fix-flaky-ci-job-5gDdz
react-query-rules
react-query-useSchedules
claude/nightly-theme-validation-scan-DzOGD
claude/debug-simplefin-error-ZuKzB
matiss/desktop-client-subpath-imports
claude/fix-simplefin-ssrf-T31gX
claude/release-notes-validation-X7rvR
add-claude-github-actions-1772738270730
cursor/sync-performance-notification-9899
react-query-prefs
matiss/chunked-sync-and-progress-ux
v26.2.1
copilot/sub-pr-6880
fix-react-query-clear-on-close-budget
copilot/sub-pr-6140
feat/auto-note
feat/scoped-bank-sync
cursor/desktop-transactions-react-table-1d0c
fix-exhaustive-deps-App
copilot/fix-find-replace-bug
release/v26.2.0-pre
matiss/browser-tests
mobile-fix-drag-and-drop-across-groups
budget-table-v2
PayeeAutocomplete2
pglite
bugfix/plugins/fix-plugins-sw
feat/plugins/plugins-core-package
prerelease
matiss/unicode-minus-fix
cursor/fix-actual-github-issue-6206-gemini-3-pro-preview-9c37
TransactionFormPage
cursor/implement-mortgage-and-loan-account-type-78ca
tests-update-fill-with-pressSequentially
mobile/link-modal
deps/25.11
cursor/fix-update-vrt-apply-ci-job-dispatch-b324
sync-server-plugins
cursor/propose-patch-for-github-issue-5680-2a18
fix/compiler-preserve-inner-dollar-escapes
cursor/analyze-actual-budget-issue-and-propose-fix-5b70
coderabbitai/docstrings/0c070e5
cursor/add-wip-prefix-and-comment-to-prs-d78d
jfdoming/08-21-auto-focus-on-navigate-in-all-browsers
show-totals-on-mobile-budget-banners
allow-child-transactions-make-transfer
mobile-calculator-keyboard
payee-geolocation
enhance/restore_scroll_position
dm-fix-second-click-on-mobile-new-transaction-2
scrollToLocationBudget
alert-autofix-38
tsconfig-composite
mobile-fix-uncategorized-transactions-on-tracking-budgets
server-budget-handlers
fix-sql-injection-in-cleanup-template
non-chrome-draggable-workaround
mobile-budget-page-swipe-navigation
ts-db-all
stable
dark-theme-with-brand-colors
fix-mobile-delete-group
ts-db-select
UnderKoen/reconcile-context-menu
master-before-server-merge
v25.2.1
ts-runQuery
rename-redux-hooks
UnderKoen/3557-persist-state-in-history
remove-redux-CLOSE_BUDGET
fix-exhaustive-deps-errors-FinancesApp
redux-toolkit-createSlice-backup
accounts-function-component
ts-useSplitsExpanded
loot-core-server-package
useTransactios-in-TransactionEdit
react-aria-input
move-redux-to-desktop-client
QueryState-type
fix-themes-applied-late
mobile-vrts
revert-3295-spendingCardFix
react-aria-button-4
split-payee-on-mobile
twk3/pin-apis-crdt
notes-tag-autocomplete
ts-LoadBackup
dnd-kit
package-upgrades
v26.5.0
v26.4.0
v26.3.0
v26.2.1
v26.2.0
v26.1.0
v25.12.0
v25.11.0
v25.10.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.1
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.1
v25.2.0
v25.1.0
v24.12.0
v24.11.0
v24.10.1
v24.10.0
v24.9.0
v24.8.0
v24.7.0
v24.6.0
v24.5.0
v24.4.0
v24.3.0
v24.2.0
v24.1.0
v23.12.0
v23.11.0
v23.10.0
v23.9.0
v23.8.1
v23.8.0
v23.7.2
v23.7.1
v23.7.0
v23.6.0
v23.5.0
v23.4.2
v23.4.1
v23.4.0
v23.3.2
v23.3.0
v23.2.9
v23.2.5
v23.1.12
v22.12.9
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
Mirrored from GitHub Pull Request
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#48471
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/actualbudget/actual/pull/6653
Author: @StephenBrown2
Created: 1/14/2026
Status: ✅ Merged
Merged: 3/14/2026
Merged by: @youngcw
Base:
master← Head:transaction-drag-drop📝 Commits (4)
92e0d69feat(desktop-client): add transaction drag-and-drop reordering3d62d7aMerge branch 'master' into transaction-drag-drop156d245void promises1d5632fMerge branch 'master' into transaction-drag-drop📊 Changes
14 files changed (+1882 additions, -582 deletions)
View changed files
📝
packages/desktop-client/src/components/accounts/Account.tsx(+11 -0)📝
packages/desktop-client/src/components/reports/reports/Calendar.tsx(+1 -0)📝
packages/desktop-client/src/components/sort.tsx(+9 -4)📝
packages/desktop-client/src/components/transactions/TransactionList.tsx(+126 -1)📝
packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx(+1 -1)📝
packages/desktop-client/src/components/transactions/TransactionsTable.tsx(+836 -515)➕
packages/desktop-client/src/hooks/useDragDrop.tsx(+515 -0)📝
packages/loot-core/src/server/accounts/sync.ts(+10 -1)📝
packages/loot-core/src/server/db/index.ts(+142 -1)📝
packages/loot-core/src/server/db/sort.ts(+138 -7)📝
packages/loot-core/src/server/transactions/app.ts(+33 -0)📝
packages/loot-core/src/server/transactions/import/__snapshots__/parse-file.test.ts.snap(+51 -51)📝
packages/loot-core/src/shared/transactions.ts(+3 -1)➕
upcoming-release-notes/6653.md(+6 -0)📄 Description
Summary
Adds drag-and-drop reordering for transactions within the same date, allowing users to manually control transaction order. This provides a more intuitive way to arrange transactions when multiple occur on the same day.
Motivation
When multiple transactions happen on the same date, users may want to control the display order to reflect the actual sequence of events or for personal organization. Previously, the only way to affect ordering was through the
sort_orderfield which was not directly user-controllable.Fixes https://github.com/actualbudget/actual/issues/1165
Fixes https://github.com/actualbudget/actual/issues/6588
Demo
Trying to drag a transaction outside of its day is prohibited, and visually noted (no invalid drop zones).
Changes
Core Logic (
loot-core)transaction-moveAPI: Added a new undoable server method to reorder transactions within a date group using a midpoint/shove algorithm (similar to category reordering)moveTransactiondatabase function: Implementation inpackages/loot-core/src/server/db/index.tsthat handles the actual reordering logic, including child/split transaction handlingTRANSACTION_SORT_INCREMENTconstant: Introduced a smaller increment (1024 vs 16384) for transaction sort orders, allowing more reordering operations before needing to resequenceshoveSortOrdersDescendingalgorithm: Added tosort.tsfor handling sort order calculations in descending-sorted lists (transactions are displayed newest first by default)sort_orderand move together with the parent; child transactions can also be reordered within their siblingsTRANSACTION_SORT_INCREMENTfor better spacing during importssort_orderas a final tiebreaker in transaction queriesDesktop Client - New React-Aria Drag-Drop Hook
Added a new
useAriaDragDrop.tshook (useDrag/useDrop) using react-aria, specifically for transaction reordering. This coexists with the existing react-dnd system used elsewhere in the app.Key features:
Desktop Client - Transaction Table Updates
Changes in
TransactionsTable.tsx:canDrag,draggedDate,draggedId,draggedParentId,prevRowDate,nextRowDate,sortField,ascDesc,onDragChange,onDropChanges in
TransactionList.tsx:onReordercallback that validates drops and calls the newtransaction-moveAPIisFilteredandallowReorderprops to control when reordering is enabledNew file
dragDropValidation.ts:isValidBoundaryDropused by both TransactionList and TransactionsTableDesktop Client - Drop Highlight Updates
Updated
sort.tsxto support both legacy (top/bottom) and react-aria (before/after) position terminology for theDropHighlightcomponent.Reorder Constraints
Testing
TransactionsTable.test.tsxto useuserEvent.keyboardinstead ofuserEvent.typefor Enter keyparse-file.test.ts.snapfor newTRANSACTION_SORT_INCREMENTspacingChecklist
yarn typecheckpassesyarn lint:fixhas been runRelated Issues
AI generated
This code was completely vibe-coded by Claude, based on an analysis of the original PR.
Bundle Stats
View detailed bundle stats
desktop-client
Total
Changeset
src/hooks/useDragDrop.tsxsrc/components/transactions/TransactionList.tsxsrc/components/transactions/TransactionsTable.tsxsrc/components/sort.tsxhome/runner/work/actual/actual/packages/loot-core/src/shared/transactions.tssrc/components/accounts/Account.tsxnode_modules/react-dnd/dist/hooks/useDrop/useDrop.jsnode_modules/@use-gesture/react/dist/use-gesture-react.esm.jssrc/components/reports/reports/Calendar.tsxsrc/components/mobile/MobileNavTabs.tsxView detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
Smaller
Unchanged
loot-core
Total
Changeset
home/runner/work/actual/actual/packages/loot-core/src/server/db/sort.tshome/runner/work/actual/actual/packages/loot-core/src/server/transactions/app.tshome/runner/work/actual/actual/packages/loot-core/src/server/db/index.tshome/runner/work/actual/actual/packages/loot-core/src/shared/transactions.tshome/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.tsView detailed bundle breakdown
Added
Removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
No assets were unchanged
api
Total
Changeset
home/runner/work/actual/actual/packages/loot-core/src/server/db/sort.tshome/runner/work/actual/actual/packages/loot-core/src/server/transactions/app.tshome/runner/work/actual/actual/packages/loot-core/src/server/db/index.tshome/runner/work/actual/actual/packages/loot-core/src/shared/transactions.tshome/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.tsView detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
Smaller
No assets were smaller
Unchanged
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.