github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-09 10:45:04 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6594] [MERGED] Bug/5679 payee filter #48444

New Issue
Closed
opened 2026-04-26 10:22:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 10:22:43 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6594
Author: @RMcGhee
Created: 1/7/2026
Status: ✅ Merged
Merged: 1/10/2026
Merged by: @MikesGlitch

Base: master ← Head: bug/5679-payee-filter

📝 Commits (8)

  • 92bbbf9 Fix filters, added tests
  • df5d27f Added release notes
  • 19ec2f5 [autofix.ci] apply automated fixes
  • 8cf833f Merge branch 'master' into bug/5679-payee-filter
  • df541c6 Merge branch 'master' into bug/5679-payee-filter
  • 2682c07 Fix missing awaits in test, use placeholder locator
  • a9746b4 Added release notes file
  • 9f314bf Update VRT screenshots

📊 Changes

12 files changed (+84 additions, -2 deletions)

View changed files

📝 packages/desktop-client/e2e/transactions.test.ts (+72 -0)
➕ packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-1-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-2-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-3-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-4-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-5-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-6-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-7-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-8-chromium-linux.png (+0 -0)
➕ packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-9-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/filters/FiltersMenu.tsx (+6 -2)
➕ upcoming-release-notes/6594.md (+6 -0)

📄 Description

Fixes issue #5679.

Before the fix, the payee filter was broken in that it allows users to try to filter by contains, does not contain, or matches, but the PayeeFilter does not support these types of filters. See the demo for the incorrect behavior:

https://github.com/user-attachments/assets/e2341a1b-86b4-4310-8dcb-f1cf95f8a489

After the fix, when a filter NOT associated with a distinct payee id is selected (contains, does not contain, matches), the payee filter will now instead use GenericInput, which does support this kind of filtering. See the demo for the new correct behavior:

https://github.com/user-attachments/assets/dcbed2f5-6ce8-4e40-b4bd-117d39b52786

This addresses user issues by allowing for expected behavior, that apparently used to work before the new payee filter was created. This does so without creating a new component, or modifying how payee filter works.

Tests were also created for the payee filter, including the default "is" filter.

EDIT - Also since I didn't explicitly mention it but the bot tagged the possibility, no AI was used in my code. The bot's suggestion for better release notes were used though.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6594 **Author:** [@RMcGhee](https://github.com/RMcGhee) **Created:** 1/7/2026 **Status:** ✅ Merged **Merged:** 1/10/2026 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `bug/5679-payee-filter` --- ### 📝 Commits (8) - [`92bbbf9`](https://github.com/actualbudget/actual/commit/92bbbf9fa63afc183358b1f2289fc7ed35871dcd) Fix filters, added tests - [`df5d27f`](https://github.com/actualbudget/actual/commit/df5d27f3f5184ddf51fca8e02245a058a4ba35d8) Added release notes - [`19ec2f5`](https://github.com/actualbudget/actual/commit/19ec2f5297a961ca72ae238f01eb415e5748395a) [autofix.ci] apply automated fixes - [`8cf833f`](https://github.com/actualbudget/actual/commit/8cf833fa12060b85be039e3568805bf3300a5068) Merge branch 'master' into bug/5679-payee-filter - [`df541c6`](https://github.com/actualbudget/actual/commit/df541c6497a72e55e94a0c88f2e9238a33b6b648) Merge branch 'master' into bug/5679-payee-filter - [`2682c07`](https://github.com/actualbudget/actual/commit/2682c0703aa277eaa089c2ab3486eb876c96033d) Fix missing awaits in test, use placeholder locator - [`a9746b4`](https://github.com/actualbudget/actual/commit/a9746b40c416eefba76996d95ca7517a139e89eb) Added release notes file - [`9f314bf`](https://github.com/actualbudget/actual/commit/9f314bf77088d84ce1a208b269d5fef802614410) Update VRT screenshots ### 📊 Changes **12 files changed** (+84 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/transactions.test.ts` (+72 -0) ➕ `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-1-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-2-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-3-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-4-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-5-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-6-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-7-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-8-chromium-linux.png` (+0 -0) ➕ `packages/desktop-client/e2e/transactions.test.ts-snapshots/Transactions-filters-transactions-by-payee-9-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.tsx` (+6 -2) ➕ `upcoming-release-notes/6594.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> Fixes issue #5679. Before the fix, the payee filter was broken in that it allows users to try to filter by contains, does not contain, or matches, but the PayeeFilter does not support these types of filters. See the demo for the incorrect behavior: https://github.com/user-attachments/assets/e2341a1b-86b4-4310-8dcb-f1cf95f8a489 After the fix, when a filter NOT associated with a distinct payee id is selected (contains, does not contain, matches), the payee filter will now instead use GenericInput, which does support this kind of filtering. See the demo for the new correct behavior: https://github.com/user-attachments/assets/dcbed2f5-6ce8-4e40-b4bd-117d39b52786 This addresses user issues by allowing for expected behavior, that apparently used to work before the new payee filter was created. This does so without creating a new component, or modifying how payee filter works. Tests were also created for the payee filter, including the default "is" filter. EDIT - Also since I didn't explicitly mention it but the bot tagged the possibility, no AI was used in my code. The bot's suggestion for better release notes were used though. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 10:22:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#48444