github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-17 08:32:41 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #3413] [MERGED] Final PR for react-aria-components Modal migration #4842

New Issue
Closed
opened 2026-02-28 21:02:05 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:02:05 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3413
Author: @joel-jeremy
Created: 9/10/2024
Status: ✅ Merged
Merged: 9/11/2024
Merged by: @joel-jeremy

Base: master ← Head: modal2-final

📝 Commits (9)

📊 Changes

86 files changed (+1513 additions, -2083 deletions)

View changed files

📝 packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-6-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/App.tsx (+60 -60)
📝 packages/desktop-client/src/components/AppBackground.tsx (+6 -7)
📝 packages/desktop-client/src/components/FatalError.tsx (+3 -2)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+94 -128)
📝 packages/desktop-client/src/components/Modals.tsx (+62 -44)
📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.jsx (+6 -6)
📝 packages/desktop-client/src/components/common/Modal.tsx (+197 -210)
➖ packages/desktop-client/src/components/common/Modal2.tsx (+0 -468)
📝 packages/desktop-client/src/components/filters/ConditionsOpMenu.tsx (+1 -1)
📝 packages/desktop-client/src/components/gocardless/GoCardlessLink.tsx (+10 -12)
📝 packages/desktop-client/src/components/manager/BudgetList.tsx (+5 -5)
➖ packages/desktop-client/src/components/manager/DeleteFile.tsx (+0 -141)
➖ packages/desktop-client/src/components/manager/Import.tsx (+0 -89)
➖ packages/desktop-client/src/components/manager/ImportActual.tsx (+0 -99)

...and 66 more files

📄 Description

Please bear with me on this large PR. Changes made:

  1. Delete old Modal component and renamed Modal2 to Modal
  2. Moved all modals to a single Modals components instead of 2 separate
  3. Fixed some quirks on loading screen
  4. Made Management app full screen
  5. Renamed ModalCloseButton onClick to onPress to match Button2 naming
  6. Centralized Providers on top level (App.tsx) since Modals depend on some of the providers

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3413 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 9/10/2024 **Status:** ✅ Merged **Merged:** 9/11/2024 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `modal2-final` --- ### 📝 Commits (9) - [`bab64ed`](https://github.com/actualbudget/actual/commit/bab64edb3973528910b78c0900cdf8d537f8a608) Final PR for react-aria-components Modal migration - [`04237c6`](https://github.com/actualbudget/actual/commit/04237c649059d1b69362d255f318e3d823a22084) Complete manager modals migration - [`7b32251`](https://github.com/actualbudget/actual/commit/7b322515717680eb755a3af6f8dad2f46f988fe6) Release notes - [`da3b20a`](https://github.com/actualbudget/actual/commit/da3b20a82df4fb71abff7e94dd7eb57238e7eb21) fix lint - [`ca23107`](https://github.com/actualbudget/actual/commit/ca2310766d5650260d0d89d6a8ab42ba8890e015) Apps full height - [`ff1fef2`](https://github.com/actualbudget/actual/commit/ff1fef25bc1ee5f910b7d282fa73064cabd0fa58) Fix lint error - [`5f94ae4`](https://github.com/actualbudget/actual/commit/5f94ae480bf8f6fbe5eb8442a786d0b46c45121d) VRT - [`6b33488`](https://github.com/actualbudget/actual/commit/6b33488818db1c9091551170370ac4c7162fb042) Centralize providers - [`292d34d`](https://github.com/actualbudget/actual/commit/292d34d046780ab7ca76afa776b87e579e0fadb4) Feedback ### 📊 Changes **86 files changed** (+1513 additions, -2083 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/onboarding.test.js-snapshots/Onboarding-checks-the-page-visuals-6-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/App.tsx` (+60 -60) 📝 `packages/desktop-client/src/components/AppBackground.tsx` (+6 -7) 📝 `packages/desktop-client/src/components/FatalError.tsx` (+3 -2) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+94 -128) 📝 `packages/desktop-client/src/components/Modals.tsx` (+62 -44) 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.jsx` (+6 -6) 📝 `packages/desktop-client/src/components/common/Modal.tsx` (+197 -210) ➖ `packages/desktop-client/src/components/common/Modal2.tsx` (+0 -468) 📝 `packages/desktop-client/src/components/filters/ConditionsOpMenu.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/gocardless/GoCardlessLink.tsx` (+10 -12) 📝 `packages/desktop-client/src/components/manager/BudgetList.tsx` (+5 -5) ➖ `packages/desktop-client/src/components/manager/DeleteFile.tsx` (+0 -141) ➖ `packages/desktop-client/src/components/manager/Import.tsx` (+0 -89) ➖ `packages/desktop-client/src/components/manager/ImportActual.tsx` (+0 -99) _...and 66 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Please bear with me on this large PR. Changes made: 1. Delete old `Modal` component and renamed `Modal2` to `Modal` 2. Moved all modals to a single `Modals` components instead of 2 separate 3. Fixed some quirks on loading screen 4. Made Management app full screen 5. Renamed ModalCloseButton onClick to onPress to match `Button2` naming 6. Centralized Providers on top level (App.tsx) since Modals depend on some of the providers --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:02:05 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4842
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?