github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3412] [MERGED] Fix Issue 3331, sort favorite payees before other frequently used payees #4841

New Issue
Closed
opened 2026-02-28 21:02:03 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:02:03 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3412
Author: @qedi-r
Created: 9/9/2024
Status: ✅ Merged
Merged: 9/25/2024
Merged by: @youngcw

Base: master ← Head: issue-3331

📝 Commits (10+)

  • 430d8ec add tests for payee dropdown bug on new transactions on all accounts page
  • 5238e57 add tests for bugfixes
  • 05a708e sort favorite payees first, add tests for PayeeAutocomplete.getPayeeSuggestions
  • c7d74e7 lint and release notes
  • 8ec2cc8 fix release note number
  • 75421bb lint fixes
  • e2477a4 add missing file in previous lint fix
  • 3d4f83f fix typecheck and linting errors
  • 34e9bf4 Merge branch 'master' into issue-3331
  • 43cf4d3 Merge branch 'master' into issue-3331

📊 Changes

5 files changed (+400 additions, -21 deletions)

View changed files

➕ packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.test.tsx (+239 -0)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (+20 -13)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx (+108 -5)
📝 packages/loot-core/src/mocks/index.ts (+27 -3)
➕ upcoming-release-notes/3412.md (+6 -0)

📄 Description

This fixes #3331. It changes the Suggested Payees section from

  • Alice
    Bob
  • Charlie
    Dave
    Ernie

to

  • Alice
  • Charlie
    Bob
    Dave
    Ernie

in cases where there are fewer than five favorites in the system.

It also adds tests, I could separate the tests from the bugfix, if people want to discuss the tests more.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3412 **Author:** [@qedi-r](https://github.com/qedi-r) **Created:** 9/9/2024 **Status:** ✅ Merged **Merged:** 9/25/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `issue-3331` --- ### 📝 Commits (10+) - [`430d8ec`](https://github.com/actualbudget/actual/commit/430d8ec4833d6c6da214ad02642c03fe4cac8713) add tests for payee dropdown bug on new transactions on all accounts page - [`5238e57`](https://github.com/actualbudget/actual/commit/5238e57c4cb771fdf7bfb3d1eb4406bd3cc7c86d) add tests for bugfixes - [`05a708e`](https://github.com/actualbudget/actual/commit/05a708e8fb9d59db3f23543feb3523a8bc594094) sort favorite payees first, add tests for PayeeAutocomplete.getPayeeSuggestions - [`c7d74e7`](https://github.com/actualbudget/actual/commit/c7d74e7c171f0eb62388db7553a397192d58249c) lint and release notes - [`8ec2cc8`](https://github.com/actualbudget/actual/commit/8ec2cc8cea14e8c9e6af537cef23be909e46ea33) fix release note number - [`75421bb`](https://github.com/actualbudget/actual/commit/75421bb3b7e0680139e7a25fe2dc93f7b298925c) lint fixes - [`e2477a4`](https://github.com/actualbudget/actual/commit/e2477a47b632b023540eb6bce2526d1c55015d36) add missing file in previous lint fix - [`3d4f83f`](https://github.com/actualbudget/actual/commit/3d4f83f0c8f572084b57a94da8d8e1c615a82023) fix typecheck and linting errors - [`34e9bf4`](https://github.com/actualbudget/actual/commit/34e9bf4bcaf034e7f8ec4d0304c61d1ff25a2dd9) Merge branch 'master' into issue-3331 - [`43cf4d3`](https://github.com/actualbudget/actual/commit/43cf4d3d3fb651d8cdebbce5916f82ac6791b627) Merge branch 'master' into issue-3331 ### 📊 Changes **5 files changed** (+400 additions, -21 deletions) <details> <summary>View changed files</summary> ➕ `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.test.tsx` (+239 -0) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx` (+20 -13) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx` (+108 -5) 📝 `packages/loot-core/src/mocks/index.ts` (+27 -3) ➕ `upcoming-release-notes/3412.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> This fixes #3331. It changes the Suggested Payees section from * Alice Bob * Charlie Dave Ernie to * Alice * Charlie Bob Dave Ernie in cases where there are fewer than five favorites in the system. It also adds tests, I could separate the tests from the bugfix, if people want to discuss the tests more. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:02:03 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4841
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?