github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 04:02:38 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3410] [MERGED] ♻️ (synced-prefs) moving budgetType pref back to MetadataPrefs #4839

New Issue
Closed
opened 2026-02-28 21:02:01 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:02:01 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3410
Author: @MatissJanis
Created: 9/9/2024
Status: ✅ Merged
Merged: 9/10/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/synced-prefs-5

📝 Commits (2)

  • 17f0652 ♻️ (synced-prefs) moving budgetType pref back to MetadataPrefs (temporary)
  • acd1e4c Release notes

📊 Changes

10 files changed (+29 additions, -22 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+2 -2)
📝 packages/desktop-client/src/components/budget/index.tsx (+2 -2)
📝 packages/desktop-client/src/components/budget/util.ts (+4 -4)
📝 packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx (+3 -3)
📝 packages/desktop-client/src/components/mobile/budget/index.tsx (+2 -1)
📝 packages/desktop-client/src/components/settings/BudgetTypeSettings.tsx (+2 -2)
📝 packages/desktop-client/src/components/settings/Experimental.tsx (+2 -1)
📝 packages/loot-core/src/server/prefs.ts (+4 -6)
📝 packages/loot-core/src/types/prefs.d.ts (+2 -1)
➕ upcoming-release-notes/3410.md (+6 -0)

📄 Description

This PR has only type-level changes. Functionality here is.. unchanged. Since all the useLocalPref / useMetadataPref / useSyncedPref use the same underlying logic (this will change in the near future).

Moving budgetType to SyncedPrefs will be pretty complicated. So I am moving it back to MetadataPrefs as a temporary measure in order to unblock the other SyncedPref move to DB.

I will return back to budgetType later in a subsequent PR.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3410 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 9/9/2024 **Status:** ✅ Merged **Merged:** 9/10/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/synced-prefs-5` --- ### 📝 Commits (2) - [`17f0652`](https://github.com/actualbudget/actual/commit/17f0652d890a3c217267df3a34d0e797054a4d91) :recycle: (synced-prefs) moving budgetType pref back to MetadataPrefs (temporary) - [`acd1e4c`](https://github.com/actualbudget/actual/commit/acd1e4c17991a02b22420b45a82e9e62cd45818e) Release notes ### 📊 Changes **10 files changed** (+29 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/budget/index.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/budget/util.ts` (+4 -4) 📝 `packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx` (+3 -3) 📝 `packages/desktop-client/src/components/mobile/budget/index.tsx` (+2 -1) 📝 `packages/desktop-client/src/components/settings/BudgetTypeSettings.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/settings/Experimental.tsx` (+2 -1) 📝 `packages/loot-core/src/server/prefs.ts` (+4 -6) 📝 `packages/loot-core/src/types/prefs.d.ts` (+2 -1) ➕ `upcoming-release-notes/3410.md` (+6 -0) </details> ### 📄 Description **This PR has only type-level changes. Functionality here is.. unchanged. Since all the `useLocalPref` / `useMetadataPref` / `useSyncedPref` use the same underlying logic (this will change in the near future).** Moving `budgetType` to `SyncedPrefs` will be pretty complicated. So I am moving it back to `MetadataPrefs` as a temporary measure in order to unblock the other `SyncedPref` move to DB. I will return back to `budgetType` later in a subsequent PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:02:01 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4839
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?