github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-11 09:38:37 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[PR #6454] [MERGED] lint: actual/typography disallow using curly quotes #48357

New Issue
Closed
opened 2026-04-26 10:17:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 10:17:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6454
Author: @MatissJanis
Created: 12/20/2025
Status: ✅ Merged
Merged: 12/20/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/typography-rule-auto-fix

📝 Commits (10+)

  • f62825c Update typography rule to disallow curly quotes with auto-fix
  • 46b4d17 Fix quotation marks in error messages and formatting strings across multiple files
  • 349c728 Standardize quotation marks across multiple files
  • 0f65ec0 Standardize month formatting across multiple components
  • f870874 Refactor typography rule to enhance curly quote handling
  • abf2763 Refactor typography handling and update tests for curly quotes
  • 15dbb78 Update VRT screenshots
  • 942937b Merge branch 'matiss/typography-rule-auto-fix' of github.com:actualbudget/actual into matiss/typography-rule-auto-fix
  • b49857e Fix: Correct typo in budget cell notification message
  • 93dbce2 Update VRT screenshots

📊 Changes

220 files changed (+550 additions, -524 deletions)

View changed files

📝 .github/ISSUE_TEMPLATE/bug-report.yml (+1 -1)
📝 .github/ISSUE_TEMPLATE/feature-request.yml (+4 -4)
📝 .github/workflows/i18n-string-extract-master.yml (+1 -1)
📝 .github/workflows/issues-close-feature-requests.yml (+1 -1)
📝 .gitignore (+2 -0)
📝 bin/release-note-generator.ts (+0 -1)
📝 eslint.config.mjs (+1 -10)
📝 packages/api/tsconfig.dist.json (+1 -1)
📝 packages/ci-actions/bin/bundle-stats-comment.mjs (+14 -14)
📝 packages/ci-actions/bin/update-bundle-stats-comment.mjs (+6 -6)
📝 packages/ci-actions/src/versions/get-next-package-version.js (+1 -1)
📝 packages/component-library/src/ColorPicker.tsx (+0 -1)
📝 packages/component-library/src/Toggle.tsx (+0 -1)
📝 packages/component-library/src/styles.ts (+0 -1)
📝 packages/crdt/README.md (+2 -2)
📝 packages/crdt/tsconfig.dist.json (+1 -1)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking--14404-in-the-page-header-opens-the-month-menu-modal-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking--bed18-in-the-page-header-opens-the-month-menu-modal-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking--ceb3a-in-the-page-header-opens-the-month-menu-modal-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking-the-budgeted-cell-opens-the-budget-menu-modal-1-chromium-linux.png (+0 -0)

...and 80 more files

📄 Description

  • Reverse typography rule to detect and flag curly quotes instead of straight quotes
  • Add auto-fixer that converts curly quotes to straight quotes
  • Fix auto-fixer to properly escape quotes when they match string delimiters

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6454 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 12/20/2025 **Status:** ✅ Merged **Merged:** 12/20/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/typography-rule-auto-fix` --- ### 📝 Commits (10+) - [`f62825c`](https://github.com/actualbudget/actual/commit/f62825c710efcbf9e90da641e7f752568c69c539) Update typography rule to disallow curly quotes with auto-fix - [`46b4d17`](https://github.com/actualbudget/actual/commit/46b4d178ac9d500bcd55fe2c167d5a657db59051) Fix quotation marks in error messages and formatting strings across multiple files - [`349c728`](https://github.com/actualbudget/actual/commit/349c728d1c70b7dddaf649006ea97a72516fa2e6) Standardize quotation marks across multiple files - [`0f65ec0`](https://github.com/actualbudget/actual/commit/0f65ec08a00fe696af973f24d14a261868a87142) Standardize month formatting across multiple components - [`f870874`](https://github.com/actualbudget/actual/commit/f870874f7bd3c10acaed4f61d41b7decbff79547) Refactor typography rule to enhance curly quote handling - [`abf2763`](https://github.com/actualbudget/actual/commit/abf276315490c34144dbf14e93288b0ab739e80e) Refactor typography handling and update tests for curly quotes - [`15dbb78`](https://github.com/actualbudget/actual/commit/15dbb78bbe101aaa01bfaf6023bac2685b572b55) Update VRT screenshots - [`942937b`](https://github.com/actualbudget/actual/commit/942937b5698603e3c5ad9fb7d833ec24c49ec9d6) Merge branch 'matiss/typography-rule-auto-fix' of github.com:actualbudget/actual into matiss/typography-rule-auto-fix - [`b49857e`](https://github.com/actualbudget/actual/commit/b49857e24ffe6b0c6b741dbead0e7a405d9dca24) Fix: Correct typo in budget cell notification message - [`93dbce2`](https://github.com/actualbudget/actual/commit/93dbce2f2e63181b10cddb1c5d44fae5f1a1b072) Update VRT screenshots ### 📊 Changes **220 files changed** (+550 additions, -524 deletions) <details> <summary>View changed files</summary> 📝 `.github/ISSUE_TEMPLATE/bug-report.yml` (+1 -1) 📝 `.github/ISSUE_TEMPLATE/feature-request.yml` (+4 -4) 📝 `.github/workflows/i18n-string-extract-master.yml` (+1 -1) 📝 `.github/workflows/issues-close-feature-requests.yml` (+1 -1) 📝 `.gitignore` (+2 -0) 📝 `bin/release-note-generator.ts` (+0 -1) 📝 `eslint.config.mjs` (+1 -10) 📝 `packages/api/tsconfig.dist.json` (+1 -1) 📝 `packages/ci-actions/bin/bundle-stats-comment.mjs` (+14 -14) 📝 `packages/ci-actions/bin/update-bundle-stats-comment.mjs` (+6 -6) 📝 `packages/ci-actions/src/versions/get-next-package-version.js` (+1 -1) 📝 `packages/component-library/src/ColorPicker.tsx` (+0 -1) 📝 `packages/component-library/src/Toggle.tsx` (+0 -1) 📝 `packages/component-library/src/styles.ts` (+0 -1) 📝 `packages/crdt/README.md` (+2 -2) 📝 `packages/crdt/tsconfig.dist.json` (+1 -1) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking--14404-in-the-page-header-opens-the-month-menu-modal-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking--bed18-in-the-page-header-opens-the-month-menu-modal-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking--ceb3a-in-the-page-header-opens-the-month-menu-modal-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.mobile.test.ts-snapshots/Mobile-Budget-Envelope-checks-that-clicking-the-budgeted-cell-opens-the-budget-menu-modal-1-chromium-linux.png` (+0 -0) _...and 80 more files_ </details> ### 📄 Description - Reverse typography rule to detect and flag curly quotes instead of straight quotes - Add auto-fixer that converts curly quotes to straight quotes - Fix auto-fixer to properly escape quotes when they match string delimiters --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 10:17:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#48357
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?