github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6419] [CLOSED] Bugfix - Add "E" to KeyBoardShortcutModal.tsx & rearrange key descriptions to follow doc - follows #6416 #48330

New Issue
Closed
opened 2026-04-26 10:16:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 10:16:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6419
Author: @Juulz
Created: 12/15/2025
Status: ❌ Closed

Base: master ← Head: Keyboard-shortcuts-modal

📝 Commits (10+)

  • 8f757b8 Update KeyboardShortcutModal.tsx
  • 9de6f7f Create 6419.md
  • d50e189 Merge branch 'master' into Keyboard-shortcuts-modal
  • bf6c268 Update KeyboardShortcutModal.tsx
  • 086f46f [autofix.ci] apply automated fixes
  • 43a96f4 Update KeyboardShortcutModal.tsx
  • 4b1c6a1 Update help-menu.test.ts
  • a716cf1 Update KeyboardShortcutModal.tsx
  • 92ed9c5 Merge branch 'master' into Keyboard-shortcuts-modal
  • e1c9d04 Update VRT screenshots

📊 Changes

24 files changed (+130 additions, -88 deletions)

View changed files

📝 packages/desktop-client/e2e/help-menu.test.ts (+1 -1)
📝 packages/desktop-client/e2e/help-menu.test.ts-snapshots/Help-menu-Check-the-keyboard-shortcuts-modal-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/help-menu.test.ts-snapshots/Help-menu-Check-the-keyboard-shortcuts-modal-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/help-menu.test.ts-snapshots/Help-menu-Check-the-keyboard-shortcuts-modal-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/help-menu.test.ts-snapshots/Help-menu-Check-the-keyboard-shortcuts-modal-visuals-7-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/help-menu.test.ts-snapshots/Help-menu-Check-the-keyboard-shortcuts-modal-visuals-8-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/help-menu.test.ts-snapshots/Help-menu-Check-the-keyboard-shortcuts-modal-visuals-9-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-6-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-6-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-7-chromium-linux.png (+0 -0)

...and 4 more files

📄 Description

Fixed KeyBoardShortcutModal.tsx:

  • Changed "General" to "Global" due to test fail. Changed test from "General" to "Global".
  • Added sections to break apart Account shortcuts. 27 is too many to find what you are looking for.
  • Added one contextual shortcuts to two sections.. "F" as "Open filter dropdown to "Account page general" and as "Filter to the selected transactions" to "Account transaction management"
  • "T" is "Add transaction" to "Account page general"
  • "E" is "Set date for selected transactions" to "Account transaction management"
  • Rearranged shortcuts to match the order in PR #6417

Found "T" description mismatch when working on Tips & Tricks doc. Fixed in #6416

Note

Renames "General" to "Global", restructures account keyboard shortcuts into multiple contextual categories (including correct "T"/"F" mappings) and adds budget navigation; updates e2e test and release notes.

  • Keyboard shortcuts (packages/desktop-client/src/components/modals/KeyboardShortcutModal.tsx):
    • Rename General → Global (id: general → global).
    • Split account shortcuts into categories: account-page-general, account-transaction-selection, account-transaction-editing, account-transaction-management.
    • Add budget page navigation: Enter (down) and Shift+Enter (up).
    • Contextualize mappings:
      • T: Add new transaction when no transactions are selected (general) and Set date for selected transactions (management).
      • F: Show filter dropdown when no transactions are selected (general) and Filter to the selected transactions (management).
    • Reorder/retitle items for clarity (no behavioral code changes shown beyond mapping/organization).
  • Tests (packages/desktop-client/e2e/help-menu.test.ts): Update expectation from General to Global.
  • Release notes (upcoming-release-notes/6419.md): Document corrected T behavior description.

Written by Cursor Bugbot for commit f14f3d6486. This will update automatically on new commits. Configure here.

Summary by CodeRabbit

  • New Features

    • Added multiple new keyboard shortcuts for transaction management, including selection, editing, and bulk operations on account pages.
    • New shortcuts added for navigating budget page categories.

  • Refactor

    • Reorganized keyboard shortcuts into new structured categories for improved navigation and command discoverability.
    • Renamed "General" shortcut category to "Global".

✏️ Tip: You can customize this high-level summary in your review settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6419 **Author:** [@Juulz](https://github.com/Juulz) **Created:** 12/15/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `Keyboard-shortcuts-modal` --- ### 📝 Commits (10+) - [`8f757b8`](https://github.com/actualbudget/actual/commit/8f757b81078746f857879baff004b0b4d8a7cb41) Update KeyboardShortcutModal.tsx - [`9de6f7f`](https://github.com/actualbudget/actual/commit/9de6f7fc7ef8f910f3fb692b1de15d498e57d813) Create 6419.md - [`d50e189`](https://github.com/actualbudget/actual/commit/d50e18914a54a31c1d4900609d1ed73c60272f79) Merge branch 'master' into Keyboard-shortcuts-modal - [`bf6c268`](https://github.com/actualbudget/actual/commit/bf6c268398e89232b1ad7b8cd0eac5443d1e7261) Update KeyboardShortcutModal.tsx - [`086f46f`](https://github.com/actualbudget/actual/commit/086f46f04d5c4988387f368f7148021561d213a8) [autofix.ci] apply automated fixes - [`43a96f4`](https://github.com/actualbudget/actual/commit/43a96f4c23077fe38d375b607dc5113c3c9366aa) Update KeyboardShortcutModal.tsx - [`4b1c6a1`](https://github.com/actualbudget/actual/commit/4b1c6a1367d7a8291217ae3360995bd755deb5e1) Update help-menu.test.ts - [`a716cf1`](https://github.com/actualbudget/actual/commit/a716cf1f804ba1b86b0e827d7a03eea1a7145536) Update KeyboardShortcutModal.tsx - [`92ed9c5`](https://github.com/actualbudget/actual/commit/92ed9c53c75bf114ed661b7400015820aed5af01) Merge branch 'master' into Keyboard-shortcuts-modal - [`e1c9d04`](https://github.com/actualbudget/actual/commit/e1c9d04578a9954012270acc8263d221c1114bba) Update VRT screenshots ### 📊 Changes **24 files changed** (+130 additions, -88 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/help-menu.test.ts` (+1 -1) 📝 `packages/desktop-client/e2e/help-menu.test.ts-snapshots/Help-menu-Check-the-keyboard-shortcuts-modal-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/help-menu.test.ts-snapshots/Help-menu-Check-the-keyboard-shortcuts-modal-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/help-menu.test.ts-snapshots/Help-menu-Check-the-keyboard-shortcuts-modal-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/help-menu.test.ts-snapshots/Help-menu-Check-the-keyboard-shortcuts-modal-visuals-7-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/help-menu.test.ts-snapshots/Help-menu-Check-the-keyboard-shortcuts-modal-visuals-8-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/help-menu.test.ts-snapshots/Help-menu-Check-the-keyboard-shortcuts-modal-visuals-9-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-checks-the-page-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/payees.mobile.test.ts-snapshots/Mobile-Payees-search-functionality-works-correctly-6-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-6-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/schedules.test.ts-snapshots/Schedules-creates-a-new-schedule-posts-the-transaction-and-later-completes-it-7-chromium-linux.png` (+0 -0) _...and 4 more files_ </details> ### 📄 Description Fixed KeyBoardShortcutModal.tsx: - Changed "General" to "Global" due to test fail. Changed test from "General" to "Global". - Added sections to break apart Account shortcuts. 27 is too many to find what you are looking for. - Added one contextual shortcuts to two sections.. "F" as "Open filter dropdown to "Account page general" and as "Filter to the selected transactions" to "Account transaction management" - "T" is "Add transaction" to "Account page general" - "E" is "Set date for selected transactions" to "Account transaction management" - Rearranged shortcuts to match the order in PR #6417 Found "T" description mismatch when working on Tips & Tricks doc. Fixed in #6416 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Renames "General" to "Global", restructures account keyboard shortcuts into multiple contextual categories (including correct "T"/"F" mappings) and adds budget navigation; updates e2e test and release notes. > > - **Keyboard shortcuts (`packages/desktop-client/src/components/modals/KeyboardShortcutModal.tsx`)**: > - Rename `General` → `Global` (`id: general` → `global`). > - Split account shortcuts into categories: `account-page-general`, `account-transaction-selection`, `account-transaction-editing`, `account-transaction-management`. > - Add budget page navigation: `Enter` (down) and `Shift+Enter` (up). > - Contextualize mappings: > - `T`: `Add new transaction when no transactions are selected` (general) and `Set date for selected transactions` (management). > - `F`: `Show filter dropdown when no transactions are selected` (general) and `Filter to the selected transactions` (management). > - Reorder/retitle items for clarity (no behavioral code changes shown beyond mapping/organization). > - **Tests (`packages/desktop-client/e2e/help-menu.test.ts`)**: Update expectation from `General` to `Global`. > - **Release notes (`upcoming-release-notes/6419.md`)**: Document corrected `T` behavior description. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit f14f3d64869dc7e422fefe898e9e8c22a79087e1. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added multiple new keyboard shortcuts for transaction management, including selection, editing, and bulk operations on account pages. * New shortcuts added for navigating budget page categories. * **Refactor** * Reorganized keyboard shortcuts into new structured categories for improved navigation and command discoverability. * Renamed "General" shortcut category to "Global". <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 10:16:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#48330
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?