[PR #3397] [MERGED] ♻️ (synced-prefs) refactor number formatter away from redux #4831

Closed
opened 2026-02-28 21:01:54 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3397
Author: @MatissJanis
Created: 9/8/2024
Status: Merged
Merged: 9/9/2024
Merged by: @MatissJanis

Base: masterHead: matiss/synced-prefs-3


📝 Commits (7)

  • 43004f1 ♻️ (synced-prefs) refactor some SyncedPrefs to string type
  • 455f758 Release notes
  • afbb9e8 Fix linter
  • c77d9cf Convert the other prefs too
  • a870184 Simplified usePrivacyMode
  • 42b75e0 ♻️ (synced-prefs) refactor number formatter away from redux
  • a8200b7 Merge branch 'master' into matiss/synced-prefs-3

📊 Changes

8 files changed (+49 additions, -73 deletions)

View changed files

📝 packages/desktop-client/src/components/spreadsheet/useFormat.ts (+29 -7)
📝 packages/desktop-client/src/hooks/useDateFormat.ts (+3 -4)
📝 packages/desktop-client/src/hooks/useFeatureFlag.ts (+6 -9)
📝 packages/loot-core/src/client/reducers/prefs.ts (+0 -25)
packages/loot-core/src/client/selectors.ts (+0 -18)
📝 packages/loot-core/src/client/state-types/prefs.d.ts (+4 -9)
📝 packages/loot-core/src/shared/util.ts (+1 -1)
upcoming-release-notes/3397.md (+6 -0)

📄 Description

Depends on https://github.com/actualbudget/actual/pull/3395


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3397 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 9/8/2024 **Status:** ✅ Merged **Merged:** 9/9/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/synced-prefs-3` --- ### 📝 Commits (7) - [`43004f1`](https://github.com/actualbudget/actual/commit/43004f1eebfe76ae8bacb37e1234a6fc64fa2e25) :recycle: (synced-prefs) refactor some SyncedPrefs to string type - [`455f758`](https://github.com/actualbudget/actual/commit/455f758960b5c0338433d4f205945745d1714623) Release notes - [`afbb9e8`](https://github.com/actualbudget/actual/commit/afbb9e890b7a9b41eb17cca63af04bfd014d09aa) Fix linter - [`c77d9cf`](https://github.com/actualbudget/actual/commit/c77d9cfbb52a461fed209d91dae1757f0bd75169) Convert the other prefs too - [`a870184`](https://github.com/actualbudget/actual/commit/a870184f0dbdf82082085b4a72ef1dea378dd88f) Simplified usePrivacyMode - [`42b75e0`](https://github.com/actualbudget/actual/commit/42b75e03da6fea7f185379f1a19696336939b2cc) :recycle: (synced-prefs) refactor number formatter away from redux - [`a8200b7`](https://github.com/actualbudget/actual/commit/a8200b76b254c49bad25b773fbc8f5514260fc0f) Merge branch 'master' into matiss/synced-prefs-3 ### 📊 Changes **8 files changed** (+49 additions, -73 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/spreadsheet/useFormat.ts` (+29 -7) 📝 `packages/desktop-client/src/hooks/useDateFormat.ts` (+3 -4) 📝 `packages/desktop-client/src/hooks/useFeatureFlag.ts` (+6 -9) 📝 `packages/loot-core/src/client/reducers/prefs.ts` (+0 -25) ➖ `packages/loot-core/src/client/selectors.ts` (+0 -18) 📝 `packages/loot-core/src/client/state-types/prefs.d.ts` (+4 -9) 📝 `packages/loot-core/src/shared/util.ts` (+1 -1) ➕ `upcoming-release-notes/3397.md` (+6 -0) </details> ### 📄 Description Depends on https://github.com/actualbudget/actual/pull/3395 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:01:54 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4831