github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #6389] [CLOSED] Docker edge build retries #48304

New Issue
Closed
opened 2026-04-26 10:14:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 10:14:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6389
Author: @MatissJanis
Created: 12/13/2025
Status: ❌ Closed

Base: matiss/fix-playwright-browser-preload ← Head: cursor/docker-edge-build-retries-f892

📝 Commits (1)

  • 9e62664 Refactor: Add retry logic to Docker build actions

📊 Changes

1 file changed (+29 additions, -14 deletions)

View changed files

📝 .github/workflows/docker-edge.yml (+29 -14)

📄 Description

Add retries to Docker edge workflow jobs

This PR enhances the reliability of the Docker edge workflow by adding retry logic to critical build and push steps.

Why:
To mitigate transient failures that can occur during Docker image building and pushing, such as network issues or registry timeouts. This makes the CI/CD pipeline more robust and reduces the number of flaky runs.

What:

  • Introduced fail-fast: false to the matrix strategy, ensuring all build variants attempt to complete.
  • Implemented nick-fields/retry for the "Build image for testing" and "Build and push images" steps, configured for 3 attempts with appropriate timeouts.
  • Converted the docker/build-push-action to raw docker buildx build commands to integrate with the retry action, including proper handling of Docker metadata tags.

Open in Cursor Open in Web

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6389 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 12/13/2025 **Status:** ❌ Closed **Base:** `matiss/fix-playwright-browser-preload` ← **Head:** `cursor/docker-edge-build-retries-f892` --- ### 📝 Commits (1) - [`9e62664`](https://github.com/actualbudget/actual/commit/9e62664dd348fe12f8946a2e4289da8f84324bc6) Refactor: Add retry logic to Docker build actions ### 📊 Changes **1 file changed** (+29 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/docker-edge.yml` (+29 -14) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ### Add retries to Docker edge workflow jobs This PR enhances the reliability of the Docker edge workflow by adding retry logic to critical build and push steps. **Why:** To mitigate transient failures that can occur during Docker image building and pushing, such as network issues or registry timeouts. This makes the CI/CD pipeline more robust and reduces the number of flaky runs. **What:** - Introduced `fail-fast: false` to the matrix strategy, ensuring all build variants attempt to complete. - Implemented `nick-fields/retry` for the "Build image for testing" and "Build and push images" steps, configured for 3 attempts with appropriate timeouts. - Converted the `docker/build-push-action` to raw `docker buildx build` commands to integrate with the retry action, including proper handling of Docker metadata tags. --- <a href="https://cursor.com/background-agent?bcId=bc-fdadbb13-97fa-4426-9e23-f66ae8c21d26"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-fdadbb13-97fa-4426-9e23-f66ae8c21d26"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 10:14:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#48304
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?