github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #6026] [MERGED] TypeScript: make component-library strict ts compliant (almost) #48097

New Issue
Closed
opened 2026-04-26 10:02:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 10:02:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6026
Author: @MatissJanis
Created: 10/29/2025
Status: ✅ Merged
Merged: 11/6/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/component-library-ts-strict

📝 Commits (2)

  • fb268f6 TypeScript: make component-library strict ts compliant (almost)
  • 8bd0f20 Merge branch 'master' into matiss/component-library-ts-strict

📊 Changes

3 files changed (+10 additions, -4 deletions)

View changed files

📝 packages/component-library/src/icons/index-template.ts (+1 -2)
📝 packages/component-library/src/icons/template.ts (+3 -2)
➕ upcoming-release-notes/6026.md (+6 -0)

📄 Description

Note

Add strict TypeScript typings to icon generation templates and include a maintenance release note.

  • Component Library · Icons:
    • Type index-template.ts: indexTemplate(filePaths: { path: string }[]).
    • Type template.ts: define tmpl as Options['template'] via @svgr/babel-preset.
  • Release Notes:
    • Add upcoming-release-notes/6026.md (Maintenance).

Written by Cursor Bugbot for commit 8bd0f2083d. This will update automatically on new commits. Configure here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6026 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 10/29/2025 **Status:** ✅ Merged **Merged:** 11/6/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/component-library-ts-strict` --- ### 📝 Commits (2) - [`fb268f6`](https://github.com/actualbudget/actual/commit/fb268f692cce7e43a15678a61a7d2d765efa3d33) TypeScript: make component-library strict ts compliant (almost) - [`8bd0f20`](https://github.com/actualbudget/actual/commit/8bd0f2083d85db24b742b43901fdbfae7d991f43) Merge branch 'master' into matiss/component-library-ts-strict ### 📊 Changes **3 files changed** (+10 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/component-library/src/icons/index-template.ts` (+1 -2) 📝 `packages/component-library/src/icons/template.ts` (+3 -2) ➕ `upcoming-release-notes/6026.md` (+6 -0) </details> ### 📄 Description <!-- CURSOR_SUMMARY --> > [!NOTE] > Add strict TypeScript typings to icon generation templates and include a maintenance release note. > > - **Component Library · Icons**: > - Type `index-template.ts`: `indexTemplate(filePaths: { path: string }[])`. > - Type `template.ts`: define `tmpl` as `Options['template']` via `@svgr/babel-preset`. > - **Release Notes**: > - Add `upcoming-release-notes/6026.md` (Maintenance). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 8bd0f2083d85db24b742b43901fdbfae7d991f43. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 10:02:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#48097
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?