github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #5998] [MERGED] TypeScript: TransactionEdit #48084

New Issue
Closed
opened 2026-04-26 10:01:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 10:01:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5998
Author: @MatissJanis
Created: 10/24/2025
Status: ✅ Merged
Merged: 11/8/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/transaction-edit-typescript

📝 Commits (3)

  • d741043 Convert TransactionEdit to TypeScript
  • 5c4f8cd Merge branch 'master' into matiss/transaction-edit-typescript
  • 2c25de3 Merge branch 'master' into matiss/transaction-edit-typescript

📊 Changes

3 files changed (+1567 additions, -1438 deletions)

View changed files

➖ packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (+0 -1438)
➕ packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx (+1561 -0)
➕ upcoming-release-notes/5998.md (+6 -0)

📄 Description

Technically the same logic as before.. but unfortunately there are so many type-level changes that Github isn't showing a unified diff, but instead shows it as a brand new file.

Note

Migrate mobile TransactionEdit to TypeScript with typed models/props and minor null-safety tweaks, plus maintenance release notes.

  • Mobile UI (TypeScript migration):
    • Convert packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx to TransactionEdit.tsx with strong typing (TransactionEntity, AccountEntity, CategoryEntity, PayeeEntity).
    • Typed props and callbacks (generics for onUpdate, onEditField), added null-safety/guards (e.g., Status returns null on default, optional chaining), and minor TS-related adjustments without altering behavior.
  • Release Notes:
    • Add upcoming-release-notes/5998.md (Maintenance).

Written by Cursor Bugbot for commit 2c25de3af0. This will update automatically on new commits. Configure here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5998 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 10/24/2025 **Status:** ✅ Merged **Merged:** 11/8/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/transaction-edit-typescript` --- ### 📝 Commits (3) - [`d741043`](https://github.com/actualbudget/actual/commit/d74104357beef9f2d183d69d7a09d06a73bd3a42) Convert TransactionEdit to TypeScript - [`5c4f8cd`](https://github.com/actualbudget/actual/commit/5c4f8cd29e3bade3f2cb05744a98653970597b9d) Merge branch 'master' into matiss/transaction-edit-typescript - [`2c25de3`](https://github.com/actualbudget/actual/commit/2c25de3af01dddec8696b66901e569f7168f5228) Merge branch 'master' into matiss/transaction-edit-typescript ### 📊 Changes **3 files changed** (+1567 additions, -1438 deletions) <details> <summary>View changed files</summary> ➖ `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx` (+0 -1438) ➕ `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx` (+1561 -0) ➕ `upcoming-release-notes/5998.md` (+6 -0) </details> ### 📄 Description Technically the same logic as before.. but unfortunately there are so many type-level changes that Github isn't showing a unified diff, but instead shows it as a brand new file. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Migrate mobile `TransactionEdit` to TypeScript with typed models/props and minor null-safety tweaks, plus maintenance release notes. > > - **Mobile UI (TypeScript migration)**: > - Convert `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx` to `TransactionEdit.tsx` with strong typing (`TransactionEntity`, `AccountEntity`, `CategoryEntity`, `PayeeEntity`). > - Typed props and callbacks (generics for `onUpdate`, `onEditField`), added null-safety/guards (e.g., `Status` returns `null` on default, optional chaining), and minor TS-related adjustments without altering behavior. > - **Release Notes**: > - Add `upcoming-release-notes/5998.md` (Maintenance). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 2c25de3af01dddec8696b66901e569f7168f5228. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 10:01:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#48084
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?