github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #5899] [MERGED] Add virtualizer to mobile rules list #48016

New Issue
Closed
opened 2026-04-26 09:57:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 09:57:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5899
Author: @MatissJanis
Created: 10/9/2025
Status: ✅ Merged
Merged: 10/11/2025
Merged by: @MatissJanis

Base: master ← Head: cursor/add-virtualizer-to-mobile-rules-list-9404

📝 Commits (9)

  • f17a062 Checkpoint before follow-up message
  • 5d1d9f6 docs: Add virtualizer to mobile rules list
  • dde8465 Update mobile rules description and category format
  • 51ddc96 Refactor: Update react-stately/layout and remove Virtualizer
  • a290da1 Refactor RulesList component to use memoized layout for Virtualizer
  • 843fe2f Merge branch 'cursor/add-virtualizer-to-mobile-rules-list-9404' of github.com:actualbudget/actual into cursor/add-virtualizer-to-mobile-rules-list-9404
  • 4baab6c ⬆️ Update @react-stately/layout to version 4.5.1 in package.json and yarn.lock
  • dd7f84f Remove @react-stately/layout from package.json and yarn.lock; update RulesList component to include ListLayout from react-aria-components
  • e4aa1cb Refactor RulesList component to directly use ListLayout in Virtualizer, removing the useMemo hook for layout creation.

📊 Changes

2 files changed (+30 additions, -18 deletions)

View changed files

📝 packages/desktop-client/src/components/mobile/rules/RulesList.tsx (+24 -18)
➕ upcoming-release-notes/5899.md (+6 -0)

📄 Description

Add Virtualizer from react-aria-components to RulesList to improve performance and memory efficiency for large rule lists on mobile.

Open in Cursor Open in Web

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5899 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 10/9/2025 **Status:** ✅ Merged **Merged:** 10/11/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `cursor/add-virtualizer-to-mobile-rules-list-9404` --- ### 📝 Commits (9) - [`f17a062`](https://github.com/actualbudget/actual/commit/f17a06283e1b084f79de3189b7c41645d641184a) Checkpoint before follow-up message - [`5d1d9f6`](https://github.com/actualbudget/actual/commit/5d1d9f68dc139e4f85e11406784d618be31e0fd5) docs: Add virtualizer to mobile rules list - [`dde8465`](https://github.com/actualbudget/actual/commit/dde84659992048a60a22fd5af6324ab29488caa9) Update mobile rules description and category format - [`51ddc96`](https://github.com/actualbudget/actual/commit/51ddc96d34a19854b254d3239d1261a7a556d515) Refactor: Update react-stately/layout and remove Virtualizer - [`a290da1`](https://github.com/actualbudget/actual/commit/a290da1a33b9cd107eb9cc1a85ea1befd15e7f55) Refactor RulesList component to use memoized layout for Virtualizer - [`843fe2f`](https://github.com/actualbudget/actual/commit/843fe2fb401ec25b469b52067b451fb80bac94d7) Merge branch 'cursor/add-virtualizer-to-mobile-rules-list-9404' of github.com:actualbudget/actual into cursor/add-virtualizer-to-mobile-rules-list-9404 - [`4baab6c`](https://github.com/actualbudget/actual/commit/4baab6c635b1902a77d4ea008075fe7a7fbf663b) ⬆️ Update @react-stately/layout to version 4.5.1 in package.json and yarn.lock - [`dd7f84f`](https://github.com/actualbudget/actual/commit/dd7f84f48c0d1cdafdbc544f877647522c5ebe74) Remove @react-stately/layout from package.json and yarn.lock; update RulesList component to include ListLayout from react-aria-components - [`e4aa1cb`](https://github.com/actualbudget/actual/commit/e4aa1cbcb86f7df439acbb83b67700cdd84015d9) Refactor RulesList component to directly use ListLayout in Virtualizer, removing the useMemo hook for layout creation. ### 📊 Changes **2 files changed** (+30 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/mobile/rules/RulesList.tsx` (+24 -18) ➕ `upcoming-release-notes/5899.md` (+6 -0) </details> ### 📄 Description Add `Virtualizer` from `react-aria-components` to `RulesList` to improve performance and memory efficiency for large rule lists on mobile. --- <a href="https://cursor.com/background-agent?bcId=bc-94daec79-7e71-4e3c-b954-9bb0a4b244fc"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-94daec79-7e71-4e3c-b954-9bb0a4b244fc"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 09:57:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#48016
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?