github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3334] [CLOSED] add delay when dispatching modals to prevent ghost interactions #4801

New Issue
Closed
opened 2026-02-28 21:01:28 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:01:28 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3334
Author: @tim-smart
Created: 8/31/2024
Status: ❌ Closed

Base: master ← Head: mobile-on-click

📝 Commits (5)

  • 02dbee9 use onClick instead of onPointerUp
  • 5584dd7 move onClick to Button where possible
  • 4ef5025 fix misclicks from BudgetCell
  • f26fb08 use onPointerUp for CoverModal
  • c2e76db add delay to modal dispatch to disconnect pointer events

📊 Changes

3 files changed (+112 additions, -106 deletions)

View changed files

📝 packages/desktop-client/src/components/mobile/accounts/AccountTransactions.jsx (+28 -32)
📝 packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx (+68 -74)
➕ packages/desktop-client/src/hooks/useModalDispatch.ts (+16 -0)

📄 Description

While testing on mobile, using onClick eliminated some issues where some
modals were receiving pointer up events from a previous interaction,
causing some "ghost" interations.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3334 **Author:** [@tim-smart](https://github.com/tim-smart) **Created:** 8/31/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `mobile-on-click` --- ### 📝 Commits (5) - [`02dbee9`](https://github.com/actualbudget/actual/commit/02dbee9fbbb30a749dc795ea98e42667170bcf48) use onClick instead of onPointerUp - [`5584dd7`](https://github.com/actualbudget/actual/commit/5584dd7a550d6e3c2d5a06b60a192abc870d656a) move onClick to Button where possible - [`4ef5025`](https://github.com/actualbudget/actual/commit/4ef50253d60ac41928d8c78c9f40baf37482ef7c) fix misclicks from BudgetCell - [`f26fb08`](https://github.com/actualbudget/actual/commit/f26fb08ca664f44d510dff258af5c2fbc5223e9b) use onPointerUp for CoverModal - [`c2e76db`](https://github.com/actualbudget/actual/commit/c2e76db12f84058db0143f70e830dc5627b86b75) add delay to modal dispatch to disconnect pointer events ### 📊 Changes **3 files changed** (+112 additions, -106 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/mobile/accounts/AccountTransactions.jsx` (+28 -32) 📝 `packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx` (+68 -74) ➕ `packages/desktop-client/src/hooks/useModalDispatch.ts` (+16 -0) </details> ### 📄 Description While testing on mobile, using onClick eliminated some issues where some modals were receiving pointer up events from a previous interaction, causing some "ghost" interations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:01:28 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4801
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?