github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #5827] [MERGED] expand eslint untranslated string rule #47970

New Issue
Closed
opened 2026-04-26 09:55:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 09:55:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5827
Author: @matt-fidd
Created: 9/30/2025
Status: ✅ Merged
Merged: 10/5/2025
Merged by: @matt-fidd

Base: master ← Head: expand-translate-rule

📝 Commits (5)

  • fa17c36 expand translation rule and abstract import fix implementation
  • b43b8ea fixes
  • 6189e74 note
  • 2c0add0 coderabbit
  • 5cf5a51 Merge branch 'master' into expand-translate-rule

📊 Changes

10 files changed (+307 additions, -55 deletions)

View changed files

📝 packages/desktop-client/src/components/manager/ManagementApp.tsx (+5 -1)
📝 packages/desktop-client/src/components/modals/CreateAccountModal.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/LoadBackupModal.tsx (+3 -1)
📝 packages/desktop-client/src/components/payees/ManagePayees.tsx (+3 -1)
📝 packages/desktop-client/src/components/reports/reports/NetWorth.tsx (+3 -1)
📝 packages/eslint-plugin-actual/lib/rules/no-untranslated-strings.js (+180 -5)
📝 packages/eslint-plugin-actual/lib/rules/prefer-logger-over-console.js (+11 -31)
📝 packages/eslint-plugin-actual/lib/rules/prefer-trans-over-t.js (+4 -14)
➕ packages/eslint-plugin-actual/lib/utils/import-helpers.js (+91 -0)
➕ upcoming-release-notes/5827.md (+6 -0)

📄 Description

Expands the rule to look at JSX attributes and adds fixers, also adds an abstraction for importing modules in fixers.

JSX attribute strings are pretty hard to properly identify, so to be safe and catch the low-hanging fruit I've added a whitelist so we don't start messing with function arguments or properties used for rendering instead of user-facing etc...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5827 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 9/30/2025 **Status:** ✅ Merged **Merged:** 10/5/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `expand-translate-rule` --- ### 📝 Commits (5) - [`fa17c36`](https://github.com/actualbudget/actual/commit/fa17c36eb20666736a288bc68f313912431db59e) expand translation rule and abstract import fix implementation - [`b43b8ea`](https://github.com/actualbudget/actual/commit/b43b8ea42c2f83db00e069343d4af73d7ff301fa) fixes - [`6189e74`](https://github.com/actualbudget/actual/commit/6189e74434caa16519f79a002763122ae2bb76d1) note - [`2c0add0`](https://github.com/actualbudget/actual/commit/2c0add014c660b2970e5cebd6a195935000afc0d) coderabbit - [`5cf5a51`](https://github.com/actualbudget/actual/commit/5cf5a518333025716cf451ef8d95348bcd540b27) Merge branch 'master' into expand-translate-rule ### 📊 Changes **10 files changed** (+307 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/manager/ManagementApp.tsx` (+5 -1) 📝 `packages/desktop-client/src/components/modals/CreateAccountModal.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/LoadBackupModal.tsx` (+3 -1) 📝 `packages/desktop-client/src/components/payees/ManagePayees.tsx` (+3 -1) 📝 `packages/desktop-client/src/components/reports/reports/NetWorth.tsx` (+3 -1) 📝 `packages/eslint-plugin-actual/lib/rules/no-untranslated-strings.js` (+180 -5) 📝 `packages/eslint-plugin-actual/lib/rules/prefer-logger-over-console.js` (+11 -31) 📝 `packages/eslint-plugin-actual/lib/rules/prefer-trans-over-t.js` (+4 -14) ➕ `packages/eslint-plugin-actual/lib/utils/import-helpers.js` (+91 -0) ➕ `upcoming-release-notes/5827.md` (+6 -0) </details> ### 📄 Description Expands the rule to look at JSX attributes and adds fixers, also adds an abstraction for importing modules in fixers. JSX attribute strings are pretty hard to properly identify, so to be safe and catch the low-hanging fruit I've added a whitelist so we don't start messing with function arguments or properties used for rendering instead of user-facing etc... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 09:55:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#47970
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?