[PR #3325] [MERGED] add option to select dark theme for "System default" #4797

Closed
opened 2026-02-28 21:01:25 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3325
Author: @tim-smart
Created: 8/29/2024
Status: Merged
Merged: 9/7/2024
Merged by: @matt-fidd

Base: masterHead: system-midnight


📝 Commits (6)

  • 41e5322 add option to select dark theme for "System default"
  • e4671cb add release notes
  • 65c900f Merge branch 'master' into system-midnight
  • 922c78d fix release notes
  • 2cb6656 Merge branch 'master' into system-midnight
  • b5d2a26 update visual tests

📊 Changes

11 files changed (+111 additions, -17 deletions)

View changed files

📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-6-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/settings/Themes.tsx (+73 -13)
📝 packages/desktop-client/src/style/theme.tsx (+18 -4)
📝 packages/loot-core/src/server/main.ts (+12 -0)
📝 packages/loot-core/src/types/prefs.d.ts (+2 -0)
upcoming-release-notes/3325.md (+6 -0)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3325 **Author:** [@tim-smart](https://github.com/tim-smart) **Created:** 8/29/2024 **Status:** ✅ Merged **Merged:** 9/7/2024 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `system-midnight` --- ### 📝 Commits (6) - [`41e5322`](https://github.com/actualbudget/actual/commit/41e53225691e88af6f058f1596a14b1c570c2bdd) add option to select dark theme for "System default" - [`e4671cb`](https://github.com/actualbudget/actual/commit/e4671cb345b0581619957eed6e6ade9d8a222601) add release notes - [`65c900f`](https://github.com/actualbudget/actual/commit/65c900fa4f9e2682be8c15bfdcfde7319f82ed5c) Merge branch 'master' into system-midnight - [`922c78d`](https://github.com/actualbudget/actual/commit/922c78de9311cbfc61f3b149d73dd3dfe9a47874) fix release notes - [`2cb6656`](https://github.com/actualbudget/actual/commit/2cb66560b80bb3446d25fd10b645a473eb1e21eb) Merge branch 'master' into system-midnight - [`b5d2a26`](https://github.com/actualbudget/actual/commit/b5d2a26134754e552395ecc27f2b0e1310e7e096) update visual tests ### 📊 Changes **11 files changed** (+111 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-6-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/settings.test.js-snapshots/Settings-checks-the-page-visuals-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/settings/Themes.tsx` (+73 -13) 📝 `packages/desktop-client/src/style/theme.tsx` (+18 -4) 📝 `packages/loot-core/src/server/main.ts` (+12 -0) 📝 `packages/loot-core/src/types/prefs.d.ts` (+2 -0) ➕ `upcoming-release-notes/3325.md` (+6 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:01:25 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4797