github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 11:42:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3300] [MERGED] :electron: Notarize the mac desktop app #4785

New Issue
Closed
opened 2026-02-28 21:01:15 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:01:15 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3300
Author: @MikesGlitch
Created: 8/20/2024
Status: ✅ Merged
Merged: 8/22/2024
Merged by: @MikesGlitch

Base: master ← Head: electron/mac-notarization

📝 Commits (10+)

  • e4ba304 adding notarization stuff back in
  • 7d7e202 win csc settings so win build doesnt try to sign with mac stuff
  • 518163f windows doesnt need to know about mac build
  • 51e662f teamid env var instead of config val as per docs
  • 5aedeef for testing purposes only
  • b2f5051 probably wont work
  • f98b220 yet, didnt work
  • 6d29165 try this
  • 720eff5 update notarize
  • a4f239d removing test code

📊 Changes

4 files changed (+23 additions, -13 deletions)

View changed files

📝 .github/workflows/electron-master.yml (+7 -3)
📝 packages/desktop-electron/package.json (+1 -1)
➕ upcoming-release-notes/3300.md (+6 -0)
📝 yarn.lock (+9 -9)

📄 Description

Should close these:
https://github.com/actualbudget/actual/issues/3259
https://github.com/actualbudget/actual/issues/3088

Tested with this artifact: https://github.com/MikesGlitch/actual/actions/runs/10496563766

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3300 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 8/20/2024 **Status:** ✅ Merged **Merged:** 8/22/2024 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `electron/mac-notarization` --- ### 📝 Commits (10+) - [`e4ba304`](https://github.com/actualbudget/actual/commit/e4ba304d641d95fce06f696d4587fd4f97d2cbd6) adding notarization stuff back in - [`7d7e202`](https://github.com/actualbudget/actual/commit/7d7e202e946d69f025a43bddfe06add4e6db8aa7) win csc settings so win build doesnt try to sign with mac stuff - [`518163f`](https://github.com/actualbudget/actual/commit/518163ff9bfe2ca5382f1cdc561eeeede24743e1) windows doesnt need to know about mac build - [`51e662f`](https://github.com/actualbudget/actual/commit/51e662fc186aec53d968be4a680d39c968010bcd) teamid env var instead of config val as per docs - [`5aedeef`](https://github.com/actualbudget/actual/commit/5aedeefb120f9bd08fd861315b57d534541f1053) for testing purposes only - [`b2f5051`](https://github.com/actualbudget/actual/commit/b2f505191afc97692e049d5597639236d510ed19) probably wont work - [`f98b220`](https://github.com/actualbudget/actual/commit/f98b2202358ea5003b3339cfebba2ad73083ab2c) yet, didnt work - [`6d29165`](https://github.com/actualbudget/actual/commit/6d2916569f69e1e8feb7e810058d92e868160b50) try this - [`720eff5`](https://github.com/actualbudget/actual/commit/720eff596d3b14439d83eae67f33abf4a36ae43e) update notarize - [`a4f239d`](https://github.com/actualbudget/actual/commit/a4f239dc6f696c6f6b8ea58e5d3646c2bde921a9) removing test code ### 📊 Changes **4 files changed** (+23 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/electron-master.yml` (+7 -3) 📝 `packages/desktop-electron/package.json` (+1 -1) ➕ `upcoming-release-notes/3300.md` (+6 -0) 📝 `yarn.lock` (+9 -9) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Should close these: https://github.com/actualbudget/actual/issues/3259 https://github.com/actualbudget/actual/issues/3088 Tested with this artifact: https://github.com/MikesGlitch/actual/actions/runs/10496563766 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:01:15 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4785
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?